From: Andrea Arcangeli <aarcange@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org
Subject: Re: mmotm 2010-12-16-14-56 uploaded (hugetlb)
Date: Sat, 18 Dec 2010 08:44:56 +0100 [thread overview]
Message-ID: <20101218074456.GW1671@random.random> (raw)
In-Reply-To: <20101217233740.GR1671@random.random>
On Sat, Dec 18, 2010 at 12:37:40AM +0100, Andrea Arcangeli wrote:
> Yes, it used to build just fine but I guess after the last hugetlbfs
> updates I'm getting flood of errors no matter how I adjust things.
> hugetlbfs code who needs some fixup here.
here's the fix (luckily I didn't need to touch a bit of
hugetlbfs). I think initially the only thing I was reusing sometime
was pmd_huge that made me want HUGETLBFS_PAGE (these days there's
pmd_trans_huge and pmd_huge must only be used in hugetlbfs paths, 99%
of the time they're separated). At the time it happened to build with
HUGETLBFS_PAGE=y and HUGETLBFS=n, now it's a total mixture and letting
HUGETLBFS_PAGE live seems bad idea.
====
Subject: thp: remove dependency on HUGETLB_PAGE
From: Andrea Arcangeli <aarcange@redhat.com>
THP code is already 100% standalone and not depending on a bit of hugetlbfs.
HUGETLBFS_PAGE would be better removed and unified with HUGETLBFS considering
the kernel won't build if they're not equal.
Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>
---
diff --git a/fs/Kconfig b/fs/Kconfig
--- a/fs/Kconfig
+++ b/fs/Kconfig
@@ -147,7 +147,7 @@ config HUGETLBFS
If unsure, say N.
config HUGETLB_PAGE
- def_bool HUGETLBFS || TRANSPARENT_HUGEPAGE
+ def_bool HUGETLBFS
source "fs/configfs/Kconfig"
WARNING: multiple messages have this Message-ID (diff)
From: Andrea Arcangeli <aarcange@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org
Subject: Re: mmotm 2010-12-16-14-56 uploaded (hugetlb)
Date: Sat, 18 Dec 2010 08:44:56 +0100 [thread overview]
Message-ID: <20101218074456.GW1671@random.random> (raw)
In-Reply-To: <20101217233740.GR1671@random.random>
On Sat, Dec 18, 2010 at 12:37:40AM +0100, Andrea Arcangeli wrote:
> Yes, it used to build just fine but I guess after the last hugetlbfs
> updates I'm getting flood of errors no matter how I adjust things.
> hugetlbfs code who needs some fixup here.
here's the fix (luckily I didn't need to touch a bit of
hugetlbfs). I think initially the only thing I was reusing sometime
was pmd_huge that made me want HUGETLBFS_PAGE (these days there's
pmd_trans_huge and pmd_huge must only be used in hugetlbfs paths, 99%
of the time they're separated). At the time it happened to build with
HUGETLBFS_PAGE=y and HUGETLBFS=n, now it's a total mixture and letting
HUGETLBFS_PAGE live seems bad idea.
====
Subject: thp: remove dependency on HUGETLB_PAGE
From: Andrea Arcangeli <aarcange@redhat.com>
THP code is already 100% standalone and not depending on a bit of hugetlbfs.
HUGETLBFS_PAGE would be better removed and unified with HUGETLBFS considering
the kernel won't build if they're not equal.
Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>
---
diff --git a/fs/Kconfig b/fs/Kconfig
--- a/fs/Kconfig
+++ b/fs/Kconfig
@@ -147,7 +147,7 @@ config HUGETLBFS
If unsure, say N.
config HUGETLB_PAGE
- def_bool HUGETLBFS || TRANSPARENT_HUGEPAGE
+ def_bool HUGETLBFS
source "fs/configfs/Kconfig"
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-12-18 7:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-16 22:56 mmotm 2010-12-16-14-56 uploaded akpm
2010-12-16 22:56 ` akpm
2010-12-17 22:33 ` mmotm 2010-12-16-14-56 uploaded (hugetlb) Randy Dunlap
2010-12-17 22:33 ` Randy Dunlap
2010-12-17 22:53 ` Andrew Morton
2010-12-17 22:53 ` Andrew Morton
2010-12-17 23:37 ` Andrea Arcangeli
2010-12-17 23:37 ` Andrea Arcangeli
2010-12-18 0:28 ` Randy Dunlap
2010-12-18 0:28 ` Randy Dunlap
2010-12-18 0:58 ` Andrew Morton
2010-12-18 0:58 ` Andrew Morton
2010-12-18 8:17 ` Andrea Arcangeli
2010-12-18 8:17 ` Andrea Arcangeli
2010-12-18 7:44 ` Andrea Arcangeli [this message]
2010-12-18 7:44 ` Andrea Arcangeli
2010-12-18 10:10 ` mmotm 2010-12-16 - breaks mlockall() call Valdis.Kletnieks
2010-12-20 1:48 ` Michel Lespinasse
2010-12-20 1:48 ` Michel Lespinasse
2010-12-21 6:26 ` Michel Lespinasse
2010-12-21 6:26 ` Michel Lespinasse
2010-12-22 1:07 ` Valdis.Kletnieks
2010-12-20 9:49 ` i915 modeset defunct [was: mmotm 2010-12-16-14-56 uploaded] Jiri Slaby
2010-12-20 9:52 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101218074456.GW1671@random.random \
--to=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.