From: Tony Lindgren <tony@atomide.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
Raghuveer Murthy <raghuveer.murthy@ti.com>
Subject: Re: [PATCH 2/6] OMAP4: Pandaboard: Add omap_reserve functionality
Date: Sat, 18 Dec 2010 09:20:56 -0800 [thread overview]
Message-ID: <20101218172055.GT5941@atomide.com> (raw)
In-Reply-To: <20101218082703.GB3047@n2100.arm.linux.org.uk>
* Russell King - ARM Linux <linux@arm.linux.org.uk> [101218 00:26]:
> On Fri, Dec 17, 2010 at 07:05:21PM -0800, Tony Lindgren wrote:
> > /* Maintainer: David Anders - Texas Instruments Inc */
> > .boot_params = 0x80000100,
> > .map_io = omap4_panda_map_io,
> > + .reserve = omap_reserve,
>
> Please put .reserve before .map_io.
Hmm, that's the way it should be.. But we should also correct the
earlier changes too?
See 98c672cf1fa2a56f6f43e3f48b1208b83845582c (ARM: Move platform memory
reservations out of generic code) and 71ee7dad9b69917079f24d42aff796bad7932914
(ARM: OMAP: Convert to use ->reserve method to reserve boot time memory).
In these patches .reserve is also after .map_io which is
probably not intentional?
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/6] OMAP4: Pandaboard: Add omap_reserve functionality
Date: Sat, 18 Dec 2010 09:20:56 -0800 [thread overview]
Message-ID: <20101218172055.GT5941@atomide.com> (raw)
In-Reply-To: <20101218082703.GB3047@n2100.arm.linux.org.uk>
* Russell King - ARM Linux <linux@arm.linux.org.uk> [101218 00:26]:
> On Fri, Dec 17, 2010 at 07:05:21PM -0800, Tony Lindgren wrote:
> > /* Maintainer: David Anders - Texas Instruments Inc */
> > .boot_params = 0x80000100,
> > .map_io = omap4_panda_map_io,
> > + .reserve = omap_reserve,
>
> Please put .reserve before .map_io.
Hmm, that's the way it should be.. But we should also correct the
earlier changes too?
See 98c672cf1fa2a56f6f43e3f48b1208b83845582c (ARM: Move platform memory
reservations out of generic code) and 71ee7dad9b69917079f24d42aff796bad7932914
(ARM: OMAP: Convert to use ->reserve method to reserve boot time memory).
In these patches .reserve is also after .map_io which is
probably not intentional?
Regards,
Tony
next prev parent reply other threads:[~2010-12-18 17:21 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-18 3:05 [PATCH 0/6] Misc omap board patches for v2.6.38 merge window Tony Lindgren
2010-12-18 3:05 ` Tony Lindgren
2010-12-18 3:05 ` [PATCH 1/6] omap1: Fix innovator FPGA init for multi-omap Tony Lindgren
2010-12-18 3:05 ` Tony Lindgren
2010-12-18 3:05 ` [PATCH 2/6] OMAP4: Pandaboard: Add omap_reserve functionality Tony Lindgren
2010-12-18 3:05 ` Tony Lindgren
2010-12-18 8:27 ` Russell King - ARM Linux
2010-12-18 8:27 ` Russell King - ARM Linux
2010-12-18 17:20 ` Tony Lindgren [this message]
2010-12-18 17:20 ` Tony Lindgren
2010-12-18 17:36 ` Russell King - ARM Linux
2010-12-18 17:36 ` Russell King - ARM Linux
2010-12-18 17:41 ` Tony Lindgren
2010-12-18 17:41 ` Tony Lindgren
2010-12-18 17:50 ` Russell King - ARM Linux
2010-12-18 17:50 ` Russell King - ARM Linux
2010-12-18 18:13 ` Tony Lindgren
2010-12-18 18:13 ` Tony Lindgren
2010-12-18 3:05 ` [PATCH 3/6] omap3: igepv2: Don't call gpio_set_value right aftergpio_direction_output Tony Lindgren
2010-12-18 3:05 ` Tony Lindgren
2010-12-18 3:05 ` [PATCH 4/6] omap3: igepv2: LED gpio-led:green:d1 is active low Tony Lindgren
2010-12-18 3:05 ` Tony Lindgren
2010-12-18 3:05 ` [PATCH 5/6] omap4: Add platform changes for Ambient Light sensor Tony Lindgren
2010-12-18 3:05 ` Tony Lindgren
2010-12-18 3:05 ` [PATCH 6/6] omap4: Add platform changes for PWM LED Tony Lindgren
2010-12-18 3:05 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101218172055.GT5941@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=raghuveer.murthy@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.