Re: [PATCH 6/6] omap2+: Initialize serial ports for wake-up events for n8x0

[Tony Lindgren <tony@atomide.com>]

* Kevin Hilman <khilman@deeprootsystems.com> [101213 19:17]:
> Tony Lindgren <tony@atomide.com> writes:
> 
> > Use omap_serial_init_port so we can let the serial code handle the
> > remuxing of the RX pads.
> >
> > Signed-off-by: Tony Lindgren <tony@atomide.com>
> 
> Does this work for UART wakeups on n810?  I don't see any 'idle' value
> for the pads, so I'm guessing it wont work without those, right?  Or am
> I missing something here.

Well this is still missing the gpio_request parts that are needed
for the serial port to wake. I have not added that as it currently
means we also get a gpio interrupt for every rx.

I'll do more patches to deal with the gpio parts later on.

The idle values are only needed for rx pins:

+static struct omap_device_pad serial2_pads[] __initdata = {
+       {
+               .name   = "uart3_rx_irrx.uart3_rx_irrx",
+               .flags  = OMAP_DEVICE_PAD_REMUX | OMAP_DEVICE_PAD_WAKEUP,
+               .enable = OMAP_MUX_MODE0,
+               .idle   = OMAP_MUX_MODE3        /* Mux as GPIO for idle */
+       },
+       { .name = "uart3_tx_irtx.uart3_tx_irtx", .enable = OMAP_MUX_MODE0, },
+};

For the others, nothing is done dynamically.

Regards,

Tony