From: Marcelo Tosatti <mtosatti@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org, avi@redhat.com,
aliguori@us.ibm.com
Subject: Re: [PATCH v2 2/2] qemu,qmp: convert do_inject_nmi() to QObject, QError
Date: Mon, 20 Dec 2010 08:47:46 -0200 [thread overview]
Message-ID: <20101220104746.GC16707@amt.cnet> (raw)
In-Reply-To: <20101210092026.2a1d037d@doriath>
On Fri, Dec 10, 2010 at 09:20:26AM -0200, Luiz Capitulino wrote:
> On Fri, 10 Dec 2010 14:36:08 +0800
> Lai Jiangshan <laijs@cn.fujitsu.com> wrote:
>
> > +SQMP
> > +inject_nmi
> > +----------
> > +
> > +Inject an NMI on the given CPU (x86 only).
> > +
> > +Arguments:
> > +
> > +- "cpu_index": the index of the CPU to be injected NMI (json-int)
> > +
> > +Example:
> > +
> > +-> { "execute": "inject_nmi", "arguments": { "cpu_index": 0 } }
> > +<- { "return": {} }
> > +
> > +EQMP
> > +
>
> Avi, Anthony, can you please review this? Do we expect some kind of ack from
> the guest? Do we expect it respond in some way?
Looks good to me. Don't except any response from the guest.
> Also note that the current series defines only one error condition: invalid
> cpu index. Can this fail in other ways?
> --
Not really. An NMI can be pending already (which means the current
command has no effect), but i don't see the need to report that.
WARNING: multiple messages have this Message-ID (diff)
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: avi@redhat.com, aliguori@us.ibm.com,
Lai Jiangshan <laijs@cn.fujitsu.com>,
kvm@vger.kernel.org, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH v2 2/2] qemu, qmp: convert do_inject_nmi() to QObject, QError
Date: Mon, 20 Dec 2010 08:47:46 -0200 [thread overview]
Message-ID: <20101220104746.GC16707@amt.cnet> (raw)
In-Reply-To: <20101210092026.2a1d037d@doriath>
On Fri, Dec 10, 2010 at 09:20:26AM -0200, Luiz Capitulino wrote:
> On Fri, 10 Dec 2010 14:36:08 +0800
> Lai Jiangshan <laijs@cn.fujitsu.com> wrote:
>
> > +SQMP
> > +inject_nmi
> > +----------
> > +
> > +Inject an NMI on the given CPU (x86 only).
> > +
> > +Arguments:
> > +
> > +- "cpu_index": the index of the CPU to be injected NMI (json-int)
> > +
> > +Example:
> > +
> > +-> { "execute": "inject_nmi", "arguments": { "cpu_index": 0 } }
> > +<- { "return": {} }
> > +
> > +EQMP
> > +
>
> Avi, Anthony, can you please review this? Do we expect some kind of ack from
> the guest? Do we expect it respond in some way?
Looks good to me. Don't except any response from the guest.
> Also note that the current series defines only one error condition: invalid
> cpu index. Can this fail in other ways?
> --
Not really. An NMI can be pending already (which means the current
command has no effect), but i don't see the need to report that.
next prev parent reply other threads:[~2010-12-20 11:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-10 6:36 [PATCH v2 2/2] qemu,qmp: convert do_inject_nmi() to QObject, QError Lai Jiangshan
2010-12-10 6:36 ` [Qemu-devel] [PATCH v2 2/2] qemu, qmp: " Lai Jiangshan
2010-12-10 10:30 ` [PATCH v2 2/2] qemu,qmp: " Markus Armbruster
2010-12-10 10:30 ` [Qemu-devel] Re: [PATCH v2 2/2] qemu, qmp: " Markus Armbruster
2010-12-10 11:20 ` [PATCH v2 2/2] qemu,qmp: " Luiz Capitulino
2010-12-10 11:20 ` [Qemu-devel] Re: [PATCH v2 2/2] qemu, qmp: " Luiz Capitulino
2010-12-20 10:47 ` Marcelo Tosatti [this message]
2010-12-20 10:47 ` Marcelo Tosatti
2011-01-03 17:01 ` [PATCH v2 2/2] qemu,qmp: " Luiz Capitulino
2011-01-03 17:01 ` [Qemu-devel] Re: [PATCH v2 2/2] qemu, qmp: " Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101220104746.GC16707@amt.cnet \
--to=mtosatti@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=laijs@cn.fujitsu.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.