[Buildroot] [PATCH] New package: bwm-ng

[Buildroot] [PATCH] New package: bwm-ng

[keguang.zhang at gmail.com]

From: Kelvin Cheung <keguang.zhang@gmail.com>

Add new package: bwm-ng

Bandwidth Monitor NG is a small and console-based live network and
disk-io bandwidth monitor for Linux, BSD, Solaris, Mac OS X and others.

Signed-off-by: Kelvin Cheung <keguang.zhang@gmail.com>
---
 package/Config.in        |    1 +
 package/bwm-ng/Config.in |    7 +++++++
 package/bwm-ng/bwm-ng.mk |   16 ++++++++++++++++
 3 files changed, 24 insertions(+), 0 deletions(-)
 create mode 100644 package/bwm-ng/Config.in
 create mode 100644 package/bwm-ng/bwm-ng.mk

diff --git a/package/Config.in b/package/Config.in
index d3ae75e..2648062 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -148,6 +148,7 @@ endmenu
 
 menu "Hardware handling"
 source "package/acpid/Config.in"
+source "package/bwm-ng/Config.in"
 source "package/cdrkit/Config.in"
 source "package/cramfs/Config.in"
 source "package/dbus/Config.in"
diff --git a/package/bwm-ng/Config.in b/package/bwm-ng/Config.in
new file mode 100644
index 0000000..f2f8b12
--- /dev/null
+++ b/package/bwm-ng/Config.in
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_BWM_NG
+	bool "bwm-ng"
+	help
+	  Bandwidth Monitor NG is a small and console-based live network and
+	  disk-io bandwidth monitor for Linux, BSD, Solaris, Mac OS X and others.
+
+	  http://sourceforge.net/projects/bwmng/
diff --git a/package/bwm-ng/bwm-ng.mk b/package/bwm-ng/bwm-ng.mk
new file mode 100644
index 0000000..7fd5b38
--- /dev/null
+++ b/package/bwm-ng/bwm-ng.mk
@@ -0,0 +1,16 @@
+#############################################################
+#
+# bwm-ng
+#
+#############################################################
+BWM_NG_VERSION:=0.6
+BWM_NG:=bwm-ng-$(BWM_NG_VERSION).tar.gz
+BWM_NG_SITE:=http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/project/bwmng/bwmng/0.6/
+BWM_NG_CONF_OPT = --with-procnetdev --with-diskstats
+
+ifeq ($(BR2_PACKAGE_NCURSES),y)
+BWM_NG_CONF_OPT += --with-ncurses
+BWM_NG_DEPENDENCIES += ncurses
+endif
+
+$(eval $(call AUTOTARGETS,package,bwm-ng))
-- 
1.7.1

[Buildroot] [PATCH] New package: bwm-ng

[Kelvin Cheung]

Hi Thomas,

Please review this patch.
Thanks!

2010/12/21 <keguang.zhang@gmail.com>

> From: Kelvin Cheung <keguang.zhang@gmail.com>
>
> Add new package: bwm-ng
>
> Bandwidth Monitor NG is a small and console-based live network and
> disk-io bandwidth monitor for Linux, BSD, Solaris, Mac OS X and others.
>
> Signed-off-by: Kelvin Cheung <keguang.zhang@gmail.com>
> ---
>  package/Config.in        |    1 +
>  package/bwm-ng/Config.in |    7 +++++++
>  package/bwm-ng/bwm-ng.mk |   16 ++++++++++++++++
>  3 files changed, 24 insertions(+), 0 deletions(-)
>  create mode 100644 package/bwm-ng/Config.in
>  create mode 100644 package/bwm-ng/bwm-ng.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index d3ae75e..2648062 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -148,6 +148,7 @@ endmenu
>
>  menu "Hardware handling"
>  source "package/acpid/Config.in"
> +source "package/bwm-ng/Config.in"
>  source "package/cdrkit/Config.in"
>  source "package/cramfs/Config.in"
>  source "package/dbus/Config.in"
> diff --git a/package/bwm-ng/Config.in b/package/bwm-ng/Config.in
> new file mode 100644
> index 0000000..f2f8b12
> --- /dev/null
> +++ b/package/bwm-ng/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_BWM_NG
> +       bool "bwm-ng"
> +       help
> +         Bandwidth Monitor NG is a small and console-based live network
> and
> +         disk-io bandwidth monitor for Linux, BSD, Solaris, Mac OS X and
> others.
> +
> +         http://sourceforge.net/projects/bwmng/
> diff --git a/package/bwm-ng/bwm-ng.mk b/package/bwm-ng/bwm-ng.mk
> new file mode 100644
> index 0000000..7fd5b38
> --- /dev/null
> +++ b/package/bwm-ng/bwm-ng.mk
> @@ -0,0 +1,16 @@
> +#############################################################
> +#
> +# bwm-ng
> +#
> +#############################################################
> +BWM_NG_VERSION:=0.6
> +BWM_NG:=bwm-ng-$(BWM_NG_VERSION).tar.gz
> +BWM_NG_SITE:=http://$(BR2_SOURCEFORGE_MIRROR).
> dl.sourceforge.net/project/bwmng/bwmng/0.6/
> +BWM_NG_CONF_OPT = --with-procnetdev --with-diskstats
> +
> +ifeq ($(BR2_PACKAGE_NCURSES),y)
> +BWM_NG_CONF_OPT += --with-ncurses
> +BWM_NG_DEPENDENCIES += ncurses
> +endif
> +
> +$(eval $(call AUTOTARGETS,package,bwm-ng))
> --
> 1.7.1
>
>


-- 
Best Regards!
Kelvin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20101221/aa1bbad1/attachment.html>

[Buildroot] [PATCH] New package: bwm-ng

[Belisko Marek]

Hi,

some comments for use ncurses:
Seems this package should be build with or without ncurses.
What about add some menu entry for that? Like for example qt.
Normally user didn't check mk  file just select package.

On Tue, Dec 21, 2010 at 9:55 AM,  <keguang.zhang@gmail.com> wrote:
> From: Kelvin Cheung <keguang.zhang@gmail.com>
>
> Add new package: bwm-ng
>
> Bandwidth Monitor NG is a small and console-based live network and
> disk-io bandwidth monitor for Linux, BSD, Solaris, Mac OS X and others.
>
> Signed-off-by: Kelvin Cheung <keguang.zhang@gmail.com>
> ---
> ?package/Config.in ? ? ? ?| ? ?1 +
> ?package/bwm-ng/Config.in | ? ?7 +++++++
> ?package/bwm-ng/bwm-ng.mk | ? 16 ++++++++++++++++
> ?3 files changed, 24 insertions(+), 0 deletions(-)
> ?create mode 100644 package/bwm-ng/Config.in
> ?create mode 100644 package/bwm-ng/bwm-ng.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index d3ae75e..2648062 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -148,6 +148,7 @@ endmenu
>
> ?menu "Hardware handling"
> ?source "package/acpid/Config.in"
> +source "package/bwm-ng/Config.in"
> ?source "package/cdrkit/Config.in"
> ?source "package/cramfs/Config.in"
> ?source "package/dbus/Config.in"
> diff --git a/package/bwm-ng/Config.in b/package/bwm-ng/Config.in
> new file mode 100644
> index 0000000..f2f8b12
> --- /dev/null
> +++ b/package/bwm-ng/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_BWM_NG
> + ? ? ? bool "bwm-ng"
> + ? ? ? help
> + ? ? ? ? Bandwidth Monitor NG is a small and console-based live network and
> + ? ? ? ? disk-io bandwidth monitor for Linux, BSD, Solaris, Mac OS X and others.
> +
> + ? ? ? ? http://sourceforge.net/projects/bwmng/
Add selection for ncurses:
+config BR2_PACKAGE_BWM_NG_NCURSES
+        bool "bwm_ng with ncurses"
+         depends on BR2_PACKAGE_BWM_NG
+         select BR2_PACKAGE_NCURSES
> diff --git a/package/bwm-ng/bwm-ng.mk b/package/bwm-ng/bwm-ng.mk
> new file mode 100644
> index 0000000..7fd5b38
> --- /dev/null
> +++ b/package/bwm-ng/bwm-ng.mk
> @@ -0,0 +1,16 @@
> +#############################################################
> +#
> +# bwm-ng
> +#
> +#############################################################
> +BWM_NG_VERSION:=0.6
> +BWM_NG:=bwm-ng-$(BWM_NG_VERSION).tar.gz
> +BWM_NG_SITE:=http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/project/bwmng/bwmng/0.6/
> +BWM_NG_CONF_OPT = --with-procnetdev --with-diskstats
> +
> +ifeq ($(BR2_PACKAGE_NCURSES),y)
use instead: +ifeq($(BR2_PACKAGE_BWM_NG_NCURSES),y)
> +BWM_NG_CONF_OPT += --with-ncurses
> +BWM_NG_DEPENDENCIES += ncurses
> +endif
> +
> +$(eval $(call AUTOTARGETS,package,bwm-ng))
> --
> 1.7.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>

thanks,

marek

-- 
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
icq: 290551086
web: http://open-nandra.com

[Buildroot] [PATCH] New package: bwm-ng

[Thomas Petazzoni]

Hello,

On Tue, 21 Dec 2010 11:32:38 +0100
Belisko Marek <marek.belisko@gmail.com> wrote:

> some comments for use ncurses:
> Seems this package should be build with or without ncurses.
> What about add some menu entry for that? Like for example qt.
> Normally user didn't check mk  file just select package.

For many packages, we do as Kelvin did initially: if the dependency is
available, we use it, if not, we silently work without it. Admittedly,
it's a bit "hidden" from the user, but that's the only solution to not
have hundreds or thousands of options in the configuration interface.

So I'd prefer to keep what Kelvin did on this.

Regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH] New package: bwm-ng

[Kelvin Cheung]

So, will this patch be accepted ?

2010/12/21 Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

> Hello,
>
> On Tue, 21 Dec 2010 11:32:38 +0100
> Belisko Marek <marek.belisko@gmail.com> wrote:
>
> > some comments for use ncurses:
> > Seems this package should be build with or without ncurses.
> > What about add some menu entry for that? Like for example qt.
> > Normally user didn't check mk  file just select package.
>
> For many packages, we do as Kelvin did initially: if the dependency is
> available, we use it, if not, we silently work without it. Admittedly,
> it's a bit "hidden" from the user, but that's the only solution to not
> have hundreds or thousands of options in the configuration interface.
>
> So I'd prefer to keep what Kelvin did on this.
>
> Regards,
>
> Thomas
> --
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com
>



-- 
Best Regards!
Kelvin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20101221/0e19e0f8/attachment.html>