[PATCH] Add Lenovo Ideapad S12 to acer blacklist

[PATCH] Add Lenovo Ideapad S12 to acer blacklist

[Lee, Chun-Yi]

The Lenovo Ideapad S12's _WDG have GUID that matches with AMW0, it causes
acer-wmi driver auto-probe when system boot but there already have
ideapad-laptop driver to support Ideapad serial.
So, add Lenovo Ideapad S12 to acer blacklist to disable it.

Signed-off-by: Lee, Chun-Yi <jlee@novell.com>
Tested-by: Ville-Pekka Vainio <vpivaini@cs.helsinki.fi>
Cc: Carlos Corbacho <carlos@strangeworlds.co.uk>
Cc: Thomas Renninger <trenn@suse.de>
Cc: Dmitry Torokhov <dtor@mail.ru>
Cc: Corentin Chary <corentincj@iksaif.net>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>
---
 drivers/platform/x86/acer-wmi.c |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index 28288ad..387ac7c 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -310,6 +310,17 @@ static struct dmi_system_id __devinitdata acer_blacklist[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "AOA150"),
 		},
 	},
+	/*
+	 * The Lenovo Ideapad S12 have GUID that matches with AMW0 - disable it.
+	 * There already have ideapad-laptop driver to support Ideapad serial.
+	 */
+	{
+		.ident = "Lenovo Ideapad S12",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "20021,2959"),
+		},
+	},
 	{}
 };
 
-- 
1.6.0.2

Re: [PATCH] Add Lenovo Ideapad S12 to acer blacklist

[Matthew Garrett]

On Thu, Dec 30, 2010 at 09:32:54AM +0800, Lee, Chun-Yi wrote:
> The Lenovo Ideapad S12's _WDG have GUID that matches with AMW0, it causes
> acer-wmi driver auto-probe when system boot but there already have
> ideapad-laptop driver to support Ideapad serial.
> So, add Lenovo Ideapad S12 to acer blacklist to disable it.

This seems like it could be handled better. Does the interface fail, or 
does it merely duplicate the functionality of the ideapad driver?

-- 
Matthew Garrett | mjg59@srcf.ucam.org

Re: [PATCH] Add Lenovo Ideapad S12 to acer blacklist

[Joey Lee]

Add Cc. issue reporter Ville-Pekka Vainio <vpivaini@cs.helsinki.fi>

Hi Matthew, 

於 四，2010-12-30 於 01:41 +0000，Matthew Garrett 提到：
> On Thu, Dec 30, 2010 at 09:32:54AM +0800, Lee, Chun-Yi wrote:
> > The Lenovo Ideapad S12's _WDG have GUID that matches with AMW0, it causes
> > acer-wmi driver auto-probe when system boot but there already have
> > ideapad-laptop driver to support Ideapad serial.
> > So, add Lenovo Ideapad S12 to acer blacklist to disable it.
> 
> This seems like it could be handled better. Does the interface fail, or 
> does it merely duplicate the functionality of the ideapad driver?
> 

Ville-Pekka Vainio reported this issue, acer-wmi adds a soft blocked
wifi killswitch, which can't be unblocked with rfkill. It causes
NetworkManager on Fedora have problem.

Vainio said ideapad-laptop driver handle the killswitches better, there
is mail loop for discuss this issue:

http://www.mail-archive.com/platform-driver-x86@vger.kernel.org/msg01027.html


Thank's a lot!
Joey Lee


                                從: 
Ville-Pekka Vainio
<vpivaini@cs.helsinki.fi>
                                至: 
platform-driver-x86@vger.kernel.org
                              主旨: 
acer-wmi is unnecessarily loaded on
a Lenovo Ideapad S12
                              日期: 
Tue, 28 Dec 2010 14:31:45 +0200
(20:31 CST)


Hi,

I hope I'm on the right mailing list for this issue. The kernel (I'm
using Fedora's 2.6.37rc7) loads the acer-wmi module on a Lenovo Ideapad
S12 netbook and I think that's not necessary. Loading the module causes
problems with NetworkManager, the wireless network can't be enabled at
all. This seems to happen because acer-wmi adds a soft blocked wifi
killswitch, which can't be unblocked with rfkill.

Now that the kernel has the ideapad-laptop module, which seems to handle
the killswitches better, acer-wmi could probably be disabled with this
netbook. I know almost nothing about ACPI/WMI myself, which is why I'm
writing on the list instead of just fixing this.

-- 
Ville-Pekka Vainio