All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ted Ts'o" <tytso@mit.edu>
To: Dan Carpenter <error27@gmail.com>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>,
	Jan Kara <jack@suse.cz>, Christoph Hellwig <hch@lst.de>,
	Eric Sandeen <sandeen@redhat.com>,
	Dmitry Monakhov <dmonakhov@openvz.org>,
	linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] ext4: checking NULL instead of ERR_PTR
Date: Thu, 30 Dec 2010 03:55:53 +0000	[thread overview]
Message-ID: <20101230035553.GL10149@thunk.org> (raw)
In-Reply-To: <20100826091619.GC20072@bicker>

On Thu, Aug 26, 2010 at 11:16:54AM +0200, Dan Carpenter wrote:
> d_path() returns an ERR_PTR and it doesn't return NULL.  This is in
> ext4_error_file() and no one actually calls ext4_error_file().
> 
> Signed-off-by: Dan Carpenter <error27@gmail.com>

Thanks, I've added this to the ext4 patch tree.

	     	   	       	    	  - Ted

WARNING: multiple messages have this Message-ID (diff)
From: Ted Ts'o <tytso@mit.edu>
To: Dan Carpenter <error27@gmail.com>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>,
	Jan Kara <jack@suse.cz>, Christoph Hellwig <hch@lst.de>,
	Eric Sandeen <sandeen@redhat.com>,
	Dmitry Monakhov <dmonakhov@openvz.org>,
	linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] ext4: checking NULL instead of ERR_PTR
Date: Wed, 29 Dec 2010 22:55:53 -0500	[thread overview]
Message-ID: <20101230035553.GL10149@thunk.org> (raw)
In-Reply-To: <20100826091619.GC20072@bicker>

On Thu, Aug 26, 2010 at 11:16:54AM +0200, Dan Carpenter wrote:
> d_path() returns an ERR_PTR and it doesn't return NULL.  This is in
> ext4_error_file() and no one actually calls ext4_error_file().
> 
> Signed-off-by: Dan Carpenter <error27@gmail.com>

Thanks, I've added this to the ext4 patch tree.

	     	   	       	    	  - Ted

  reply	other threads:[~2010-12-30  3:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-26  9:16 [patch] ext4: checking NULL instead of ERR_PTR Dan Carpenter
2010-08-26  9:16 ` Dan Carpenter
2010-12-30  3:55 ` Ted Ts'o [this message]
2010-12-30  3:55   ` Ted Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101230035553.GL10149@thunk.org \
    --to=tytso@mit.edu \
    --cc=adilger.kernel@dilger.ca \
    --cc=dmonakhov@openvz.org \
    --cc=error27@gmail.com \
    --cc=hch@lst.de \
    --cc=jack@suse.cz \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=sandeen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.