From: Thomas Monjalon <thomas@monjalon.net>
To: David Hunt <david.hunt@intel.com>
Cc: dev@dpdk.org, liang.j.ma@intel.com
Subject: Re: [PATCH] lib/power: fix error handling on setting governor
Date: Mon, 14 Jan 2019 23:45:37 +0100 [thread overview]
Message-ID: <2010732.Y0ziD7SgTV@xps> (raw)
In-Reply-To: <20190108145926.37367-1-david.hunt@intel.com>
08/01/2019 15:59, David Hunt:
> In the power_set_governor_*() functions, we using fputs() on /sys
> filesystem. However, we also need to call fflush() to ensure that
> the write completes successfully. Otherwise the attempt to set the
> power governor fails and the function returns as if it has
> succeeded. This patch adds an fflush to ensure that the
> write succeeds, otherwise returns an error.
>
> Fixes: e6c6dc0f96c8 ("power: add p-state driver compatibility")
>
> Signed-off-by: David Hunt <david.hunt@intel.com>
Applied, thanks
prev parent reply other threads:[~2019-01-14 22:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-08 14:59 [PATCH] lib/power: fix error handling on setting governor David Hunt
2019-01-14 22:45 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2010732.Y0ziD7SgTV@xps \
--to=thomas@monjalon.net \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=liang.j.ma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.