diff for duplicates of <20110103054833.GT1886@bicker> diff --git a/a/1.txt b/N1/1.txt index 61698a0..37840d0 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -7,10 +7,10 @@ index b837c5b..ff340e3 100644 --- a/drivers/scsi/device_handler/scsi_dh.c +++ b/drivers/scsi/device_handler/scsi_dh.c @@ -446,7 +446,7 @@ int scsi_dh_activate(struct request_queue *q, activate_complete fn, void *data) - sdev->sdev_state = SDEV_CANCEL || - sdev->sdev_state = SDEV_DEL) + sdev->sdev_state == SDEV_CANCEL || + sdev->sdev_state == SDEV_DEL) err = SCSI_DH_NOSYS; -- if (sdev->sdev_state = SDEV_OFFLINE) -+ if (sdev && sdev->sdev_state = SDEV_OFFLINE) +- if (sdev->sdev_state == SDEV_OFFLINE) ++ if (sdev && sdev->sdev_state == SDEV_OFFLINE) err = SCSI_DH_DEV_OFFLINED; spin_unlock_irqrestore(q->queue_lock, flags); diff --git a/a/content_digest b/N1/content_digest index dc578d6..b17ec95 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,6 +1,6 @@ "From\0Dan Carpenter <error27@gmail.com>\0" - "Subject\0[patch] [SCSI] scsi_dh: potential null dereference in\0" - "Date\0Mon, 03 Jan 2011 05:48:33 +0000\0" + "Subject\0[patch] [SCSI] scsi_dh: potential null dereference in scsi_dh_activate()\0" + "Date\0Mon, 3 Jan 2011 08:48:33 +0300\0" "To\0James E.J. Bottomley <James.Bottomley@suse.de>\0" "Cc\0Mike Snitzer <snitzer@redhat.com>" Menny Hamburger <Menny_Hamburger@dell.com> @@ -18,12 +18,12 @@ "--- a/drivers/scsi/device_handler/scsi_dh.c\n" "+++ b/drivers/scsi/device_handler/scsi_dh.c\n" "@@ -446,7 +446,7 @@ int scsi_dh_activate(struct request_queue *q, activate_complete fn, void *data)\n" - " \t sdev->sdev_state = SDEV_CANCEL ||\n" - " \t sdev->sdev_state = SDEV_DEL)\n" + " \t sdev->sdev_state == SDEV_CANCEL ||\n" + " \t sdev->sdev_state == SDEV_DEL)\n" " \t\terr = SCSI_DH_NOSYS;\n" - "-\tif (sdev->sdev_state = SDEV_OFFLINE)\n" - "+\tif (sdev && sdev->sdev_state = SDEV_OFFLINE)\n" + "-\tif (sdev->sdev_state == SDEV_OFFLINE)\n" + "+\tif (sdev && sdev->sdev_state == SDEV_OFFLINE)\n" " \t\terr = SCSI_DH_DEV_OFFLINED;\n" " \tspin_unlock_irqrestore(q->queue_lock, flags);" -2114b0c4215bac80a15b7b2a59e55ca11def84f8aeebd93ccdc1bd09b403f894 +c6cf54cc9d5a23974cc22a6b040179e831d7a02e378abaaae105a1384f84ea85
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.