From: Dan Carpenter <error27@gmail.com>
To: "James E.J. Bottomley" <James.Bottomley@suse.de>
Cc: Mike Snitzer <snitzer@redhat.com>,
Menny Hamburger <Menny_Hamburger@Dell.com>,
Babu Moger <babu.moger@lsi.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch] [SCSI] scsi_dh: potential null dereference in
Date: Mon, 03 Jan 2011 05:48:33 +0000 [thread overview]
Message-ID: <20110103054833.GT1886@bicker> (raw)
We assumed "sdev" could be NULL ealier, so lets check it here as well.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/scsi/device_handler/scsi_dh.c b/drivers/scsi/device_handler/scsi_dh.c
index b837c5b..ff340e3 100644
--- a/drivers/scsi/device_handler/scsi_dh.c
+++ b/drivers/scsi/device_handler/scsi_dh.c
@@ -446,7 +446,7 @@ int scsi_dh_activate(struct request_queue *q, activate_complete fn, void *data)
sdev->sdev_state = SDEV_CANCEL ||
sdev->sdev_state = SDEV_DEL)
err = SCSI_DH_NOSYS;
- if (sdev->sdev_state = SDEV_OFFLINE)
+ if (sdev && sdev->sdev_state = SDEV_OFFLINE)
err = SCSI_DH_DEV_OFFLINED;
spin_unlock_irqrestore(q->queue_lock, flags);
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: "James E.J. Bottomley" <James.Bottomley@suse.de>
Cc: Mike Snitzer <snitzer@redhat.com>,
Menny Hamburger <Menny_Hamburger@Dell.com>,
Babu Moger <babu.moger@lsi.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch] [SCSI] scsi_dh: potential null dereference in scsi_dh_activate()
Date: Mon, 3 Jan 2011 08:48:33 +0300 [thread overview]
Message-ID: <20110103054833.GT1886@bicker> (raw)
We assumed "sdev" could be NULL ealier, so lets check it here as well.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/scsi/device_handler/scsi_dh.c b/drivers/scsi/device_handler/scsi_dh.c
index b837c5b..ff340e3 100644
--- a/drivers/scsi/device_handler/scsi_dh.c
+++ b/drivers/scsi/device_handler/scsi_dh.c
@@ -446,7 +446,7 @@ int scsi_dh_activate(struct request_queue *q, activate_complete fn, void *data)
sdev->sdev_state == SDEV_CANCEL ||
sdev->sdev_state == SDEV_DEL)
err = SCSI_DH_NOSYS;
- if (sdev->sdev_state == SDEV_OFFLINE)
+ if (sdev && sdev->sdev_state == SDEV_OFFLINE)
err = SCSI_DH_DEV_OFFLINED;
spin_unlock_irqrestore(q->queue_lock, flags);
next reply other threads:[~2011-01-03 5:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-03 5:48 Dan Carpenter [this message]
2011-01-03 5:48 ` [patch] [SCSI] scsi_dh: potential null dereference in scsi_dh_activate() Dan Carpenter
2011-01-04 16:13 ` [patch] [SCSI] scsi_dh: potential null dereference in Moger, Babu
2011-01-04 16:13 ` [patch] [SCSI] scsi_dh: potential null dereference in scsi_dh_activate() Moger, Babu
2011-01-04 16:24 ` [patch] [SCSI] scsi_dh: potential null dereference in James Bottomley
2011-01-04 16:24 ` [patch] [SCSI] scsi_dh: potential null dereference in scsi_dh_activate() James Bottomley
2011-01-04 19:50 ` [patch] [SCSI] scsi_dh: potential null dereference in Moger, Babu
2011-01-04 19:50 ` [patch] [SCSI] scsi_dh: potential null dereference in scsi_dh_activate() Moger, Babu
2011-01-04 19:58 ` [patch] [SCSI] scsi_dh: potential null dereference in James Bottomley
2011-01-04 19:58 ` [patch] [SCSI] scsi_dh: potential null dereference in scsi_dh_activate() James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110103054833.GT1886@bicker \
--to=error27@gmail.com \
--cc=James.Bottomley@suse.de \
--cc=Menny_Hamburger@Dell.com \
--cc=babu.moger@lsi.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.