From: Dan Carpenter <error27@gmail.com>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: James Bottomley <James.Bottomley@suse.de>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: [patch 2/2] [SCSI] target: unlock on error path in configfs
Date: Mon, 03 Jan 2011 05:59:20 +0000 [thread overview]
Message-ID: <20110103055920.GV1886@bicker> (raw)
If the user wrote a wrong value to the file the it would lead to a dead
lock eventually.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c
index d7b977d..2764510 100644
--- a/drivers/target/target_core_configfs.c
+++ b/drivers/target/target_core_configfs.c
@@ -660,6 +660,7 @@ static ssize_t target_core_dev_store_attr_##_name( \
} \
ret = strict_strtoul(page, 0, &val); \
if (ret < 0) { \
+ spin_unlock(&se_dev->se_dev_lock); \
printk(KERN_ERR "strict_strtoul() failed with" \
" ret: %d\n", ret); \
return -EINVAL; \
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: James Bottomley <James.Bottomley@suse.de>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: [patch 2/2] [SCSI] target: unlock on error path in configfs
Date: Mon, 3 Jan 2011 08:59:20 +0300 [thread overview]
Message-ID: <20110103055920.GV1886@bicker> (raw)
If the user wrote a wrong value to the file the it would lead to a dead
lock eventually.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c
index d7b977d..2764510 100644
--- a/drivers/target/target_core_configfs.c
+++ b/drivers/target/target_core_configfs.c
@@ -660,6 +660,7 @@ static ssize_t target_core_dev_store_attr_##_name( \
} \
ret = strict_strtoul(page, 0, &val); \
if (ret < 0) { \
+ spin_unlock(&se_dev->se_dev_lock); \
printk(KERN_ERR "strict_strtoul() failed with" \
" ret: %d\n", ret); \
return -EINVAL; \
next reply other threads:[~2011-01-03 5:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-03 5:59 Dan Carpenter [this message]
2011-01-03 5:59 ` [patch 2/2] [SCSI] target: unlock on error path in configfs Dan Carpenter
2011-01-04 23:40 ` Nicholas A. Bellinger
2011-01-04 23:40 ` Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110103055920.GV1886@bicker \
--to=error27@gmail.com \
--cc=James.Bottomley@suse.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.