From: Christoph Egger <Christoph.Egger@amd.com>
To: xen-devel@lists.xensource.com
Cc: "Zhang, Yang Z" <yang.z.zhang@intel.com>, Keir Fraser <keir@xen.org>
Subject: Re: [PATCH] fix build error in libxl
Date: Mon, 3 Jan 2011 14:40:08 +0100 [thread overview]
Message-ID: <201101031440.09061.Christoph.Egger@amd.com> (raw)
In-Reply-To: <749B9D3DBF0F054390025D9EAFF47F223195EEB1@shsmsx501.ccr.corp.intel.com>
On Thursday 23 December 2010 03:08:38 Zhang, Yang Z wrote:
> Move free(disks) into the bracket, or it will show error 'disks' used
> uninitialized when build libxl.
I have the same build problem. My patch is very similar:
http://lists.xensource.com/archives/html/xen-devel/2010-12/msg01011.html
Christoph
>
> best regards
> yang
>
> diff -r f69037cc4674 tools/libxl/libxl.c
> --- a/tools/libxl/libxl.c Wed Dec 22 17:48:31 2010 +0000
> +++ b/tools/libxl/libxl.c Thu Dec 23 10:03:35 2010 +0800
> @@ -1402,8 +1402,8 @@
> }
> libxl_device_disk_destroy(&disks[i]);
> }
> + free(disks);
> }
> - free(disks);
> flexarray_set(dm_args, num++, NULL);
> return (char **) flexarray_contents(dm_args);
> }
>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
--
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
next prev parent reply other threads:[~2011-01-03 13:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-09 12:39 [PATCH 0 of 5] support of NUMA topology in xl Juergen Gross
2010-12-09 12:39 ` [PATCH 1 of 5] Support getting topology info in libxl Juergen Gross
2010-12-09 13:11 ` Gianni Tedesco
2010-12-09 13:19 ` Juergen Gross
2010-12-10 17:30 ` Ian Jackson
2010-12-09 12:39 ` [PATCH 2 of 5] support topolgy info in xl info Juergen Gross
2010-12-09 12:39 ` [PATCH 3 of 5] Extend cpupools to support numa Juergen Gross
2010-12-09 12:39 ` [PATCH 4 of 5] Support renaming of cpupools Juergen Gross
2010-12-09 12:39 ` [PATCH 5 of 5] Support new xl command cpupool-numa-split Juergen Gross
2010-12-17 6:09 ` [PATCH 0 of 5] support of NUMA topology in xl Juergen Gross
2010-12-17 17:46 ` Ian Jackson
2010-12-17 17:50 ` Keir Fraser
2010-12-17 21:42 ` [PATCH] xl: fix compilation warning on libxl.c Wei Huang
2010-12-23 2:08 ` [PATCH] fix build error in libxl Zhang, Yang Z
2011-01-03 13:40 ` Christoph Egger [this message]
2011-01-05 23:39 ` [PATCH] xl: fix compilation warning on libxl.c [and 2 more messages] Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201101031440.09061.Christoph.Egger@amd.com \
--to=christoph.egger@amd.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xensource.com \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.