From: Dan Carpenter <error27@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Andy Whitcroft <apw@canonical.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] checkpatch: putting the && or || on the wrong line
Date: Tue, 04 Jan 2011 09:24:31 +0000 [thread overview]
Message-ID: <20110104092431.GB1886@bicker> (raw)
In-Reply-To: <1294124330.6617.15.camel@Joe-Laptop>
On Mon, Jan 03, 2011 at 10:58:50PM -0800, Joe Perches wrote:
> On Tue, 2011-01-04 at 08:59 +0300, Dan Carpenter wrote:
> > + WARN("put the && or || at the end of the previous line\n" . $herecurr);
>
> I've submitted something like this a couple of times and gotten
> various objections but I think it's sensible.
>
> https://lkml.org/lkml/2009/12/5/65
> https://lkml.org/lkml/2010/7/11/92
If everyone except you thinks it's a waste of time, then stop asking me
to redo my patches. :/ I don't care either way so long as CodingStyle
and checkpatch reflect the rules.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Andy Whitcroft <apw@canonical.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] checkpatch: putting the && or || on the wrong line
Date: Tue, 4 Jan 2011 12:24:31 +0300 [thread overview]
Message-ID: <20110104092431.GB1886@bicker> (raw)
In-Reply-To: <1294124330.6617.15.camel@Joe-Laptop>
On Mon, Jan 03, 2011 at 10:58:50PM -0800, Joe Perches wrote:
> On Tue, 2011-01-04 at 08:59 +0300, Dan Carpenter wrote:
> > + WARN("put the && or || at the end of the previous line\n" . $herecurr);
>
> I've submitted something like this a couple of times and gotten
> various objections but I think it's sensible.
>
> https://lkml.org/lkml/2009/12/5/65
> https://lkml.org/lkml/2010/7/11/92
If everyone except you thinks it's a waste of time, then stop asking me
to redo my patches. :/ I don't care either way so long as CodingStyle
and checkpatch reflect the rules.
regards,
dan carpenter
next prev parent reply other threads:[~2011-01-04 9:24 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 5:59 [patch] checkpatch: putting the && or || on the wrong line Dan Carpenter
2011-01-04 5:59 ` Dan Carpenter
2011-01-04 6:58 ` Joe Perches
2011-01-04 6:58 ` Joe Perches
2011-01-04 9:24 ` Dan Carpenter [this message]
2011-01-04 9:24 ` Dan Carpenter
2011-01-05 10:24 ` Martin Knoblauch
2011-01-05 10:24 ` Martin Knoblauch
2011-01-04 16:38 ` J. Bruce Fields
2011-01-04 16:38 ` J. Bruce Fields
2011-01-04 16:44 ` Samuel Thibault
2011-01-04 16:44 ` Samuel Thibault
2011-01-04 17:07 ` Joe Perches
2011-01-04 17:07 ` Joe Perches
2011-01-05 17:38 ` Krzysztof Halasa
2011-01-05 17:38 ` Krzysztof Halasa
2011-01-05 17:45 ` Joe Perches
2011-01-05 17:45 ` Joe Perches
2011-01-06 12:11 ` Martin Knoblauch
2011-01-06 12:11 ` Martin Knoblauch
2011-01-06 17:43 ` Valdis.Kletnieks
2011-01-06 17:43 ` Valdis.Kletnieks
2011-01-06 12:32 ` Krzysztof Halasa
2011-01-06 12:32 ` Krzysztof Halasa
2011-01-06 17:57 ` Joe Perches
2011-01-06 17:57 ` Joe Perches
2011-01-06 20:23 ` Krzysztof Halasa
2011-01-06 20:23 ` Krzysztof Halasa
2011-01-06 21:02 ` Joe Perches
2011-01-06 21:02 ` Joe Perches
2011-01-06 21:14 ` Krzysztof Halasa
2011-01-06 21:14 ` Krzysztof Halasa
2011-01-06 21:38 ` Joe Perches
2011-01-06 21:38 ` Joe Perches
2011-01-07 17:12 ` Valdis.Kletnieks
2011-01-07 17:12 ` Valdis.Kletnieks
2011-01-08 13:42 ` Krzysztof Halasa
2011-01-08 13:42 ` Krzysztof Halasa
2011-01-08 17:12 ` Joe Perches
2011-01-08 17:12 ` Joe Perches
2011-01-06 11:55 ` Martin Knoblauch
2011-01-06 11:55 ` Martin Knoblauch
2011-01-06 12:38 ` Krzysztof Halasa
2011-01-06 12:38 ` Krzysztof Halasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110104092431.GB1886@bicker \
--to=error27@gmail.com \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.