* [RFC patch 2/5] trace event skb fix unassigned field
2011-01-04 23:16 [RFC patch 0/5] Trace event fixes and cleanups Mathieu Desnoyers
@ 2011-01-04 23:16 ` Mathieu Desnoyers
0 siblings, 0 replies; 8+ messages in thread
From: Mathieu Desnoyers @ 2011-01-04 23:16 UTC (permalink / raw)
To: LKML
Cc: Mathieu Desnoyers, Steven Rostedt, Frederic Weisbecker,
Ingo Molnar, Neil Horman, Thomas Gleixner
[-- Attachment #1: trace-event-skb-fix-unassigned-field.patch --]
[-- Type: text/plain, Size: 985 bytes --]
The field "protocol" in event kfree_skb is left unassigned if skb is NULL,
leaving its trace output as garbage. Assign the value to 0 when skb is NULL
instead.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
CC: Steven Rostedt <rostedt@goodmis.org>
CC: Frederic Weisbecker <fweisbec@gmail.com>
CC: Ingo Molnar <mingo@elte.hu>
CC: Neil Horman <nhorman@tuxdriver.com>
CC: Thomas Gleixner <tglx@linutronix.de>
---
include/trace/events/skb.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
Index: linux-2.6-lttng/include/trace/events/skb.h
===================================================================
--- linux-2.6-lttng.orig/include/trace/events/skb.h
+++ linux-2.6-lttng/include/trace/events/skb.h
@@ -25,9 +25,7 @@ TRACE_EVENT(kfree_skb,
TP_fast_assign(
__entry->skbaddr = skb;
- if (skb) {
- __entry->protocol = ntohs(skb->protocol);
- }
+ __entry->protocol = skb ? ntohs(skb->protocol) : 0;
__entry->location = location;
),
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFC patch 2/5] trace event skb fix unassigned field
[not found] <E1PaGZY-0001EI-BD@smtp.tuxdriver.com>
@ 2011-01-04 23:54 ` Frederic Weisbecker
2011-01-05 0:40 ` Mathieu Desnoyers
0 siblings, 1 reply; 8+ messages in thread
From: Frederic Weisbecker @ 2011-01-04 23:54 UTC (permalink / raw)
To: nhorman@tuxdriver.com, Mathieu Desnoyers
Cc: LKML, Steven Rostedt, Ingo Molnar, Thomas Gleixner
On Tue, Jan 04, 2011 at 06:46:06PM -0500, nhorman@tuxdriver.com wrote:
> Acked- by: Neil Horman <nhorman@tuxdriver.com>
>
>
> Sent from my Verizon Wireless Phone
>
> ----- Reply message -----
> From: "Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>
> Date: Tue, Jan 4, 2011 6:16 pm
> Subject: [RFC patch 2/5] trace event skb fix unassigned field
> To: "LKML" <linux-kernel@vger.kernel.org>
> Cc: "Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>, "Steven Rostedt" <rostedt@goodmis.org>, "Frederic Weisbecker" <fweisbec@gmail.com>, "Ingo Molnar" <mingo@elte.hu>, "Neil Horman" <nhorman@tuxdriver.com>, "Thomas Gleixner" <tglx@linutronix.de>
>
>
> The field "protocol" in event kfree_skb is left unassigned if skb is NULL,
> leaving its trace output as garbage. Assign the value to 0 when skb is NULL
> instead.
Hm, if the skb is already null, we probably shouldn't send any trace.
What about using TP_CONDITION() ?
>
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> CC: Steven Rostedt <rostedt@goodmis.org>
> CC: Frederic Weisbecker <fweisbec@gmail.com>
> CC: Ingo Molnar <mingo@elte.hu>
> CC: Neil Horman <nhorman@tuxdriver.com>
> CC: Thomas Gleixner <tglx@linutronix.de>
> ---
> include/trace/events/skb.h | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> Index: linux-2.6-lttng/include/trace/events/skb.h
> ===================================================================
> --- linux-2.6-lttng.orig/include/trace/events/skb.h
> +++ linux-2.6-lttng/include/trace/events/skb.h
> @@ -25,9 +25,7 @@ TRACE_EVENT(kfree_skb,
>
> TP_fast_assign(
> __entry->skbaddr = skb;
> - if (skb) {
> - __entry->protocol = ntohs(skb->protocol);
> - }
> + __entry->protocol = skb ? ntohs(skb->protocol) : 0;
> __entry->location = location;
> ),
>
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFC patch 2/5] trace event skb fix unassigned field
2011-01-04 23:54 ` [RFC patch 2/5] trace event skb fix unassigned field Frederic Weisbecker
@ 2011-01-05 0:40 ` Mathieu Desnoyers
2011-01-05 0:49 ` Frederic Weisbecker
0 siblings, 1 reply; 8+ messages in thread
From: Mathieu Desnoyers @ 2011-01-05 0:40 UTC (permalink / raw)
To: Frederic Weisbecker, Zhaolei
Cc: nhorman@tuxdriver.com, LKML, Steven Rostedt, Ingo Molnar,
Thomas Gleixner
* Frederic Weisbecker (fweisbec@gmail.com) wrote:
> On Tue, Jan 04, 2011 at 06:46:06PM -0500, nhorman@tuxdriver.com wrote:
> > Acked- by: Neil Horman <nhorman@tuxdriver.com>
> >
> >
> > Sent from my Verizon Wireless Phone
> >
> > ----- Reply message -----
> > From: "Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>
> > Date: Tue, Jan 4, 2011 6:16 pm
> > Subject: [RFC patch 2/5] trace event skb fix unassigned field
> > To: "LKML" <linux-kernel@vger.kernel.org>
> > Cc: "Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>, "Steven Rostedt" <rostedt@goodmis.org>, "Frederic Weisbecker" <fweisbec@gmail.com>, "Ingo Molnar" <mingo@elte.hu>, "Neil Horman" <nhorman@tuxdriver.com>, "Thomas Gleixner" <tglx@linutronix.de>
> >
> >
> > The field "protocol" in event kfree_skb is left unassigned if skb is NULL,
> > leaving its trace output as garbage. Assign the value to 0 when skb is NULL
> > instead.
>
> Hm, if the skb is already null, we probably shouldn't send any trace.
>
> What about using TP_CONDITION() ?
Hrm, let's see. It's been introduced by commit
5cb3d1d9d34ac04bcaa2034139345b2a5fea54c1
by Zhaolei.
Event at the time of that commit, the only caller looked like:
void kfree_skb(struct sk_buff *skb)
{
if (unlikely(!skb))
return;
if (likely(atomic_read(&skb->users) == 1))
smp_rmb();
else if (likely(!atomic_dec_and_test(&skb->users)))
return;
trace_kfree_skb(skb, __builtin_return_address(0));
__kfree_skb(skb);
}
EXPORT_SYMBOL(kfree_skb);
So it already checks for a null pointer before calling the tracepoint. This
leads me to wonder why why this check was added in the first place ?
Mathieu
>
> >
> > Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> > CC: Steven Rostedt <rostedt@goodmis.org>
> > CC: Frederic Weisbecker <fweisbec@gmail.com>
> > CC: Ingo Molnar <mingo@elte.hu>
> > CC: Neil Horman <nhorman@tuxdriver.com>
> > CC: Thomas Gleixner <tglx@linutronix.de>
> > ---
> > include/trace/events/skb.h | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > Index: linux-2.6-lttng/include/trace/events/skb.h
> > ===================================================================
> > --- linux-2.6-lttng.orig/include/trace/events/skb.h
> > +++ linux-2.6-lttng/include/trace/events/skb.h
> > @@ -25,9 +25,7 @@ TRACE_EVENT(kfree_skb,
> >
> > TP_fast_assign(
> > __entry->skbaddr = skb;
> > - if (skb) {
> > - __entry->protocol = ntohs(skb->protocol);
> > - }
> > + __entry->protocol = skb ? ntohs(skb->protocol) : 0;
> > __entry->location = location;
> > ),
> >
> >
> >
--
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFC patch 2/5] trace event skb fix unassigned field
2011-01-05 0:40 ` Mathieu Desnoyers
@ 2011-01-05 0:49 ` Frederic Weisbecker
2011-01-05 1:21 ` Mathieu Desnoyers
0 siblings, 1 reply; 8+ messages in thread
From: Frederic Weisbecker @ 2011-01-05 0:49 UTC (permalink / raw)
To: Mathieu Desnoyers
Cc: Zhaolei, nhorman@tuxdriver.com, LKML, Steven Rostedt, Ingo Molnar,
Thomas Gleixner
On Tue, Jan 04, 2011 at 07:40:38PM -0500, Mathieu Desnoyers wrote:
> * Frederic Weisbecker (fweisbec@gmail.com) wrote:
> > On Tue, Jan 04, 2011 at 06:46:06PM -0500, nhorman@tuxdriver.com wrote:
> > > Acked- by: Neil Horman <nhorman@tuxdriver.com>
> > >
> > >
> > > Sent from my Verizon Wireless Phone
> > >
> > > ----- Reply message -----
> > > From: "Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>
> > > Date: Tue, Jan 4, 2011 6:16 pm
> > > Subject: [RFC patch 2/5] trace event skb fix unassigned field
> > > To: "LKML" <linux-kernel@vger.kernel.org>
> > > Cc: "Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>, "Steven Rostedt" <rostedt@goodmis.org>, "Frederic Weisbecker" <fweisbec@gmail.com>, "Ingo Molnar" <mingo@elte.hu>, "Neil Horman" <nhorman@tuxdriver.com>, "Thomas Gleixner" <tglx@linutronix.de>
> > >
> > >
> > > The field "protocol" in event kfree_skb is left unassigned if skb is NULL,
> > > leaving its trace output as garbage. Assign the value to 0 when skb is NULL
> > > instead.
> >
> > Hm, if the skb is already null, we probably shouldn't send any trace.
> >
> > What about using TP_CONDITION() ?
>
> Hrm, let's see. It's been introduced by commit
> 5cb3d1d9d34ac04bcaa2034139345b2a5fea54c1
> by Zhaolei.
>
> Event at the time of that commit, the only caller looked like:
>
> void kfree_skb(struct sk_buff *skb)
> {
> if (unlikely(!skb))
> return;
> if (likely(atomic_read(&skb->users) == 1))
> smp_rmb();
> else if (likely(!atomic_dec_and_test(&skb->users)))
> return;
> trace_kfree_skb(skb, __builtin_return_address(0));
> __kfree_skb(skb);
> }
> EXPORT_SYMBOL(kfree_skb);
>
> So it already checks for a null pointer before calling the tracepoint. This
> leads me to wonder why why this check was added in the first place ?
Likely for no strong reasons :)
So I guess we can remove the check from the tracepoint?
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFC patch 2/5] trace event skb fix unassigned field
2011-01-05 0:49 ` Frederic Weisbecker
@ 2011-01-05 1:21 ` Mathieu Desnoyers
2011-01-05 11:59 ` Neil Horman
0 siblings, 1 reply; 8+ messages in thread
From: Mathieu Desnoyers @ 2011-01-05 1:21 UTC (permalink / raw)
To: Frederic Weisbecker
Cc: Zhaolei, nhorman@tuxdriver.com, LKML, Steven Rostedt, Ingo Molnar,
Thomas Gleixner
* Frederic Weisbecker (fweisbec@gmail.com) wrote:
> On Tue, Jan 04, 2011 at 07:40:38PM -0500, Mathieu Desnoyers wrote:
> > * Frederic Weisbecker (fweisbec@gmail.com) wrote:
> > > On Tue, Jan 04, 2011 at 06:46:06PM -0500, nhorman@tuxdriver.com wrote:
> > > > Acked- by: Neil Horman <nhorman@tuxdriver.com>
> > > >
> > > >
> > > > Sent from my Verizon Wireless Phone
> > > >
> > > > ----- Reply message -----
> > > > From: "Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>
> > > > Date: Tue, Jan 4, 2011 6:16 pm
> > > > Subject: [RFC patch 2/5] trace event skb fix unassigned field
> > > > To: "LKML" <linux-kernel@vger.kernel.org>
> > > > Cc: "Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>, "Steven Rostedt" <rostedt@goodmis.org>, "Frederic Weisbecker" <fweisbec@gmail.com>, "Ingo Molnar" <mingo@elte.hu>, "Neil Horman" <nhorman@tuxdriver.com>, "Thomas Gleixner" <tglx@linutronix.de>
> > > >
> > > >
> > > > The field "protocol" in event kfree_skb is left unassigned if skb is NULL,
> > > > leaving its trace output as garbage. Assign the value to 0 when skb is NULL
> > > > instead.
> > >
> > > Hm, if the skb is already null, we probably shouldn't send any trace.
> > >
> > > What about using TP_CONDITION() ?
> >
> > Hrm, let's see. It's been introduced by commit
> > 5cb3d1d9d34ac04bcaa2034139345b2a5fea54c1
> > by Zhaolei.
> >
> > Event at the time of that commit, the only caller looked like:
> >
> > void kfree_skb(struct sk_buff *skb)
> > {
> > if (unlikely(!skb))
> > return;
> > if (likely(atomic_read(&skb->users) == 1))
> > smp_rmb();
> > else if (likely(!atomic_dec_and_test(&skb->users)))
> > return;
> > trace_kfree_skb(skb, __builtin_return_address(0));
> > __kfree_skb(skb);
> > }
> > EXPORT_SYMBOL(kfree_skb);
> >
> > So it already checks for a null pointer before calling the tracepoint. This
> > leads me to wonder why why this check was added in the first place ?
>
> Likely for no strong reasons :)
>
> So I guess we can remove the check from the tracepoint?
Yep, leading to this patch instead:
trace event skb remove duplicate null-pointer check
The check for NULL skb in the kfree_skb trace event is a duplicate from the
check already done in its only caller, kfree_skb(). Remove this duplicate check.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
CC: Steven Rostedt <rostedt@goodmis.org>
CC: Frederic Weisbecker <fweisbec@gmail.com>
CC: Ingo Molnar <mingo@elte.hu>
CC: Thomas Gleixner <tglx@linutronix.de>
CC: Neil Horman <nhorman@tuxdriver.com>
---
include/trace/events/skb.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
Index: linux-2.6-lttng/include/trace/events/skb.h
===================================================================
--- linux-2.6-lttng.orig/include/trace/events/skb.h
+++ linux-2.6-lttng/include/trace/events/skb.h
@@ -25,9 +25,7 @@ TRACE_EVENT(kfree_skb,
TP_fast_assign(
__entry->skbaddr = skb;
- if (skb) {
- __entry->protocol = ntohs(skb->protocol);
- }
+ __entry->protocol = ntohs(skb->protocol);
__entry->location = location;
),
--
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFC patch 2/5] trace event skb fix unassigned field
2011-01-05 1:21 ` Mathieu Desnoyers
@ 2011-01-05 11:59 ` Neil Horman
2011-01-05 13:26 ` Mathieu Desnoyers
2011-01-06 0:01 ` Steven Rostedt
0 siblings, 2 replies; 8+ messages in thread
From: Neil Horman @ 2011-01-05 11:59 UTC (permalink / raw)
To: Mathieu Desnoyers
Cc: Frederic Weisbecker, Zhaolei, LKML, Steven Rostedt, Ingo Molnar,
Thomas Gleixner
On Tue, Jan 04, 2011 at 08:21:23PM -0500, Mathieu Desnoyers wrote:
> * Frederic Weisbecker (fweisbec@gmail.com) wrote:
> > On Tue, Jan 04, 2011 at 07:40:38PM -0500, Mathieu Desnoyers wrote:
> > > * Frederic Weisbecker (fweisbec@gmail.com) wrote:
> > > > On Tue, Jan 04, 2011 at 06:46:06PM -0500, nhorman@tuxdriver.com wrote:
> > > > > Acked- by: Neil Horman <nhorman@tuxdriver.com>
> > > > >
> > > > >
> > > > > Sent from my Verizon Wireless Phone
> > > > >
> > > > > ----- Reply message -----
> > > > > From: "Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>
> > > > > Date: Tue, Jan 4, 2011 6:16 pm
> > > > > Subject: [RFC patch 2/5] trace event skb fix unassigned field
> > > > > To: "LKML" <linux-kernel@vger.kernel.org>
> > > > > Cc: "Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>, "Steven Rostedt" <rostedt@goodmis.org>, "Frederic Weisbecker" <fweisbec@gmail.com>, "Ingo Molnar" <mingo@elte.hu>, "Neil Horman" <nhorman@tuxdriver.com>, "Thomas Gleixner" <tglx@linutronix.de>
> > > > >
> > > > >
> > > > > The field "protocol" in event kfree_skb is left unassigned if skb is NULL,
> > > > > leaving its trace output as garbage. Assign the value to 0 when skb is NULL
> > > > > instead.
> > > >
> > > > Hm, if the skb is already null, we probably shouldn't send any trace.
> > > >
> > > > What about using TP_CONDITION() ?
> > >
> > > Hrm, let's see. It's been introduced by commit
> > > 5cb3d1d9d34ac04bcaa2034139345b2a5fea54c1
> > > by Zhaolei.
> > >
> > > Event at the time of that commit, the only caller looked like:
> > >
> > > void kfree_skb(struct sk_buff *skb)
> > > {
> > > if (unlikely(!skb))
> > > return;
> > > if (likely(atomic_read(&skb->users) == 1))
> > > smp_rmb();
> > > else if (likely(!atomic_dec_and_test(&skb->users)))
> > > return;
> > > trace_kfree_skb(skb, __builtin_return_address(0));
> > > __kfree_skb(skb);
> > > }
> > > EXPORT_SYMBOL(kfree_skb);
> > >
> > > So it already checks for a null pointer before calling the tracepoint. This
> > > leads me to wonder why why this check was added in the first place ?
> >
> > Likely for no strong reasons :)
> >
> > So I guess we can remove the check from the tracepoint?
>
> Yep, leading to this patch instead:
>
> trace event skb remove duplicate null-pointer check
>
> The check for NULL skb in the kfree_skb trace event is a duplicate from the
> check already done in its only caller, kfree_skb(). Remove this duplicate check.
>
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> CC: Steven Rostedt <rostedt@goodmis.org>
> CC: Frederic Weisbecker <fweisbec@gmail.com>
> CC: Ingo Molnar <mingo@elte.hu>
> CC: Thomas Gleixner <tglx@linutronix.de>
> CC: Neil Horman <nhorman@tuxdriver.com>
> ---
> include/trace/events/skb.h | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> Index: linux-2.6-lttng/include/trace/events/skb.h
> ===================================================================
> --- linux-2.6-lttng.orig/include/trace/events/skb.h
> +++ linux-2.6-lttng/include/trace/events/skb.h
> @@ -25,9 +25,7 @@ TRACE_EVENT(kfree_skb,
>
> TP_fast_assign(
> __entry->skbaddr = skb;
> - if (skb) {
> - __entry->protocol = ntohs(skb->protocol);
> - }
> + __entry->protocol = ntohs(skb->protocol);
> __entry->location = location;
> ),
>
>
>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
> --
> Mathieu Desnoyers
> Operating System Efficiency R&D Consultant
> EfficiOS Inc.
> http://www.efficios.com
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFC patch 2/5] trace event skb fix unassigned field
2011-01-05 11:59 ` Neil Horman
@ 2011-01-05 13:26 ` Mathieu Desnoyers
2011-01-06 0:01 ` Steven Rostedt
1 sibling, 0 replies; 8+ messages in thread
From: Mathieu Desnoyers @ 2011-01-05 13:26 UTC (permalink / raw)
To: Neil Horman
Cc: Frederic Weisbecker, Zhaolei, LKML, Steven Rostedt, Ingo Molnar,
Thomas Gleixner
* Neil Horman (nhorman@tuxdriver.com) wrote:
[...]
> > trace event skb remove duplicate null-pointer check
> >
> > The check for NULL skb in the kfree_skb trace event is a duplicate from the
> > check already done in its only caller, kfree_skb(). Remove this duplicate check.
> >
> > Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> > CC: Steven Rostedt <rostedt@goodmis.org>
> > CC: Frederic Weisbecker <fweisbec@gmail.com>
> > CC: Ingo Molnar <mingo@elte.hu>
> > CC: Thomas Gleixner <tglx@linutronix.de>
> > CC: Neil Horman <nhorman@tuxdriver.com>
> > ---
> > include/trace/events/skb.h | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > Index: linux-2.6-lttng/include/trace/events/skb.h
> > ===================================================================
> > --- linux-2.6-lttng.orig/include/trace/events/skb.h
> > +++ linux-2.6-lttng/include/trace/events/skb.h
> > @@ -25,9 +25,7 @@ TRACE_EVENT(kfree_skb,
> >
> > TP_fast_assign(
> > __entry->skbaddr = skb;
> > - if (skb) {
> > - __entry->protocol = ntohs(skb->protocol);
> > - }
> > + __entry->protocol = ntohs(skb->protocol);
> > __entry->location = location;
> > ),
> >
> >
> >
> Acked-by: Neil Horman <nhorman@tuxdriver.com>
Thanks!
Mathieu
>
> > --
> > Mathieu Desnoyers
> > Operating System Efficiency R&D Consultant
> > EfficiOS Inc.
> > http://www.efficios.com
> >
--
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFC patch 2/5] trace event skb fix unassigned field
2011-01-05 11:59 ` Neil Horman
2011-01-05 13:26 ` Mathieu Desnoyers
@ 2011-01-06 0:01 ` Steven Rostedt
1 sibling, 0 replies; 8+ messages in thread
From: Steven Rostedt @ 2011-01-06 0:01 UTC (permalink / raw)
To: Neil Horman
Cc: Mathieu Desnoyers, Frederic Weisbecker, Zhaolei, LKML,
Ingo Molnar, Thomas Gleixner
On Wed, 2011-01-05 at 06:59 -0500, Neil Horman wrote:
> > Yep, leading to this patch instead:
> >
> > trace event skb remove duplicate null-pointer check
> >
> > The check for NULL skb in the kfree_skb trace event is a duplicate from the
> > check already done in its only caller, kfree_skb(). Remove this duplicate check.
> >
> Acked-by: Neil Horman <nhorman@tuxdriver.com>
Mathieu, can you repost this as a non-RFC patch, and include Neil's
acked-by.
Thanks,
-- Steve
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2011-01-06 0:01 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E1PaGZY-0001EI-BD@smtp.tuxdriver.com>
2011-01-04 23:54 ` [RFC patch 2/5] trace event skb fix unassigned field Frederic Weisbecker
2011-01-05 0:40 ` Mathieu Desnoyers
2011-01-05 0:49 ` Frederic Weisbecker
2011-01-05 1:21 ` Mathieu Desnoyers
2011-01-05 11:59 ` Neil Horman
2011-01-05 13:26 ` Mathieu Desnoyers
2011-01-06 0:01 ` Steven Rostedt
2011-01-04 23:16 [RFC patch 0/5] Trace event fixes and cleanups Mathieu Desnoyers
2011-01-04 23:16 ` [RFC patch 2/5] trace event skb fix unassigned field Mathieu Desnoyers
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.