From: anarsoul@gmail.com (Vasily Khoruzhick)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] leds/h1940: Use gpiolib for latch access / fix build failure
Date: Wed, 5 Jan 2011 09:08:13 +0200 [thread overview]
Message-ID: <201101050908.14661.anarsoul@gmail.com> (raw)
In-Reply-To: <20110104153725.2f3fede2.akpm@linux-foundation.org>
On Wednesday 05 January 2011 01:37:25 Andrew Morton wrote:
> On Fri, 10 Dec 2010 00:16:57 +0200
>
> Vasily Khoruzhick <anarsoul@gmail.com> wrote:
> > On Friday 10 December 2010 00:04:52 Peter Huewe wrote:
> > > This patch fixes a build failure by converting leds-h1940.c to use
> > > gpiolib for latch access introduced by 14477095abc6
> > > (ARM: h1940: Use gpiolib for latch access)
> > >
> > > Unfortunately this driver was not converted back then.
> >
> > I sent similar patch (however, my patch does gpio_request/gpio_free)
> > ~month ago.
> >
> > Here's link:
> > http://www.spinics.net/lists/arm-kernel/msg103429.html
>
> So which patch to use?
>
> I queued Peter's patch because it's simpler. I queued it for
> 2.6.38-rc1, taged for backporting into 2.6.37.x, so we have a bit of
> time to think about it.
It's simplier, but it does not request gpio before use. It will work, but will
print nasty warning.
Regards,
Vasily
WARNING: multiple messages have this Message-ID (diff)
From: Vasily Khoruzhick <anarsoul@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Peter Huewe <peterhuewe@gmx.de>, Ben Dooks <ben-linux@fluff.org>,
Vincent Sanders <support@simtec.co.uk>,
Russell King <linux@arm.linux.org.uk>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Richard Purdie <rpurdie@rpsys.net>
Subject: Re: [PATCH] leds/h1940: Use gpiolib for latch access / fix build failure
Date: Wed, 5 Jan 2011 09:08:13 +0200 [thread overview]
Message-ID: <201101050908.14661.anarsoul@gmail.com> (raw)
In-Reply-To: <20110104153725.2f3fede2.akpm@linux-foundation.org>
On Wednesday 05 January 2011 01:37:25 Andrew Morton wrote:
> On Fri, 10 Dec 2010 00:16:57 +0200
>
> Vasily Khoruzhick <anarsoul@gmail.com> wrote:
> > On Friday 10 December 2010 00:04:52 Peter Huewe wrote:
> > > This patch fixes a build failure by converting leds-h1940.c to use
> > > gpiolib for latch access introduced by 14477095abc6
> > > (ARM: h1940: Use gpiolib for latch access)
> > >
> > > Unfortunately this driver was not converted back then.
> >
> > I sent similar patch (however, my patch does gpio_request/gpio_free)
> > ~month ago.
> >
> > Here's link:
> > http://www.spinics.net/lists/arm-kernel/msg103429.html
>
> So which patch to use?
>
> I queued Peter's patch because it's simpler. I queued it for
> 2.6.38-rc1, taged for backporting into 2.6.37.x, so we have a bit of
> time to think about it.
It's simplier, but it does not request gpio before use. It will work, but will
print nasty warning.
Regards,
Vasily
next prev parent reply other threads:[~2011-01-05 7:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-09 22:04 [PATCH] leds/h1940: Use gpiolib for latch access / fix build failure Peter Huewe
2010-12-09 22:04 ` Peter Huewe
2010-12-09 22:16 ` Vasily Khoruzhick
2010-12-09 22:16 ` Vasily Khoruzhick
2011-01-04 23:37 ` Andrew Morton
2011-01-04 23:37 ` Andrew Morton
2011-01-05 7:08 ` Vasily Khoruzhick [this message]
2011-01-05 7:08 ` Vasily Khoruzhick
2011-01-06 16:03 ` Vasily Khoruzhick
2011-01-06 16:03 ` Vasily Khoruzhick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201101050908.14661.anarsoul@gmail.com \
--to=anarsoul@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.