All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Ball <cjb@laptop.org>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-mmc@vger.kernel.org, linux-sh@vger.kernel.org,
	Ian Molton <ian@mnementh.co.uk>
Subject: Re: [PATCH] mmc: tmio_mmc: fix PIO fallback on DMA descriptor allocation failure
Date: Wed, 5 Jan 2011 19:42:09 +0000	[thread overview]
Message-ID: <20110105194209.GB9198@void.printf.net> (raw)
In-Reply-To: <Pine.LNX.4.64.1011111215120.15747@axis700.grange>

Hi Guennadi,

On Thu, Nov 11, 2010 at 12:19:47PM +0100, Guennadi Liakhovetski wrote:
> The easiest way to fall back to PIO, when a DMA descriptor allocation fails is
> to disable DMA on the controller but continue with the current request in PIO
> mode. This way tmio_mmc_start_dma() can become void, since it cannot be failing
> any more. The current version is also broken: it is testing a wrong 
> pointer and thus failing to recognise, that a descriptor allocation wasn't 
> successful.
> 
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>

Thanks, pushed to mmc-next for .38.  I wrapped the commit message back
to 72 chars, so that it doesn't overflow when running "git log" on an
80-char term.

-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

WARNING: multiple messages have this Message-ID (diff)
From: Chris Ball <cjb@laptop.org>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-mmc@vger.kernel.org, linux-sh@vger.kernel.org,
	Ian Molton <ian@mnementh.co.uk>
Subject: Re: [PATCH] mmc: tmio_mmc: fix PIO fallback on DMA descriptor
Date: Wed, 05 Jan 2011 19:42:09 +0000	[thread overview]
Message-ID: <20110105194209.GB9198@void.printf.net> (raw)
In-Reply-To: <Pine.LNX.4.64.1011111215120.15747@axis700.grange>

Hi Guennadi,

On Thu, Nov 11, 2010 at 12:19:47PM +0100, Guennadi Liakhovetski wrote:
> The easiest way to fall back to PIO, when a DMA descriptor allocation fails is
> to disable DMA on the controller but continue with the current request in PIO
> mode. This way tmio_mmc_start_dma() can become void, since it cannot be failing
> any more. The current version is also broken: it is testing a wrong 
> pointer and thus failing to recognise, that a descriptor allocation wasn't 
> successful.
> 
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>

Thanks, pushed to mmc-next for .38.  I wrapped the commit message back
to 72 chars, so that it doesn't overflow when running "git log" on an
80-char term.

-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

  reply	other threads:[~2011-01-05 19:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-11 11:19 [PATCH] mmc: tmio_mmc: fix PIO fallback on DMA descriptor allocation failure Guennadi Liakhovetski
2010-11-11 11:19 ` [PATCH] mmc: tmio_mmc: fix PIO fallback on DMA descriptor allocation Guennadi Liakhovetski
2011-01-05 19:42 ` Chris Ball [this message]
2011-01-05 19:42   ` [PATCH] mmc: tmio_mmc: fix PIO fallback on DMA descriptor Chris Ball

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110105194209.GB9198@void.printf.net \
    --to=cjb@laptop.org \
    --cc=g.liakhovetski@gmx.de \
    --cc=ian@mnementh.co.uk \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.