All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Ball <cjb@laptop.org>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-mmc@vger.kernel.org, linux-sh@vger.kernel.org,
	Ian Molton <ian@mnementh.co.uk>,
	Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH 3/3] mfd: sdhi: require the tmio-mmc driver to bounce unaligned buffers
Date: Wed, 5 Jan 2011 20:49:16 +0000	[thread overview]
Message-ID: <20110105204916.GF9198@void.printf.net> (raw)
In-Reply-To: <Pine.LNX.4.64.1011231723370.25676@axis700.grange>

On Tue, Nov 23, 2010 at 05:24:19PM +0100, Guennadi Liakhovetski wrote:
> The SDHI controller on SH-Mobile SoCs requires even buffer addresses, when used
> with DMA.
> 
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> ---
>  drivers/mfd/sh_mobile_sdhi.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/mfd/sh_mobile_sdhi.c b/drivers/mfd/sh_mobile_sdhi.c
> index f1714f9..3ca20ec 100644
> --- a/drivers/mfd/sh_mobile_sdhi.c
> +++ b/drivers/mfd/sh_mobile_sdhi.c
> @@ -136,6 +136,7 @@ static int __devinit sh_mobile_sdhi_probe(struct platform_device *pdev)
>  		priv->param_rx.slave_id = p->dma_slave_rx;
>  		priv->dma_priv.chan_priv_tx = &priv->param_tx;
>  		priv->dma_priv.chan_priv_rx = &priv->param_rx;
> +		priv->dma_priv.alignment_shift = 1; /* 2-byte alignment */
>  		mmc_data->dma = &priv->dma_priv;
>  	}
>  

Pushed to mmc-next for .38, thanks.

-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

WARNING: multiple messages have this Message-ID (diff)
From: Chris Ball <cjb@laptop.org>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-mmc@vger.kernel.org, linux-sh@vger.kernel.org,
	Ian Molton <ian@mnementh.co.uk>,
	Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH 3/3] mfd: sdhi: require the tmio-mmc driver to bounce
Date: Wed, 05 Jan 2011 20:49:16 +0000	[thread overview]
Message-ID: <20110105204916.GF9198@void.printf.net> (raw)
In-Reply-To: <Pine.LNX.4.64.1011231723370.25676@axis700.grange>

On Tue, Nov 23, 2010 at 05:24:19PM +0100, Guennadi Liakhovetski wrote:
> The SDHI controller on SH-Mobile SoCs requires even buffer addresses, when used
> with DMA.
> 
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> ---
>  drivers/mfd/sh_mobile_sdhi.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/mfd/sh_mobile_sdhi.c b/drivers/mfd/sh_mobile_sdhi.c
> index f1714f9..3ca20ec 100644
> --- a/drivers/mfd/sh_mobile_sdhi.c
> +++ b/drivers/mfd/sh_mobile_sdhi.c
> @@ -136,6 +136,7 @@ static int __devinit sh_mobile_sdhi_probe(struct platform_device *pdev)
>  		priv->param_rx.slave_id = p->dma_slave_rx;
>  		priv->dma_priv.chan_priv_tx = &priv->param_tx;
>  		priv->dma_priv.chan_priv_rx = &priv->param_rx;
> +		priv->dma_priv.alignment_shift = 1; /* 2-byte alignment */
>  		mmc_data->dma = &priv->dma_priv;
>  	}
>  

Pushed to mmc-next for .38, thanks.

-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

  parent reply	other threads:[~2011-01-05 20:49 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-23 16:24 [PATCH 0/3] handle unaligned buffers, when using TMIO-MMC with DMA Guennadi Liakhovetski
2010-11-23 16:24 ` Guennadi Liakhovetski
2010-11-23 16:24 ` [PATCH 1/3] mmc: tmio: merge the private header into the driver Guennadi Liakhovetski
2010-11-23 16:24   ` Guennadi Liakhovetski
2011-01-05 19:50   ` Chris Ball
2011-01-05 19:50     ` Chris Ball
2010-11-23 16:24 ` [PATCH 2/3] mmc: tmio: implement a bounce buffer for unaligned DMA Guennadi Liakhovetski
2010-11-23 16:24   ` Guennadi Liakhovetski
2010-11-26 12:04   ` Samuel Ortiz
2010-11-26 12:04     ` [PATCH 2/3] mmc: tmio: implement a bounce buffer for unaligned Samuel Ortiz
2010-12-19 21:16   ` [PATCH] mmc: tmio_mmc: silence compiler warnings Arnd Hannemann
2011-01-05 20:48     ` Chris Ball
2011-01-05 20:48       ` Chris Ball
2010-12-22 11:02   ` [PATCH 2/3 v2] mmc: tmio: implement a bounce buffer for unaligned DMA Guennadi Liakhovetski
2010-12-22 11:02     ` [PATCH 2/3 v2] mmc: tmio: implement a bounce buffer for unaligned Guennadi Liakhovetski
2010-12-24 11:11     ` [PATCH 2/3 v2] mmc: tmio: implement a bounce buffer for unaligned DMA Samuel Ortiz
2010-12-24 11:11       ` [PATCH 2/3 v2] mmc: tmio: implement a bounce buffer for Samuel Ortiz
2011-01-05 19:56   ` [PATCH 2/3] mmc: tmio: implement a bounce buffer for unaligned DMA Chris Ball
2011-01-05 19:56     ` [PATCH 2/3] mmc: tmio: implement a bounce buffer for unaligned Chris Ball
2011-01-05 20:56     ` [PATCH 2/3 v3] mmc: tmio: implement a bounce buffer for unaligned DMA Guennadi Liakhovetski
2011-01-05 20:56       ` [PATCH 2/3 v3] mmc: tmio: implement a bounce buffer for unaligned Guennadi Liakhovetski
2011-01-05 21:06       ` [PATCH 2/3 v3] mmc: tmio: implement a bounce buffer for unaligned DMA Chris Ball
2011-01-05 21:06         ` [PATCH 2/3 v3] mmc: tmio: implement a bounce buffer for Chris Ball
2010-11-23 16:24 ` [PATCH 3/3] mfd: sdhi: require the tmio-mmc driver to bounce unaligned buffers Guennadi Liakhovetski
2010-11-23 16:24   ` [PATCH 3/3] mfd: sdhi: require the tmio-mmc driver to bounce unaligned Guennadi Liakhovetski
2010-11-26 12:05   ` [PATCH 3/3] mfd: sdhi: require the tmio-mmc driver to bounce unaligned buffers Samuel Ortiz
2010-11-26 12:05     ` [PATCH 3/3] mfd: sdhi: require the tmio-mmc driver to bounce Samuel Ortiz
2011-01-05 20:49   ` Chris Ball [this message]
2011-01-05 20:49     ` Chris Ball
2010-12-14 16:07 ` [PATCH 0/3] handle unaligned buffers, when using TMIO-MMC with DMA Guennadi Liakhovetski
2010-12-14 16:07   ` [PATCH 0/3] handle unaligned buffers, when using TMIO-MMC with Guennadi Liakhovetski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110105204916.GF9198@void.printf.net \
    --to=cjb@laptop.org \
    --cc=g.liakhovetski@gmx.de \
    --cc=ian@mnementh.co.uk \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.