From: akpm@linux-foundation.org (Andrew Morton)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2] ST SPEAr: PCIE gadget suppport
Date: Thu, 6 Jan 2011 12:18:53 -0800 [thread overview]
Message-ID: <20110106121853.016fb990.akpm@linux-foundation.org> (raw)
In-Reply-To: <137dfad4a093ea0ac80396f5eb7fbf0c382be698.1294314772.git.viresh.kumar@st.com>
On Thu, 6 Jan 2011 17:29:10 +0530
Viresh Kumar <viresh.kumar@st.com> wrote:
> From: Pratyush Anand <pratyush.anand@st.com>
>
> This is a configurable gadget. can be configured by sysfs interface. Any
> IP available at PCIE bus can be programmed to be used by host
> controller.It supoorts both INTX and MSI.
> By default, gadget is configured for INTX and SYSRAM1 is mapped to BAR0
> with size 0x1000
>
> ...
>
> --- /dev/null
> +++ b/Documentation/misc-devices/spear-pcie-gadget.txt
Please recheck this documentation file - it contains a number of simple
typos.
>
> ...
>
> + if (strict_strtoul(buf, 0, &config->requested_msi))
> + return -EINVAL;
It doesn't matter much, but the code really should propagate the
strict_strtoul() return error code back to the caller, rather than
overwriting it with -EINVAL.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Viresh Kumar <viresh.kumar@st.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-pci@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
Pratyush Anand <pratyush.anand@st.com>
Subject: Re: [PATCH V2] ST SPEAr: PCIE gadget suppport
Date: Thu, 6 Jan 2011 12:18:53 -0800 [thread overview]
Message-ID: <20110106121853.016fb990.akpm@linux-foundation.org> (raw)
In-Reply-To: <137dfad4a093ea0ac80396f5eb7fbf0c382be698.1294314772.git.viresh.kumar@st.com>
On Thu, 6 Jan 2011 17:29:10 +0530
Viresh Kumar <viresh.kumar@st.com> wrote:
> From: Pratyush Anand <pratyush.anand@st.com>
>
> This is a configurable gadget. can be configured by sysfs interface. Any
> IP available at PCIE bus can be programmed to be used by host
> controller.It supoorts both INTX and MSI.
> By default, gadget is configured for INTX and SYSRAM1 is mapped to BAR0
> with size 0x1000
>
> ...
>
> --- /dev/null
> +++ b/Documentation/misc-devices/spear-pcie-gadget.txt
Please recheck this documentation file - it contains a number of simple
typos.
>
> ...
>
> + if (strict_strtoul(buf, 0, &config->requested_msi))
> + return -EINVAL;
It doesn't matter much, but the code really should propagate the
strict_strtoul() return error code back to the caller, rather than
overwriting it with -EINVAL.
next prev parent reply other threads:[~2011-01-06 20:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-06 11:59 [PATCH V2] ST SPEAr: PCIE gadget suppport Viresh Kumar
2011-01-06 11:59 ` Viresh Kumar
2011-01-06 18:48 ` Greg KH
2011-01-06 18:48 ` Greg KH
2011-01-07 8:57 ` pratyush
2011-01-07 8:57 ` pratyush
2011-01-07 18:32 ` Greg KH
2011-01-07 18:32 ` Greg KH
2011-01-06 20:18 ` Andrew Morton [this message]
2011-01-06 20:18 ` Andrew Morton
2011-01-07 8:54 ` pratyush
2011-01-07 8:54 ` pratyush
2011-01-07 22:32 ` Arnd Bergmann
2011-01-07 22:32 ` Arnd Bergmann
2011-01-10 11:20 ` pratyush
2011-01-10 11:20 ` pratyush
2011-01-18 14:51 ` Arnd Bergmann
2011-01-18 14:51 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110106121853.016fb990.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.