From: Ben Dooks <ben@trinity.fluff.org>
To: Lin Mac <mkl0301@gmail.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
cbouatmailru@gmail.com, htejun@gmail.com,
linux-arm-kernel@lists.infradead.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH v3 2/2] ahci_platform: add support for CNS3xxx SoC devices
Date: Thu, 6 Jan 2011 18:09:48 +0000 [thread overview]
Message-ID: <20110106180948.GX27131@trinity.fluff.org> (raw)
In-Reply-To: <AANLkTinO-feQkpfoZhmOV7VyPbyL=f8KV1_Qysps04ve@mail.gmail.com>
On Fri, Jan 07, 2011 at 02:04:33AM +0800, Lin Mac wrote:
> Hi Jeff,
>
> 2011/1/7 <mkl0301@gmail.com>:
> > From: Mac Lin <mkl0301@gmail.com>
> >
> > CNS3xxx override the softreset function of ahci_platform ahci_softreset by
> > cns3xxx_ahci_softreset, which would retry ahci_do_softreset again with pmp=0 if
> > pmp=15 failed, for the controller has problem receiving D2H Reg FIS of the
> > different PMP setting of the previous sent H2D Reg FIS.
> >
> > Following describe the isssue with original ahci_platform driver on
> > linux-2.6.37-rc3, arm/cns3xxx.
> >
> > If CONFIG_SATA_PMP is enabled, while not using multiplier and connect the disks
> > directly to the board, the disk cannot be found due to software reset always
> complicated if more SoC-specific code added.
> I really prefer the original way.
Is there a reference to the original?
--
Ben Dooks, ben@fluff.org, http://www.fluff.org/ben/
Large Hadron Colada: A large Pina Colada that makes the universe disappear.
WARNING: multiple messages have this Message-ID (diff)
From: ben@trinity.fluff.org (Ben Dooks)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/2] ahci_platform: add support for CNS3xxx SoC devices
Date: Thu, 6 Jan 2011 18:09:48 +0000 [thread overview]
Message-ID: <20110106180948.GX27131@trinity.fluff.org> (raw)
In-Reply-To: <AANLkTinO-feQkpfoZhmOV7VyPbyL=f8KV1_Qysps04ve@mail.gmail.com>
On Fri, Jan 07, 2011 at 02:04:33AM +0800, Lin Mac wrote:
> Hi Jeff,
>
> 2011/1/7 <mkl0301@gmail.com>:
> > From: Mac Lin <mkl0301@gmail.com>
> >
> > CNS3xxx override the softreset function of ahci_platform ahci_softreset by
> > cns3xxx_ahci_softreset, which would retry ahci_do_softreset again with pmp=0 if
> > pmp=15 failed, for the controller has problem receiving D2H Reg FIS of the
> > different PMP setting of the previous sent H2D Reg FIS.
> >
> > Following describe the isssue with original ahci_platform driver on
> > linux-2.6.37-rc3, arm/cns3xxx.
> >
> > If CONFIG_SATA_PMP is enabled, while not using multiplier and connect the disks
> > directly to the board, the disk cannot be found due to software reset always
> complicated if more SoC-specific code added.
> I really prefer the original way.
Is there a reference to the original?
--
Ben Dooks, ben at fluff.org, http://www.fluff.org/ben/
Large Hadron Colada: A large Pina Colada that makes the universe disappear.
next prev parent reply other threads:[~2011-01-06 18:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-06 17:53 [PATCH v3 0/2] add CNS3xxx AHCI support mkl0301
2011-01-06 17:53 ` mkl0301 at gmail.com
2011-01-06 17:53 ` [PATCH v3 1/2] ahci_platform: switch to module device table matching mkl0301
2011-01-06 17:53 ` mkl0301 at gmail.com
2011-01-06 17:53 ` [PATCH v3 2/2] ahci_platform: add support for CNS3xxx SoC devices mkl0301
2011-01-06 17:53 ` mkl0301 at gmail.com
2011-01-06 18:04 ` Lin Mac
2011-01-06 18:04 ` Lin Mac
2011-01-06 18:09 ` Ben Dooks [this message]
2011-01-06 18:09 ` Ben Dooks
2011-01-06 18:14 ` Lin Mac
2011-01-06 18:14 ` Lin Mac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110106180948.GX27131@trinity.fluff.org \
--to=ben@trinity.fluff.org \
--cc=cbouatmailru@gmail.com \
--cc=htejun@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=mkl0301@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.