From: Tony Lindgren <tony@atomide.com>
To: Kevin Hilman <khilman@ti.com>
Cc: Nishanth Menon <nm@ti.com>, l-o <linux-omap@vger.kernel.org>,
l-a <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 5/5] omap2+: pm_bus: make functions used as pointers as static
Date: Thu, 6 Jan 2011 14:43:26 -0800 [thread overview]
Message-ID: <20110106224326.GC7771@atomide.com> (raw)
In-Reply-To: <87zkrg2nfa.fsf@ti.com>
* Kevin Hilman <khilman@ti.com> [110104 16:39]:
> Nishanth Menon <nm@ti.com> writes:
>
> > omap_pm_runtime_suspend and omap_pm_runtime_resume are used
> > as function pointers and does not really need to be exposed
> > to the world.
> >
> > Fixes sparse warnings:
> > arch/arm/mach-omap2/pm_bus.c:23:5: warning: symbol 'omap_pm_runtime_suspend' was not declared. Should it be static?
> > arch/arm/mach-omap2/pm_bus.c:40:5: warning: symbol 'omap_pm_runtime_resume' was not declared. Should it be static?
> >
> > Signed-off-by: Nishanth Menon <nm@ti.com>
>
> Thanks, will queue this one in my pm-fixes branch for 2.6.38-rc.
I'll take patches 1 - 4.
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/5] omap2+: pm_bus: make functions used as pointers as static
Date: Thu, 6 Jan 2011 14:43:26 -0800 [thread overview]
Message-ID: <20110106224326.GC7771@atomide.com> (raw)
In-Reply-To: <87zkrg2nfa.fsf@ti.com>
* Kevin Hilman <khilman@ti.com> [110104 16:39]:
> Nishanth Menon <nm@ti.com> writes:
>
> > omap_pm_runtime_suspend and omap_pm_runtime_resume are used
> > as function pointers and does not really need to be exposed
> > to the world.
> >
> > Fixes sparse warnings:
> > arch/arm/mach-omap2/pm_bus.c:23:5: warning: symbol 'omap_pm_runtime_suspend' was not declared. Should it be static?
> > arch/arm/mach-omap2/pm_bus.c:40:5: warning: symbol 'omap_pm_runtime_resume' was not declared. Should it be static?
> >
> > Signed-off-by: Nishanth Menon <nm@ti.com>
>
> Thanks, will queue this one in my pm-fixes branch for 2.6.38-rc.
I'll take patches 1 - 4.
Tony
next prev parent reply other threads:[~2011-01-06 22:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 20:07 [PATCH 0/5] OMAP2+: trivial sparse fixes Nishanth Menon
2011-01-04 20:07 ` Nishanth Menon
2011-01-04 20:07 ` [PATCH 1/5] omap3|4: mux: make local structures static Nishanth Menon
2011-01-04 20:07 ` Nishanth Menon
2011-01-04 20:07 ` [PATCH 2/5] omap3: zoom: use static for pointer passing Nishanth Menon
2011-01-04 20:07 ` Nishanth Menon
2011-01-04 20:07 ` [PATCH 3/5] omap3: igep3: make igep3_flash_init static Nishanth Menon
2011-01-04 20:07 ` Nishanth Menon
2011-01-04 20:07 ` [PATCH 4/5] omap2+: wdt: trivial sparse fixes Nishanth Menon
2011-01-04 20:07 ` Nishanth Menon
2011-01-04 20:07 ` [PATCH 5/5] omap2+: pm_bus: make functions used as pointers as static Nishanth Menon
2011-01-04 20:07 ` Nishanth Menon
2011-01-05 0:40 ` Kevin Hilman
2011-01-05 0:40 ` Kevin Hilman
2011-01-06 22:43 ` Tony Lindgren [this message]
2011-01-06 22:43 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110106224326.GC7771@atomide.com \
--to=tony@atomide.com \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.