From: Paul Mundt <lethal@linux-sh.org>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-sh@vger.kernel.org, Magnus Damm <damm@opensource.se>,
Dan Williams <dan.j.williams@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dma: shdma: don't register the global die notifier multiple times
Date: Fri, 07 Jan 2011 01:59:18 +0000 [thread overview]
Message-ID: <20110107015918.GI22477@linux-sh.org> (raw)
In-Reply-To: <Pine.LNX.4.64.1101061759460.1248@axis700.grange>
On Thu, Jan 06, 2011 at 06:04:50PM +0100, Guennadi Liakhovetski wrote:
> A recent patch has added a die notifier to the shdma driver, however,
> it registers a static die-notifier object in the probe routine, i.e.,
> for each device instance. This is wrong and leads to a system lockup.
> This patch moves the die notifier registration to module init and
> exit routines respectively.
>
> Reported-by: Magnus Damm <damm@opensource.se>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> ---
>
> This fixes the lock up on sh7372. Patch against current sh-2.6/master.
>
Whoops, I suppose I should have tested on a platform with more than one
DMAC :-)
I'll piggyback this on top of the rmobile-latest branch, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Paul Mundt <lethal@linux-sh.org>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-sh@vger.kernel.org, Magnus Damm <damm@opensource.se>,
Dan Williams <dan.j.williams@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dma: shdma: don't register the global die notifier multiple times
Date: Fri, 7 Jan 2011 10:59:18 +0900 [thread overview]
Message-ID: <20110107015918.GI22477@linux-sh.org> (raw)
In-Reply-To: <Pine.LNX.4.64.1101061759460.1248@axis700.grange>
On Thu, Jan 06, 2011 at 06:04:50PM +0100, Guennadi Liakhovetski wrote:
> A recent patch has added a die notifier to the shdma driver, however,
> it registers a static die-notifier object in the probe routine, i.e.,
> for each device instance. This is wrong and leads to a system lockup.
> This patch moves the die notifier registration to module init and
> exit routines respectively.
>
> Reported-by: Magnus Damm <damm@opensource.se>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> ---
>
> This fixes the lock up on sh7372. Patch against current sh-2.6/master.
>
Whoops, I suppose I should have tested on a platform with more than one
DMAC :-)
I'll piggyback this on top of the rmobile-latest branch, thanks.
next prev parent reply other threads:[~2011-01-07 1:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-06 17:04 [PATCH] dma: shdma: don't register the global die notifier multiple Guennadi Liakhovetski
2011-01-06 17:04 ` [PATCH] dma: shdma: don't register the global die notifier multiple times Guennadi Liakhovetski
2011-01-07 1:59 ` Paul Mundt [this message]
2011-01-07 1:59 ` Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110107015918.GI22477@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=damm@opensource.se \
--cc=dan.j.williams@intel.com \
--cc=g.liakhovetski@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.