diff for duplicates of <20110107060558.GE1717@bicker> diff --git a/a/1.txt b/N1/1.txt index 1d217c1..f1ba7b9 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,7 +1,7 @@ On Fri, Jan 07, 2011 at 07:30:54AM +0200, Alexey Dobriyan wrote: > On Fri, Jan 07, 2011 at 08:12:27AM +0300, Dan Carpenter wrote: -> > - if (strncmp(usercmd, "MDIS", 3) = 0) { -> > + if (strncmp(usercmd, "MDIS", 4) = 0) { +> > - if (strncmp(usercmd, "MDIS", 3) == 0) { +> > + if (strncmp(usercmd, "MDIS", 4) == 0) { > > How about you NUL-terminate, and use strcmp(). diff --git a/a/content_digest b/N1/content_digest index 2a22443..7f69513 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,8 +1,8 @@ "ref\020110107051227.GD1717@bicker\0" "ref\020110107053054.GA9057@p183.telecom.by\0" "From\0Dan Carpenter <error27@gmail.com>\0" - "Subject\0Re: [patch] vga_switcheroo: comparing too few characters in\0" - "Date\0Fri, 07 Jan 2011 06:05:58 +0000\0" + "Subject\0Re: [patch] vga_switcheroo: comparing too few characters in strncmp()\0" + "Date\0Fri, 7 Jan 2011 09:05:58 +0300\0" "To\0Alexey Dobriyan <adobriyan@gmail.com>\0" "Cc\0Dave Airlie <airlied@redhat.com>" Jiri Slaby <jslaby@suse.cz> @@ -12,8 +12,8 @@ "b\0" "On Fri, Jan 07, 2011 at 07:30:54AM +0200, Alexey Dobriyan wrote:\n" "> On Fri, Jan 07, 2011 at 08:12:27AM +0300, Dan Carpenter wrote:\n" - "> > -\tif (strncmp(usercmd, \"MDIS\", 3) = 0) {\n" - "> > +\tif (strncmp(usercmd, \"MDIS\", 4) = 0) {\n" + "> > -\tif (strncmp(usercmd, \"MDIS\", 3) == 0) {\n" + "> > +\tif (strncmp(usercmd, \"MDIS\", 4) == 0) {\n" "> \n" "> How about you NUL-terminate, and use strcmp().\n" "\n" @@ -22,4 +22,4 @@ "regards,\n" dan carpenter -e8062f2091a96e41389d3ed25d524e81bb7a1861d682a0973e27dff93d1322c6 +1ea395b0def7869560a450bc2d2e10d78cdbd032166a93e16865679edbc9fb05
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.