From: Dan Carpenter <error27@gmail.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Dave Airlie <airlied@redhat.com>, Jiri Slaby <jslaby@suse.cz>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] vga_switcheroo: comparing too few characters in
Date: Fri, 07 Jan 2011 06:05:58 +0000 [thread overview]
Message-ID: <20110107060558.GE1717@bicker> (raw)
In-Reply-To: <20110107053054.GA9057@p183.telecom.by>
On Fri, Jan 07, 2011 at 07:30:54AM +0200, Alexey Dobriyan wrote:
> On Fri, Jan 07, 2011 at 08:12:27AM +0300, Dan Carpenter wrote:
> > - if (strncmp(usercmd, "MDIS", 3) = 0) {
> > + if (strncmp(usercmd, "MDIS", 4) = 0) {
>
> How about you NUL-terminate, and use strcmp().
I assume there is a reason for this userspace API. Dave?
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Dave Airlie <airlied@redhat.com>, Jiri Slaby <jslaby@suse.cz>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] vga_switcheroo: comparing too few characters in strncmp()
Date: Fri, 7 Jan 2011 09:05:58 +0300 [thread overview]
Message-ID: <20110107060558.GE1717@bicker> (raw)
In-Reply-To: <20110107053054.GA9057@p183.telecom.by>
On Fri, Jan 07, 2011 at 07:30:54AM +0200, Alexey Dobriyan wrote:
> On Fri, Jan 07, 2011 at 08:12:27AM +0300, Dan Carpenter wrote:
> > - if (strncmp(usercmd, "MDIS", 3) == 0) {
> > + if (strncmp(usercmd, "MDIS", 4) == 0) {
>
> How about you NUL-terminate, and use strcmp().
I assume there is a reason for this userspace API. Dave?
regards,
dan carpenter
next prev parent reply other threads:[~2011-01-07 6:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-07 5:12 [patch] vga_switcheroo: comparing too few characters in strncmp() Dan Carpenter
2011-01-07 5:12 ` Dan Carpenter
2011-01-07 5:30 ` [patch] vga_switcheroo: comparing too few characters in Alexey Dobriyan
2011-01-07 5:30 ` [patch] vga_switcheroo: comparing too few characters in strncmp() Alexey Dobriyan
2011-01-07 6:05 ` Dan Carpenter [this message]
2011-01-07 6:05 ` Dan Carpenter
2011-01-07 6:07 ` Mailing Lists
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110107060558.GE1717@bicker \
--to=error27@gmail.com \
--cc=adobriyan@gmail.com \
--cc=airlied@redhat.com \
--cc=jslaby@suse.cz \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.