[PATCH 00/12] Nested Virtualization: Overview

[PATCH 00/12] Nested Virtualization: Overview

[Christoph Egger]

Hi!

This patch series brings Nested Virtualization to Xen.
This is the seventh patch series. Improvements to the
previous patch submission:

- Worked on all items from Tim
- Dropped vram patch
- Rebased against c/s 22573:ff1b80ccecd9

The patch series:

patch 01: add nestedhvm guest config option to the tools.
                  This is the only one patch touching the tools
patch 02: Add data structures for nested virtualization.
patch 03: add nestedhvm function hooks.
patch 04: The heart of nested virtualization.
patch 05: Allow switch to paged real mode during vmrun emulation.
                  Emulate cr0 and cr4 when guest does not intercept them
                  (i.e. Hyper-V/Windows7, KVM)
patch 06: When injecting an exception into nested guest, inject
                  #VMEXIT into the guest if intercepted.
patch 07: Allow guest to enable SVM in EFER only on AMD.
patch 08: Handle interrupts (generic part).
patch 09: SVM specific implementation for nested virtualization.
patch 10: Handle interrupts (SVM specific).
patch 11: The piece of code that effectively turns on nested virtualization.
patch 12: Handle nested pagefault to enable hap-on-hap and handle
                  nested guest page-table-walks to emulate instructions
                  the guest does not intercept (i.e. WBINVD with Windows 7).


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

Re: [PATCH 00/12] Nested Virtualization: Overview

[Tim Deegan]

Hi, 

At 16:02 +0000 on 20 Dec (1292860962), Christoph Egger wrote:
> This patch series brings Nested Virtualization to Xen.
> This is the seventh patch series.

Thanks for this.  I've commented on patch 4 (core) and patch 12
(hap-on-hap) separately.  Also I think we need an Acked-by: from Eddie
for patches 1-8. 

Apart from that I think we can check these in as soon as the 4.1
branch has been taken, and fix up any remaining issues in-tree.

Cheers,

Tim.

-- 
Tim Deegan <Tim.Deegan@citrix.com>
Principal Software Engineer, Xen Platform Team
Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)

Re: [PATCH 00/12] Nested Virtualization: Overview

[Christoph Egger]

On Friday 07 January 2011 17:01:12 Tim Deegan wrote:
> Hi,
>
> At 16:02 +0000 on 20 Dec (1292860962), Christoph Egger wrote:
> > This patch series brings Nested Virtualization to Xen.
> > This is the seventh patch series.
>
> Thanks for this.  I've commented on patch 4 (core) and patch 12
> (hap-on-hap) separately.  Also I think we need an Acked-by: from Eddie
> for patches 1-8.
>
> Apart from that I think we can check these in as soon as the 4.1
> branch has been taken, and fix up any remaining issues in-tree.

When is the 4.1 branch planned to happen?

Christoph


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

Re: [PATCH 00/12] Nested Virtualization: Overview

[Keir Fraser]

On 07/01/2011 16:34, "Christoph Egger" <Christoph.Egger@amd.com> wrote:

>> Thanks for this.  I've commented on patch 4 (core) and patch 12
>> (hap-on-hap) separately.  Also I think we need an Acked-by: from Eddie
>> for patches 1-8.
>> 
>> Apart from that I think we can check these in as soon as the 4.1
>> branch has been taken, and fix up any remaining issues in-tree.
> 
> When is the 4.1 branch planned to happen?

We usually do the branch just before release. So that would be about 6 weeks
I guess.

 -- Keir

Re: [PATCH 00/12] Nested Virtualization: Overview

[Christoph Egger]

On Friday 07 January 2011 17:45:12 Keir Fraser wrote:
> On 07/01/2011 16:34, "Christoph Egger" <Christoph.Egger@amd.com> wrote:
> >> Thanks for this.  I've commented on patch 4 (core) and patch 12
> >> (hap-on-hap) separately.  Also I think we need an Acked-by: from Eddie
> >> for patches 1-8.
> >>
> >> Apart from that I think we can check these in as soon as the 4.1
> >> branch has been taken, and fix up any remaining issues in-tree.
> >
> > When is the 4.1 branch planned to happen?
>
> We usually do the branch just before release. So that would be about 6
> weeks I guess.

I am surprised about that. Did I miss the feature freeze announcement?

Christoph


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

Re: [PATCH 00/12] Nested Virtualization: Overview

[Keir Fraser]

On 07/01/2011 17:05, "Christoph Egger" <Christoph.Egger@amd.com> wrote:

> On Friday 07 January 2011 17:45:12 Keir Fraser wrote:
>> On 07/01/2011 16:34, "Christoph Egger" <Christoph.Egger@amd.com> wrote:
>>>> Thanks for this.  I've commented on patch 4 (core) and patch 12
>>>> (hap-on-hap) separately.  Also I think we need an Acked-by: from Eddie
>>>> for patches 1-8.
>>>> 
>>>> Apart from that I think we can check these in as soon as the 4.1
>>>> branch has been taken, and fix up any remaining issues in-tree.
>>> 
>>> When is the 4.1 branch planned to happen?
>> 
>> We usually do the branch just before release. So that would be about 6
>> weeks I guess.
> 
> I am surprised about that. Did I miss the feature freeze announcement?

Proposed it back in November:
http://lists.xensource.com/archives/html/xen-devel/2010-11/msg01349.html

 -- Keir

> Christoph
> 

[PATCH 00/12] Nested Virtualization: Overview

[Christoph Egger]

Hi!

This patch series brings Nested Virtualization to Xen.
This is the eight patch series. Improvements to the
previous patch submission:

- Worked on all items from Tim
- Rebased against c/s 22956:8af88ff698ff
- Several bugfixes
- SVM specific performance improvements:
   - Implemented shadow vmcb
   - Implemented vmcb cleanbit emulation

The patch series:

patch 01: add nestedhvm guest config option to the tools.
                  This is the only one patch touching the tools
patch 02: Add data structures for nested virtualization.
patch 03: add nestedhvm function hooks.
patch 04: The heart of nested virtualization.
patch 05: Allow switch to paged real mode during vmrun emulation.
                  Emulate cr0 and cr4 when guest does not intercept them
                  (i.e. Hyper-V/Windows7, KVM)
patch 06: When injecting an exception into nested guest, inject
                  #VMEXIT into the guest if intercepted.
patch 07: Allow guest to enable SVM in EFER only on AMD.
patch 08: Handle interrupts (generic part).
patch 09: SVM specific implementation for nested virtualization.
patch 10: Handle interrupts (SVM specific).
patch 11: The piece of code that effectively turns on nested virtualization.
patch 12: Handle nested pagefault to enable hap-on-hap and handle
                  nested guest page-table-walks to emulate instructions
                  the guest does not intercept (i.e. WBINVD with Windows 7).

-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

Re: [PATCH 00/12] Nested Virtualization: Overview

[Tim Deegan]

Hi, 

At 14:28 +0000 on 09 Mar (1299680895), Christoph Egger wrote:
> This patch series brings Nested Virtualization to Xen.

Patches 1-11: Acked-by: Tim Deegan <Tim.Deegan@citrix.com>
Patches 1-8 also need an explicit Ack from Eddie Dong.  
Patch 12 I'll send comments on separately.

Cheers,

Tim.

-- 
Tim Deegan <Tim.Deegan@citrix.com>
Principal Software Engineer, Xen Platform Team
Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)

RE: [PATCH 00/12] Nested Virtualization: Overview

[Dong, Eddie]

Good progress! Though in very details, there is maybe minor difference, but I vote we start to take the patches so that the next rebase and review can be easier :)
Even we can fix later on for those minor issue like other patches did in the past.

Eddie

-----Original Message-----
From: xen-devel-bounces@lists.xensource.com [mailto:xen-devel-bounces@lists.xensource.com] On Behalf Of Christoph Egger
Sent: Wednesday, March 09, 2011 10:28 PM
To: xen-devel@lists.xensource.com
Subject: [Xen-devel] [PATCH 00/12] Nested Virtualization: Overview

Hi!

This patch series brings Nested Virtualization to Xen.
This is the eight patch series. Improvements to the
previous patch submission:

- Worked on all items from Tim
- Rebased against c/s 22956:8af88ff698ff
- Several bugfixes
- SVM specific performance improvements:
   - Implemented shadow vmcb
   - Implemented vmcb cleanbit emulation

The patch series:

patch 01: add nestedhvm guest config option to the tools.
                  This is the only one patch touching the tools
patch 02: Add data structures for nested virtualization.
patch 03: add nestedhvm function hooks.
patch 04: The heart of nested virtualization.
patch 05: Allow switch to paged real mode during vmrun emulation.
                  Emulate cr0 and cr4 when guest does not intercept them
                  (i.e. Hyper-V/Windows7, KVM)
patch 06: When injecting an exception into nested guest, inject
                  #VMEXIT into the guest if intercepted.
patch 07: Allow guest to enable SVM in EFER only on AMD.
patch 08: Handle interrupts (generic part).
patch 09: SVM specific implementation for nested virtualization.
patch 10: Handle interrupts (SVM specific).
patch 11: The piece of code that effectively turns on nested virtualization.
patch 12: Handle nested pagefault to enable hap-on-hap and handle
                  nested guest page-table-walks to emulate instructions
                  the guest does not intercept (i.e. WBINVD with Windows 7).

-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel