From: Johannes Weiner <hannes@cmpxchg.org>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH 3/7] tlbfs: Change remove_from_page_cache
Date: Sat, 8 Jan 2011 23:25:25 +0100 [thread overview]
Message-ID: <20110108222302.GD23189@cmpxchg.org> (raw)
In-Reply-To: <8fb992356ab4f24f0bcb47b8a59b298508e48745.1293031046.git.minchan.kim@gmail.com>
On Thu, Dec 23, 2010 at 12:32:45AM +0900, Minchan Kim wrote:
> This patch series changes remove_from_page_cache's page ref counting
> rule. Page cache ref count is decreased in delete_from_page_cache.
> So we don't need decreasing page reference by caller.
>
> Cc: William Irwin <wli@holomorphy.com>
> Signed-off-by: Minchan Kim <minchan.kim@gmail.com>
> Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
As Mel pointed out, that should be hugetlbfs in the subject.
Otherwise, the patch looks good.
Reviewed-by: Johannes Weiner <hannes@cmpxchg.org>
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH 3/7] tlbfs: Change remove_from_page_cache
Date: Sat, 8 Jan 2011 23:25:25 +0100 [thread overview]
Message-ID: <20110108222302.GD23189@cmpxchg.org> (raw)
In-Reply-To: <8fb992356ab4f24f0bcb47b8a59b298508e48745.1293031046.git.minchan.kim@gmail.com>
On Thu, Dec 23, 2010 at 12:32:45AM +0900, Minchan Kim wrote:
> This patch series changes remove_from_page_cache's page ref counting
> rule. Page cache ref count is decreased in delete_from_page_cache.
> So we don't need decreasing page reference by caller.
>
> Cc: William Irwin <wli@holomorphy.com>
> Signed-off-by: Minchan Kim <minchan.kim@gmail.com>
> Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
As Mel pointed out, that should be hugetlbfs in the subject.
Otherwise, the patch looks good.
Reviewed-by: Johannes Weiner <hannes@cmpxchg.org>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-01-08 22:25 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-22 15:32 [PATCH 0/7] Change page reference handling semantic of page cache Minchan Kim
2010-12-22 15:32 ` Minchan Kim
2010-12-22 15:32 ` [PATCH 1/7] Introduce delete_from_page_cache Minchan Kim
2010-12-22 15:32 ` Minchan Kim
2010-12-22 15:32 ` [PATCH 2/7] fuse: Change remove_from_page_cache Minchan Kim
2010-12-22 15:32 ` Minchan Kim
2011-01-08 22:22 ` Johannes Weiner
2011-01-08 22:22 ` Johannes Weiner
2010-12-22 15:32 ` [PATCH 3/7] tlbfs: " Minchan Kim
2010-12-22 15:32 ` Minchan Kim
2011-01-08 22:25 ` Johannes Weiner [this message]
2011-01-08 22:25 ` Johannes Weiner
2010-12-22 15:32 ` [PATCH 4/7] swap: " Minchan Kim
2010-12-22 15:32 ` Minchan Kim
2011-01-08 22:28 ` Johannes Weiner
2011-01-08 22:28 ` Johannes Weiner
2011-01-10 15:45 ` Minchan Kim
2011-01-10 15:45 ` Minchan Kim
2010-12-22 15:32 ` [PATCH 5/7] truncate: " Minchan Kim
2010-12-22 15:32 ` Minchan Kim
2011-01-08 22:33 ` Johannes Weiner
2011-01-08 22:33 ` Johannes Weiner
2010-12-22 15:32 ` [PATCH 6/7] Good bye remove_from_page_cache Minchan Kim
2010-12-22 15:32 ` Minchan Kim
2011-01-08 22:35 ` Johannes Weiner
2011-01-08 22:35 ` Johannes Weiner
2010-12-22 15:32 ` [PATCH 7/7] Change __remove_from_page_cache Minchan Kim
2010-12-22 15:32 ` Minchan Kim
2011-01-08 22:36 ` Johannes Weiner
2011-01-08 22:36 ` Johannes Weiner
2010-12-30 3:17 ` [PATCH 0/7] Change page reference handling semantic of page cache Hugh Dickins
2010-12-30 3:17 ` Hugh Dickins
2011-01-06 10:31 ` Mel Gorman
2011-01-06 10:31 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110108222302.GD23189@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.