Re: [PATCH] configfs: change depends -> select SYSFS

[Joel Becker <jlbec@evilplan.org>]

On Mon, Jan 10, 2011 at 11:45:08AM -0800, Nicholas A. Bellinger wrote:
> This patch changes configfs to select SYSFS to fix the following:
> 
> warning: (TARGET_CORE && GFS2_FS) selects CONFIGFS_FS which has unmet direct dependencies (SYSFS)

	If others are selecting CONFIGFS_FS, I'm thinking that this must
go in.  So

Acked-by: Joel Becker <jlbec@evilplan.org>

> 
> This patch also fixes whitespace breakage in the 'help' section.
> 
> Reported-by: Randy Dunlap <randy.dunlap@oracle.com>
> Signed-off-by: Nicholas A. Bellinger <nab@linux-iscsi.org>
> ---
>  fs/configfs/Kconfig |   14 +++++++-------
>  1 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/fs/configfs/Kconfig b/fs/configfs/Kconfig
> index 13587cc..0e4bd23 100644
> --- a/fs/configfs/Kconfig
> +++ b/fs/configfs/Kconfig
> @@ -1,11 +1,11 @@
>  config CONFIGFS_FS
>  	tristate "Userspace-driven configuration filesystem"
> -	depends on SYSFS
> +	select SYSFS
>  	help
> -	  configfs is a ram-based filesystem that provides the converse
> -	  of sysfs's functionality. Where sysfs is a filesystem-based
> -	  view of kernel objects, configfs is a filesystem-based manager
> -	  of kernel objects, or config_items.
> +	configfs is a RAM-based filesystem that provides the converse
> +	of sysfs's functionality. Where sysfs is a filesystem-based
> +	view of kernel objects, configfs is a filesystem-based manager
> +	of kernel objects, or config_items.
>  
> -	  Both sysfs and configfs can and should exist together on the
> -	  same system. One is not a replacement for the other.
> +	Both sysfs and configfs can and should exist together on the
> +	same system. One is not a replacement for the other.
> -- 
> 1.7.3.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 

Life's Little Instruction Book #451

	"Don't be afraid to say, 'I'm sorry.'"

			http://www.jlbec.org/
			jlbec@evilplan.org