From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Timur Tabi <timur@freescale.com>
Cc: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>,
alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] ASoC: soc-core: Add support for NULL default register caches
Date: Mon, 10 Jan 2011 23:48:25 +0000 [thread overview]
Message-ID: <20110110234824.GA5399@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4D2B8AC0.2010001@freescale.com>
On Mon, Jan 10, 2011 at 04:40:00PM -0600, Timur Tabi wrote:
> The CS4270 registers are numbered from 1 through 8, so codec_reg should look
> like this:
> 1: c3
> 2: 0
> 3: 30
> 4: 0
> 5: 0
> 6: 0
> 7: 0
> 8: 0
> What I don't know is why the bad output, but it's probably because the register
> cache code broke during the various changes applied to it since multi-component
> was introduced. Originally, the driver handled the register cache completely
> internally. Then, as register caching was added to ASoC itself, the driver was
> modified to use it. I believe that those modifications were not really tested.
The issue is that you were using 1 based array indexing and the core
uses zero based indexing - nothing dramatically wrong and it should've
fallen through to using the hardware I/O when it went beyond the cache
so I'd expect things to work fine. The read failure for register zero
was handled gracefully, so it looks like everything did what I'd expect
here.
next prev parent reply other threads:[~2011-01-10 23:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-10 10:10 [PATCH] ASoC: soc-core: Add support for NULL default register caches Dimitris Papastamos
2011-01-10 21:48 ` Liam Girdwood
2011-01-10 22:10 ` Timur Tabi
2011-01-10 22:29 ` Mark Brown
2011-01-10 22:40 ` Timur Tabi
2011-01-10 23:48 ` Mark Brown [this message]
2011-01-10 22:25 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110110234824.GA5399@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=dp@opensource.wolfsonmicro.com \
--cc=lrg@slimlogic.co.uk \
--cc=patches@opensource.wolfsonmicro.com \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.