From: Olaf Hering <olaf@aepfle.de>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Christoph Egger <Christoph.Egger@amd.com>, xen-devel@lists.xensource.com
Subject: Re: [PATCH] libxc: build fixes
Date: Tue, 11 Jan 2011 11:41:32 +0100 [thread overview]
Message-ID: <20110111104132.GA2982@aepfle.de> (raw)
In-Reply-To: <19749.64362.58747.605990@mariner.uk.xensource.com>
On Thu, Jan 06, Ian Jackson wrote:
> Christoph Egger writes ("[Xen-devel] [PATCH] libxc: build fixes"):
> > Attached patch makes libxc build again on NetBSD after the recent rework.
>
> I have applied this. However:
>
> I changed the name of the new make variable from LIBDL to DLOPEN_LIBS.
> The latter conforms to the naming scheme for similar variables found
> in config/*.mk - PTHREAD_LIBS et al.
>
> Also I moved the setting of the variable to -dl from Linux to StdGNU
> (which makes it apply more widely) and also added it to SunOS.mk
> (based on pure guesswork).
This is incomplete. flask does not build because linking fails with
missing dlopen/dlsym etc. This change fixes it for me.
Signed-off-by: Olaf Hering <olaf@aepfle.de>
--- xen-unstable.hg-4.1.22697.orig/tools/Rules.mk
+++ xen-unstable.hg-4.1.22697/tools/Rules.mk
@@ -18,7 +18,7 @@ XEN_BLKTAP2 = $(XEN_ROOT)/tools/b
CFLAGS_include = -I$(XEN_INCLUDE)
CFLAGS_libxenctrl = -I$(XEN_LIBXC) $(CFLAGS_include)
-LDLIBS_libxenctrl = -L$(XEN_LIBXC) -lxenctrl
+LDLIBS_libxenctrl = -L$(XEN_LIBXC) -lxenctrl $(DLOPEN_LIBS)
CFLAGS_libxenguest = -I$(XEN_LIBXC) $(CFLAGS_include)
LDLIBS_libxenguest = -L$(XEN_LIBXC) -lxenguest
next prev parent reply other threads:[~2011-01-11 10:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-06 15:46 [PATCH] libxc: build fixes Christoph Egger
2011-01-06 17:27 ` Ian Jackson
2011-01-11 10:41 ` Olaf Hering [this message]
2011-01-11 12:46 ` Ian Campbell
2011-01-11 18:46 ` Ian Jackson
2011-01-06 17:42 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110111104132.GA2982@aepfle.de \
--to=olaf@aepfle.de \
--cc=Christoph.Egger@amd.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.