From: "Américo Wang" <xiyou.wangcong@gmail.com>
To: Dave Anderson <anderson@redhat.com>
Cc: linux-kernel@vger.kernel.org, fweisbec@gmail.com
Subject: Re: [PATCH] /proc/kcore: fix seeking
Date: Wed, 12 Jan 2011 00:04:37 +0800 [thread overview]
Message-ID: <20110111160437.GF17312@hack> (raw)
In-Reply-To: <4D2B1AD5.9000707@redhat.com>
On Mon, Jan 10, 2011 at 09:42:29AM -0500, Dave Anderson wrote:
>From: Dave Anderson <anderson@redhat.com>
>
>Commit 34aacb2920667d405a8df15968b7f71ba46c8f18
>("procfs: Use generic_file_llseek in /proc/kcore")
>broke seeking on /proc/kcore. This changes it back
>to use default_llseek in order to restore the original
>behavior.
>
>The problem with generic_file_llseek is that it only
>allows seeks up to inode->i_sb->s_maxbytes, which is
>2GB-1 on procfs, where the memory file offset values in
>the /proc/kcore PT_LOAD segments may exceed or start
>beyond that offset value.
>
Is the race solved? Using default_llseek() still races
with read_kcore() on fpos, AFAIK.
--
Live like a child, think like the god.
next prev parent reply other threads:[~2011-01-11 16:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-10 14:42 [PATCH] /proc/kcore: fix seeking Dave Anderson
2011-01-11 0:52 ` Frederic Weisbecker
2011-01-11 16:04 ` Américo Wang [this message]
2011-01-11 16:23 ` Frederic Weisbecker
2011-01-14 9:44 ` Américo Wang
2011-01-14 16:29 ` Frederic Weisbecker
2011-01-17 8:06 ` Américo Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110111160437.GF17312@hack \
--to=xiyou.wangcong@gmail.com \
--cc=anderson@redhat.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.