From: Dave Anderson <anderson@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: fweisbec@gmail.com
Subject: [PATCH] /proc/kcore: fix seeking
Date: Mon, 10 Jan 2011 09:42:29 -0500 [thread overview]
Message-ID: <4D2B1AD5.9000707@redhat.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 646 bytes --]
From: Dave Anderson <anderson@redhat.com>
Commit 34aacb2920667d405a8df15968b7f71ba46c8f18
("procfs: Use generic_file_llseek in /proc/kcore")
broke seeking on /proc/kcore. This changes it back
to use default_llseek in order to restore the original
behavior.
The problem with generic_file_llseek is that it only
allows seeks up to inode->i_sb->s_maxbytes, which is
2GB-1 on procfs, where the memory file offset values in
the /proc/kcore PT_LOAD segments may exceed or start
beyond that offset value.
A similar revert was made for /proc/vmcore.
Signed-off-by: Dave Anderson <anderson@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
--
[-- Attachment #2: kcore.patch --]
[-- Type: text/x-patch, Size: 340 bytes --]
--- linux-2.6.37/fs/proc/kcore.c.orig
+++ linux-2.6.37/fs/proc/kcore.c
@@ -558,7 +558,7 @@ static int open_kcore(struct inode *inod
static const struct file_operations proc_kcore_operations = {
.read = read_kcore,
.open = open_kcore,
- .llseek = generic_file_llseek,
+ .llseek = default_llseek,
};
#ifdef CONFIG_MEMORY_HOTPLUG
next reply other threads:[~2011-01-10 14:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-10 14:42 Dave Anderson [this message]
2011-01-11 0:52 ` [PATCH] /proc/kcore: fix seeking Frederic Weisbecker
2011-01-11 16:04 ` Américo Wang
2011-01-11 16:23 ` Frederic Weisbecker
2011-01-14 9:44 ` Américo Wang
2011-01-14 16:29 ` Frederic Weisbecker
2011-01-17 8:06 ` Américo Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2B1AD5.9000707@redhat.com \
--to=anderson@redhat.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.