* global_send_sigint
@ 2010-02-25 3:47 Sukadev Bhattiprolu
[not found] ` <20100225034746.GA18829-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Sukadev Bhattiprolu @ 2010-02-25 3:47 UTC (permalink / raw)
To: Oren Laadan; +Cc: Containers
global_send_sigint is -1 by default.
If it is -1, we either send SIGKILL or SIGINIT depending on whether
we started "new pidns with init" or "new pidns without init".
If global_send_sigint is explicitly set to 0 by user (--signal is set).
no signal is sent.
Given that we are making restart() available in libcheckpoint.a, would
it make sense to switch the behaviors of 0 and -1 ?
i.e if global_send_sigint is 0, send the default signal (SIGINT or SIGKILL).
If it is -1, then don't send any signal.
That way, applications of restart() (i.e LXC) can simply
memset(&args, 0, sizeof(args))
and get the default behavior. Now they have to explicitly set to -1.
Sukadev
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: global_send_sigint
[not found] ` <20100225034746.GA18829-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
@ 2011-01-11 1:59 ` Oren Laadan
[not found] ` <4D2BB975.2010306-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Oren Laadan @ 2011-01-11 1:59 UTC (permalink / raw)
To: Sukadev Bhattiprolu; +Cc: Containers
At the moment, at least @klogd field has to be set manually.
Perhaps it would be better to provide a pre-initialized struct,
so that users could do:
args = CR_RESTART_ARGS;
or
cr_init_restart_args(&args);
?
Oren
On 02/24/2010 10:47 PM, Sukadev Bhattiprolu wrote:
>
> global_send_sigint is -1 by default.
>
> If it is -1, we either send SIGKILL or SIGINIT depending on whether
> we started "new pidns with init" or "new pidns without init".
>
> If global_send_sigint is explicitly set to 0 by user (--signal is set).
> no signal is sent.
>
> Given that we are making restart() available in libcheckpoint.a, would
> it make sense to switch the behaviors of 0 and -1 ?
>
> i.e if global_send_sigint is 0, send the default signal (SIGINT or SIGKILL).
> If it is -1, then don't send any signal.
>
> That way, applications of restart() (i.e LXC) can simply
>
> memset(&args, 0, sizeof(args))
>
> and get the default behavior. Now they have to explicitly set to -1.
>
> Sukadev
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: global_send_sigint
[not found] ` <4D2BB975.2010306-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
@ 2011-01-11 21:59 ` Sukadev Bhattiprolu
0 siblings, 0 replies; 3+ messages in thread
From: Sukadev Bhattiprolu @ 2011-01-11 21:59 UTC (permalink / raw)
To: Oren Laadan; +Cc: Containers
Oren Laadan [orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org] wrote:
|
| At the moment, at least @klogd field has to be set manually.
|
| Perhaps it would be better to provide a pre-initialized struct,
| so that users could do:
|
| args = CR_RESTART_ARGS;
| or
| cr_init_restart_args(&args);
|
| ?
Yes, that would be more generalized.
Sukadev
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-01-11 21:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-25 3:47 global_send_sigint Sukadev Bhattiprolu
[not found] ` <20100225034746.GA18829-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2011-01-11 1:59 ` global_send_sigint Oren Laadan
[not found] ` <4D2BB975.2010306-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2011-01-11 21:59 ` global_send_sigint Sukadev Bhattiprolu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.