From: David Miller <davem@davemloft.net>
To: remi.denis-courmont@nokia.com
Cc: error27@gmail.com, dan.j.rosenberg@gmail.com,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch v2] phonet: some signedness bugs
Date: Thu, 13 Jan 2011 20:30:02 +0000 [thread overview]
Message-ID: <20110113.123002.46348652.davem@davemloft.net> (raw)
In-Reply-To: <201101131432.58059.remi.denis-courmont@nokia.com>
From: "Rémi Denis-Courmont" <remi.denis-courmont@nokia.com>
Date: Thu, 13 Jan 2011 14:32:57 +0200
> On Tuesday 11 January 2011 02:06:20 ext David Miller, you wrote:
>> From: Dan Carpenter <error27@gmail.com>
>> Date: Mon, 10 Jan 2011 17:06:58 +0300
>>
>> > Dan Rosenberg pointed out that there were some signed comparison bugs
>> > in the phonet protocol.
>> >
>> > http://marc.info/?l=full-disclosure&m\x129424528425330&w=2
>> >
>> > The problem is that we check for array overflows but "protocol" is
>> > signed and we don't check for array underflows. If you have already
>> > have CAP_SYS_ADMIN then you could use the bugs to get root, or someone
>> > could cause an oops by mistake.
>> >
>> > Signed-off-by: Dan Carpenter <error27@gmail.com>
>>
>> Applied.
>
> Shouldn't this be sent to stable trees?
It will be.
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: remi.denis-courmont@nokia.com
Cc: error27@gmail.com, dan.j.rosenberg@gmail.com,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch v2] phonet: some signedness bugs
Date: Thu, 13 Jan 2011 12:30:02 -0800 (PST) [thread overview]
Message-ID: <20110113.123002.46348652.davem@davemloft.net> (raw)
In-Reply-To: <201101131432.58059.remi.denis-courmont@nokia.com>
From: "Rémi Denis-Courmont" <remi.denis-courmont@nokia.com>
Date: Thu, 13 Jan 2011 14:32:57 +0200
> On Tuesday 11 January 2011 02:06:20 ext David Miller, you wrote:
>> From: Dan Carpenter <error27@gmail.com>
>> Date: Mon, 10 Jan 2011 17:06:58 +0300
>>
>> > Dan Rosenberg pointed out that there were some signed comparison bugs
>> > in the phonet protocol.
>> >
>> > http://marc.info/?l=full-disclosure&m=129424528425330&w=2
>> >
>> > The problem is that we check for array overflows but "protocol" is
>> > signed and we don't check for array underflows. If you have already
>> > have CAP_SYS_ADMIN then you could use the bugs to get root, or someone
>> > could cause an oops by mistake.
>> >
>> > Signed-off-by: Dan Carpenter <error27@gmail.com>
>>
>> Applied.
>
> Shouldn't this be sent to stable trees?
It will be.
next prev parent reply other threads:[~2011-01-13 20:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-07 20:37 [patch] phonet: some signedness bugs Dan Carpenter
2011-01-07 20:37 ` Dan Carpenter
2011-01-10 0:45 ` David Miller
2011-01-10 0:45 ` David Miller
2011-01-10 2:13 ` David Miller
2011-01-10 2:13 ` David Miller
2011-01-10 7:58 `
2011-01-10 7:58 ` Rémi Denis-Courmont
2011-01-10 14:01 ` Dan Carpenter
2011-01-10 14:01 ` Dan Carpenter
2011-01-10 14:08 `
2011-01-10 14:08 ` Rémi Denis-Courmont
2011-01-10 14:06 ` [patch v2] " Dan Carpenter
2011-01-10 14:06 ` Dan Carpenter
2011-01-10 14:12 `
2011-01-10 14:12 ` Rémi Denis-Courmont
2011-01-11 0:06 ` David Miller
2011-01-11 0:06 ` David Miller
2011-01-13 12:32 `
2011-01-13 12:32 ` Rémi Denis-Courmont
2011-01-13 20:30 ` David Miller [this message]
2011-01-13 20:30 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110113.123002.46348652.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dan.j.rosenberg@gmail.com \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=remi.denis-courmont@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.