From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: Fabien Chouteau <chouteau@adacore.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Close Gdb stub connection in gdb_exit
Date: Thu, 13 Jan 2011 12:01:56 +0100 [thread overview]
Message-ID: <20110113110156.GC7296@edde.se.axis.com> (raw)
In-Reply-To: <4D2EC4E2.4080000@adacore.com>
On Thu, Jan 13, 2011 at 10:24:50AM +0100, Fabien Chouteau wrote:
> On 01/04/2011 11:27 AM, Fabien Chouteau wrote:
> > On Windows, this is required to flush the remaining data in the IO stream,
> > otherwise Gdb do not receive the last packet.
> >
> > Signed-off-by: Fabien Chouteau<chouteau@adacore.com>
> > ---
> > gdbstub.c | 4 ++++
> > 1 files changed, 4 insertions(+), 0 deletions(-)
> >
> > diff --git a/gdbstub.c b/gdbstub.c
> > index 0aa081b..dac3ce6 100644
> > --- a/gdbstub.c
> > +++ b/gdbstub.c
> > @@ -2391,6 +2391,10 @@ void gdb_exit(CPUState *env, int code)
> >
> > snprintf(buf, sizeof(buf), "W%02x", (uint8_t)code);
> > put_packet(s, buf);
> > +
> > + if (s->chr) {
> > + qemu_chr_close(s->chr);
> > + }
> > }
> >
> > #ifdef CONFIG_USER_ONLY
>
> Any comment on this patch?
Yes, sorry for the delays. This patch breaks the linux-user build.
Cheers
next prev parent reply other threads:[~2011-01-13 11:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 10:27 [Qemu-devel] [PATCH] Close Gdb stub connection in gdb_exit Fabien Chouteau
2011-01-13 9:24 ` Fabien Chouteau
2011-01-13 11:01 ` Edgar E. Iglesias [this message]
2011-01-13 11:44 ` Fabien Chouteau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110113110156.GC7296@edde.se.axis.com \
--to=edgar.iglesias@gmail.com \
--cc=chouteau@adacore.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.