All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-hotplug@vger.kernel.org,
	Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@elte.hu>,
	Rusty Russell <rusty@rustcorp.com.au>,
	Amit Kucheria <amit.kucheria@linaro.org>
Subject: Re: [PATCH] tracing, perf : add cpu hotplug trace events
Date: Mon, 17 Jan 2011 16:21:08 +0000	[thread overview]
Message-ID: <20110117162105.GA1778@nowhere> (raw)
In-Reply-To: <AANLkTi=nugnkimG75Qh3t2vu8-qy2LKKHwoY2FFFpWDp@mail.gmail.com>

On Mon, Jan 17, 2011 at 07:49:58AM -0600, Vincent Guittot wrote:
> I was just wondering which tracepoints format between my 1st proposal
> and yours was the easier to post process by an application like
> pytimechart.

No idea as pytimechart uses his own ad hoc event parsing. Either
way there won't be much differences though.

> I have updated the cpu hotplug tracepoint according to your remarks
> and steve's ones. I have just replaced the second
> cpu_arch_die_start/end in your proposal by cpu_arch_dead_start/endfrq

Tracepoints tend to describe actions rather than states, although I can
show you some exceptions as well. But this tends to be the major
tendency. I suggest you to be stay consistent with this scheme.

Thanks.

WARNING: multiple messages have this Message-ID (diff)
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-hotplug@vger.kernel.org,
	Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@elte.hu>,
	Rusty Russell <rusty@rustcorp.com.au>,
	Amit Kucheria <amit.kucheria@linaro.org>
Subject: Re: [PATCH] tracing, perf : add cpu hotplug trace events
Date: Mon, 17 Jan 2011 17:21:08 +0100	[thread overview]
Message-ID: <20110117162105.GA1778@nowhere> (raw)
In-Reply-To: <AANLkTi=nugnkimG75Qh3t2vu8-qy2LKKHwoY2FFFpWDp@mail.gmail.com>

On Mon, Jan 17, 2011 at 07:49:58AM -0600, Vincent Guittot wrote:
> I was just wondering which tracepoints format between my 1st proposal
> and yours was the easier to post process by an application like
> pytimechart.

No idea as pytimechart uses his own ad hoc event parsing. Either
way there won't be much differences though.

> I have updated the cpu hotplug tracepoint according to your remarks
> and steve's ones. I have just replaced the second
> cpu_arch_die_start/end in your proposal by cpu_arch_dead_start/endfrq

Tracepoints tend to describe actions rather than states, although I can
show you some exceptions as well. But this tends to be the major
tendency. I suggest you to be stay consistent with this scheme.

Thanks.

  reply	other threads:[~2011-01-17 16:21 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-04  9:50 [PATCH] tracing, perf : add cpu hotplug trace events Vincent Guittot
2011-01-04  9:50 ` Vincent Guittot
2011-01-07  9:21 ` Amit Kucheria
2011-01-07  9:33   ` Amit Kucheria
2011-01-07 12:07   ` Vincent Guittot
2011-01-07 12:07     ` Vincent Guittot
2011-01-07 15:52   ` Steven Rostedt
2011-01-07 15:52     ` Steven Rostedt
2011-01-07 15:12 ` Frederic Weisbecker
2011-01-07 15:12   ` Frederic Weisbecker
2011-01-07 18:25   ` Vincent Guittot
2011-01-07 18:25     ` Vincent Guittot
2011-01-14 18:35     ` Frederic Weisbecker
2011-01-14 18:35       ` Frederic Weisbecker
2011-01-17 13:49       ` Vincent Guittot
2011-01-17 13:49         ` Vincent Guittot
2011-01-17 16:21         ` Frederic Weisbecker [this message]
2011-01-17 16:21           ` Frederic Weisbecker
2011-01-17 17:33           ` Vincent Guittot
2011-01-17 17:33             ` Vincent Guittot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110117162105.GA1778@nowhere \
    --to=fweisbec@gmail.com \
    --cc=amit.kucheria@linaro.org \
    --cc=linux-hotplug@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    --cc=rusty@rustcorp.com.au \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.