From: Tony Lindgren <tony@atomide.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Richard Woodruff <r-woodruff2@ti.com>
Subject: Re: State of LDP3430 platform
Date: Mon, 17 Jan 2011 17:25:42 -0800 [thread overview]
Message-ID: <20110118012541.GN4957@atomide.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1101152028580.13225@utopia.booyaka.com>
Hi,
* Paul Walmsley <paul@pwsan.com> [110115 20:31]:
> --- a/arch/arm/mach-omap1/time.c
> +++ b/arch/arm/mach-omap1/time.c
> @@ -244,6 +244,13 @@ static void __init omap_timer_init(void)
>
> omap_init_mpu_timer(rate);
> omap_init_clocksource(rate);
> + /*
> + * XXX Since this file seems to deal mostly with the MPU timer,
> + * this doesn't seem like the correct place for the sync timer
> + * clocksource init.
> + */
> + if (!cpu_is_omap7xx() && !cpu_is_omap15xx())
> + omap_init_clocksource_32k();
> }
>
> struct sys_timer omap_timer = {
To me it looks like the omap_init_clocksource_32k() call should be
in arch/arm/mach-omap1/timer32k.c instead.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: State of LDP3430 platform
Date: Mon, 17 Jan 2011 17:25:42 -0800 [thread overview]
Message-ID: <20110118012541.GN4957@atomide.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1101152028580.13225@utopia.booyaka.com>
Hi,
* Paul Walmsley <paul@pwsan.com> [110115 20:31]:
> --- a/arch/arm/mach-omap1/time.c
> +++ b/arch/arm/mach-omap1/time.c
> @@ -244,6 +244,13 @@ static void __init omap_timer_init(void)
>
> omap_init_mpu_timer(rate);
> omap_init_clocksource(rate);
> + /*
> + * XXX Since this file seems to deal mostly with the MPU timer,
> + * this doesn't seem like the correct place for the sync timer
> + * clocksource init.
> + */
> + if (!cpu_is_omap7xx() && !cpu_is_omap15xx())
> + omap_init_clocksource_32k();
> }
>
> struct sys_timer omap_timer = {
To me it looks like the omap_init_clocksource_32k() call should be
in arch/arm/mach-omap1/timer32k.c instead.
Regards,
Tony
next prev parent reply other threads:[~2011-01-18 1:25 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 12:55 State of LDP3430 platform Russell King - ARM Linux
2010-12-06 15:59 ` Tony Lindgren
2010-12-06 17:22 ` Russell King - ARM Linux
2010-12-06 18:02 ` Tony Lindgren
2010-12-06 18:19 ` Tony Lindgren
2010-12-06 18:27 ` Paul Walmsley
2010-12-07 8:37 ` Russell King - ARM Linux
2010-12-08 0:50 ` Paul Walmsley
2010-12-08 3:40 ` Paul Walmsley
2011-01-15 0:03 ` Tony Lindgren
2011-01-15 19:38 ` Paul Walmsley
2011-01-15 23:37 ` Russell King - ARM Linux
2011-01-16 0:04 ` Russell King - ARM Linux
2011-01-16 0:05 ` Woodruff, Richard
2011-01-16 0:30 ` Russell King - ARM Linux
2011-01-16 1:09 ` Paul Walmsley
2011-01-16 4:32 ` Paul Walmsley
2011-01-16 4:32 ` Paul Walmsley
2011-01-16 15:08 ` Thomas Weber
2011-01-16 15:08 ` Thomas Weber
2011-01-18 19:36 ` Paul Walmsley
2011-01-18 19:36 ` Paul Walmsley
2011-01-18 22:26 ` [PATCH] omap1: Fix sched_clock for the MPU timer (Re: State of LDP3430 platform) Tony Lindgren
2011-01-18 22:26 ` Tony Lindgren
2011-01-18 22:35 ` [PATCH] omap1: Fix booting for 15xx and 730 with omap1_defconfig " Tony Lindgren
2011-01-18 22:35 ` Tony Lindgren
2011-01-18 23:21 ` Tony Lindgren
2011-01-18 23:21 ` Tony Lindgren
2011-01-19 18:43 ` [PATCH] omap1: Fix sched_clock implementation when both MPU timer and 32K timer are used " Tony Lindgren
2011-01-19 18:43 ` Tony Lindgren
2011-01-19 18:44 ` [PATCH] omap1: Fix sched_clock for the MPU timer " Tony Lindgren
2011-01-19 18:44 ` Tony Lindgren
2011-01-19 13:43 ` State of LDP3430 platform Jarkko Nikula
2011-01-19 13:43 ` Jarkko Nikula
2011-01-18 1:25 ` Tony Lindgren [this message]
2011-01-18 1:25 ` Tony Lindgren
2011-01-18 19:24 ` Paul Walmsley
2011-01-18 19:24 ` Paul Walmsley
2011-01-15 23:47 ` Woodruff, Richard
2011-01-17 17:34 ` Tony Lindgren
2011-01-17 17:44 ` Woodruff, Richard
2011-02-12 16:02 ` Russell King - ARM Linux
2011-02-12 16:10 ` Russell King - ARM Linux
2011-02-23 22:50 ` Tony Lindgren
2011-02-23 23:22 ` Woodruff, Richard
2011-02-24 7:08 ` Rajendra Nayak
2011-02-24 13:07 ` Rajendra Nayak
2011-02-24 8:21 ` Janorkar, Mayuresh
2011-02-24 8:47 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110118012541.GN4957@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=paul@pwsan.com \
--cc=r-woodruff2@ti.com \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.