From: Tony Lindgren <tony@atomide.com>
To: Kevin Hilman <khilman@ti.com>
Cc: jean.pihet@newoldbits.com, Dave Martin <dave.martin@linaro.org>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
Jean Pihet <j-pihet@ti.com>
Subject: Re: [PATCH v2] OMAP: use fncpy to copy the PM code functions to SRAM
Date: Wed, 19 Jan 2011 14:10:57 -0800 [thread overview]
Message-ID: <20110119221056.GG4957@atomide.com> (raw)
In-Reply-To: <87mxmwr2un.fsf@ti.com>
* Kevin Hilman <khilman@ti.com> [110119 13:37]:
> Kevin Hilman <khilman@ti.com> writes:
>
> > jean.pihet@newoldbits.com writes:
> >
> >> From: Jean Pihet <j-pihet@ti.com>
> >>
> >> The new fncpy API is better suited for copying some
> >> code to SRAM at runtime. This patch changes the ad-hoc
> >> code to the more generic fncpy API.
> >>
> >> Tested OK on OMAP3 in low power modes (RET/OFF)
> >> using omap2plus_defconfig with !CONFIG_THUMB2_KERNEL.
> >> Compile tested on OMAP1/2 using omap1_defconfig.
> >>
> >> Signed-off-by: Jean Pihet <j-pihet@ti.com>
> >
> > Acked-by: Kevin Hilman <khilman@ti.com>
> >
> > Boot tested on OMAP1 & OMAP2 as well. Note that neither OMAP1 or OMAP2
> > has had working suspend/resume for a long time now, so I did not test
> > suspend/resume.
>
> For OMAP2:
>
> Tested-by: Kevin Hilman <khilman@ti.com>
>
> to test a little more on OMAP2, I just removed the WFI from the
> low-level code and tested suspend that way. That's enough to be sure
> the copied code is copied and executed.
>
> Worked fine on OMAP2420/n810.
>
> For OMAP1, this didn't work and would require more serious hacking on
> the OMAP1 suspend path, which I currently have no plans to do.
Boots fine on osk5912 and n800 too:
Tested-by: Tony Lindgren <tony@atomide.com>
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] OMAP: use fncpy to copy the PM code functions to SRAM
Date: Wed, 19 Jan 2011 14:10:57 -0800 [thread overview]
Message-ID: <20110119221056.GG4957@atomide.com> (raw)
In-Reply-To: <87mxmwr2un.fsf@ti.com>
* Kevin Hilman <khilman@ti.com> [110119 13:37]:
> Kevin Hilman <khilman@ti.com> writes:
>
> > jean.pihet at newoldbits.com writes:
> >
> >> From: Jean Pihet <j-pihet@ti.com>
> >>
> >> The new fncpy API is better suited for copying some
> >> code to SRAM at runtime. This patch changes the ad-hoc
> >> code to the more generic fncpy API.
> >>
> >> Tested OK on OMAP3 in low power modes (RET/OFF)
> >> using omap2plus_defconfig with !CONFIG_THUMB2_KERNEL.
> >> Compile tested on OMAP1/2 using omap1_defconfig.
> >>
> >> Signed-off-by: Jean Pihet <j-pihet@ti.com>
> >
> > Acked-by: Kevin Hilman <khilman@ti.com>
> >
> > Boot tested on OMAP1 & OMAP2 as well. Note that neither OMAP1 or OMAP2
> > has had working suspend/resume for a long time now, so I did not test
> > suspend/resume.
>
> For OMAP2:
>
> Tested-by: Kevin Hilman <khilman@ti.com>
>
> to test a little more on OMAP2, I just removed the WFI from the
> low-level code and tested suspend that way. That's enough to be sure
> the copied code is copied and executed.
>
> Worked fine on OMAP2420/n810.
>
> For OMAP1, this didn't work and would require more serious hacking on
> the OMAP1 suspend path, which I currently have no plans to do.
Boots fine on osk5912 and n800 too:
Tested-by: Tony Lindgren <tony@atomide.com>
next prev parent reply other threads:[~2011-01-19 22:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-18 12:02 [PATCH v2] OMAP: use fncpy to copy the PM code functions to SRAM jean.pihet
2011-01-18 12:02 ` jean.pihet at newoldbits.com
2011-01-19 18:31 ` Kevin Hilman
2011-01-19 18:31 ` Kevin Hilman
2011-01-19 21:38 ` Kevin Hilman
2011-01-19 21:38 ` Kevin Hilman
2011-01-19 22:10 ` Tony Lindgren [this message]
2011-01-19 22:10 ` Tony Lindgren
2011-01-20 13:14 ` Jean Pihet
2011-01-20 13:14 ` Jean Pihet
2011-01-24 16:11 ` Dave Martin
2011-01-24 16:11 ` Dave Martin
2011-01-24 17:25 ` Jean Pihet
2011-01-24 17:25 ` Jean Pihet
2011-01-25 10:33 ` Dave Martin
2011-01-25 10:33 ` Dave Martin
2011-01-25 17:22 ` Jean Pihet
2011-01-25 17:22 ` Jean Pihet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110119221056.GG4957@atomide.com \
--to=tony@atomide.com \
--cc=dave.martin@linaro.org \
--cc=j-pihet@ti.com \
--cc=jean.pihet@newoldbits.com \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.