All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Weiner <hannes@cmpxchg.org>
To: Andrea Arcangeli <aarcange@redhat.com>
Cc: werner <w.landgraf@ru.ru>, Borislav Petkov <bp@amd64.org>,
	Ilya Dryomov <idryomov@gmail.com>, linux-mm <linux-mm@kvack.org>,
	linux-kernel@vger.kernel.org
Subject: Re: 2.6.38-rc1 problems with khugepaged
Date: Thu, 20 Jan 2011 02:10:26 +0100	[thread overview]
Message-ID: <20110120011026.GJ2232@cmpxchg.org> (raw)
In-Reply-To: <20110120000147.GR9506@random.random>

On Thu, Jan 20, 2011 at 01:01:47AM +0100, Andrea Arcangeli wrote:
> On Wed, Jan 19, 2011 at 10:45:23PM +0100, Johannes Weiner wrote:
> > Hi,
> > 
> > On Wed, Jan 19, 2011 at 04:59:54PM +0100, Borislav Petkov wrote:
> > > Adding some more parties to CC.
> > > 
> > > On Wed, Jan 19, 2011 at 09:45:25AM -0400, werner wrote:
> > > > **  Help   Help Help ***
> > > > 
> > > > My computer crashs on booting  ...   :( :(
> > 
> > That sucks!
> > 
> > I cross-compiled for 32-bit and was able to match up the disassembly
> > against the code line from your oops report.  Apparently the pte was
> > an invalid pointer, and it makes perfect sense: we unmap the highpte
> > _before_ we access the pointer again for __collapse_huge_page_copy().
> > 
> > Can you test with this fix applied?  It is only compile-tested, I too
> > have no 32-bit installations anymore.
> 
> Thanks Johannes, I already sent the same fix a few minutes ago, it is
> also confirmed to work from Ilya in Message-ID:
> <20110119224950.GA3429@kwango.lan.net>

Actually, I sent it half an hour before you ;-) But good to see that
it fixes the problem.

	Hannes

WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: Andrea Arcangeli <aarcange@redhat.com>
Cc: werner <w.landgraf@ru.ru>, Borislav Petkov <bp@amd64.org>,
	Ilya Dryomov <idryomov@gmail.com>, linux-mm <linux-mm@kvack.org>,
	linux-kernel@vger.kernel.org
Subject: Re: 2.6.38-rc1 problems with khugepaged
Date: Thu, 20 Jan 2011 02:10:26 +0100	[thread overview]
Message-ID: <20110120011026.GJ2232@cmpxchg.org> (raw)
In-Reply-To: <20110120000147.GR9506@random.random>

On Thu, Jan 20, 2011 at 01:01:47AM +0100, Andrea Arcangeli wrote:
> On Wed, Jan 19, 2011 at 10:45:23PM +0100, Johannes Weiner wrote:
> > Hi,
> > 
> > On Wed, Jan 19, 2011 at 04:59:54PM +0100, Borislav Petkov wrote:
> > > Adding some more parties to CC.
> > > 
> > > On Wed, Jan 19, 2011 at 09:45:25AM -0400, werner wrote:
> > > > **  Help   Help Help ***
> > > > 
> > > > My computer crashs on booting  ...   :( :(
> > 
> > That sucks!
> > 
> > I cross-compiled for 32-bit and was able to match up the disassembly
> > against the code line from your oops report.  Apparently the pte was
> > an invalid pointer, and it makes perfect sense: we unmap the highpte
> > _before_ we access the pointer again for __collapse_huge_page_copy().
> > 
> > Can you test with this fix applied?  It is only compile-tested, I too
> > have no 32-bit installations anymore.
> 
> Thanks Johannes, I already sent the same fix a few minutes ago, it is
> also confirmed to work from Ilya in Message-ID:
> <20110119224950.GA3429@kwango.lan.net>

Actually, I sent it half an hour before you ;-) But good to see that
it fixes the problem.

	Hannes

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2011-01-20  1:10 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-19 13:45 2.6.38-rc1 problems with khugepaged werner
2011-01-19 15:59 ` Borislav Petkov
2011-01-19 15:59   ` Borislav Petkov
2011-01-19 19:55   ` Andrea Arcangeli
2011-01-19 19:55     ` Andrea Arcangeli
2011-01-19 21:45   ` Johannes Weiner
2011-01-19 21:45     ` Johannes Weiner
2011-01-20  0:01     ` Andrea Arcangeli
2011-01-20  0:01       ` Andrea Arcangeli
2011-01-20  1:10       ` Johannes Weiner [this message]
2011-01-20  1:10         ` Johannes Weiner
2011-01-20  1:21         ` Andrea Arcangeli
2011-01-20  1:21           ` Andrea Arcangeli
2011-01-19 22:21   ` Andrea Arcangeli
2011-01-19 22:21     ` Andrea Arcangeli
2011-01-20 20:13     ` Steven Rostedt
2011-01-20 20:13       ` Steven Rostedt
  -- strict thread matches above, loose matches on Subject: below --
2011-01-21  8:36 werner
2011-01-21 10:43 werner
2011-01-21 19:17 ` Andrea Arcangeli
2011-01-21 21:14   ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110120011026.GJ2232@cmpxchg.org \
    --to=hannes@cmpxchg.org \
    --cc=aarcange@redhat.com \
    --cc=bp@amd64.org \
    --cc=idryomov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=w.landgraf@ru.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.