From: Robert Richter <robert.richter@amd.com>
To: Ari Kauppi <kauppi@papupata.org>
Cc: Will Deacon <will.deacon@arm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Richard Purdie <rpurdie@rpsys.net>,
Matt Fleming <matt@console-pimps.org>
Subject: Re: [PATCH] ARM: oprofile: Always allow backtraces
Date: Thu, 20 Jan 2011 11:46:06 +0100 [thread overview]
Message-ID: <20110120104606.GA18297@erda.amd.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1101201213230.14307@lakka.kapsi.fi>
On 20.01.11 05:17:16, Ari Kauppi wrote:
> > @@ -91,6 +79,30 @@ static struct frame_tail* user_backtrace(struct frame_tail *tail)
> > return buftail[0].fp-1;
> > }
> >
> > +#else
> > +
> > +static int oprofile_arch_init(struct oprofile_operations *ops)
> > +{
> > + pr_info("oprofile: hardware counters not available\n");
> > + return -ENODEV;
> > +}
> > +
> > +static void oprofile_arch_exit(void) { }
>
> I guess you mean oprofile_perf_init and oprofile_perf_exit?
Yes, did not compile test it as my arm cross compile chain was broken.
Maybe we move it to include/linux/oprofile.h.
I also observed some mismatches while using CONFIG_HW_PERF_EVENTS and
CONFIG_PERF_EVENTS, esp. with include/linux/oprofile.h. /arch/sh is
also affected. We need to review this too.
>
> Also the user_backtrace and frame_tail need to be moved out from the
> #ifdef.
Yes, thanks.
-Robert
--
Advanced Micro Devices, Inc.
Operating System Research Center
WARNING: multiple messages have this Message-ID (diff)
From: robert.richter@amd.com (Robert Richter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: oprofile: Always allow backtraces
Date: Thu, 20 Jan 2011 11:46:06 +0100 [thread overview]
Message-ID: <20110120104606.GA18297@erda.amd.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1101201213230.14307@lakka.kapsi.fi>
On 20.01.11 05:17:16, Ari Kauppi wrote:
> > @@ -91,6 +79,30 @@ static struct frame_tail* user_backtrace(struct frame_tail *tail)
> > return buftail[0].fp-1;
> > }
> >
> > +#else
> > +
> > +static int oprofile_arch_init(struct oprofile_operations *ops)
> > +{
> > + pr_info("oprofile: hardware counters not available\n");
> > + return -ENODEV;
> > +}
> > +
> > +static void oprofile_arch_exit(void) { }
>
> I guess you mean oprofile_perf_init and oprofile_perf_exit?
Yes, did not compile test it as my arm cross compile chain was broken.
Maybe we move it to include/linux/oprofile.h.
I also observed some mismatches while using CONFIG_HW_PERF_EVENTS and
CONFIG_PERF_EVENTS, esp. with include/linux/oprofile.h. /arch/sh is
also affected. We need to review this too.
>
> Also the user_backtrace and frame_tail need to be moved out from the
> #ifdef.
Yes, thanks.
-Robert
--
Advanced Micro Devices, Inc.
Operating System Research Center
next prev parent reply other threads:[~2011-01-20 10:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-19 20:54 [PATCH] ARM: oprofile: Always allow backtraces Ari Kauppi
2011-01-19 20:54 ` Ari Kauppi
2011-01-20 9:42 ` Will Deacon
2011-01-20 9:52 ` Robert Richter
2011-01-20 9:52 ` Robert Richter
2011-01-20 9:57 ` Robert Richter
2011-01-20 9:57 ` Robert Richter
2011-01-20 10:02 ` Will Deacon
2011-01-20 10:02 ` Will Deacon
2011-01-20 10:17 ` Ari Kauppi
2011-01-20 10:17 ` Ari Kauppi
2011-01-20 10:46 ` Robert Richter [this message]
2011-01-20 10:46 ` Robert Richter
2011-01-20 9:42 ` Will Deacon
2011-01-20 12:31 ` Sergei Shtylyov
2011-01-20 12:31 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110120104606.GA18297@erda.amd.com \
--to=robert.richter@amd.com \
--cc=kauppi@papupata.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=matt@console-pimps.org \
--cc=rpurdie@rpsys.net \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.