From: Andrew Morton <akpm@linux-foundation.org>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Ali Gholami Rudi <aliqrudi@gmail.com>,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-acpi@vger.kernel.org,
rpurdie@rpsys.net
Subject: Re: [Intel-gfx] [PATCH 2/5] i915: Add native backlight control
Date: Thu, 20 Jan 2011 17:03:37 -0800 [thread overview]
Message-ID: <20110120170337.94d83333.akpm@linux-foundation.org> (raw)
In-Reply-To: <20110121004359.GA6422@srcf.ucam.org>
On Fri, 21 Jan 2011 00:43:59 +0000
Matthew Garrett <mjg59@srcf.ucam.org> wrote:
> On Thu, Jan 20, 2011 at 03:13:49PM -0800, Andrew Morton wrote:
> > On Fri, 21 Jan 2011 00:43:46 +0330
> > Ali Gholami Rudi <aliqrudi@gmail.com> wrote:
> >
> > > Ali Gholami Rudi <aliqrudi@gmail.com> wrote:
> > > > I tried to apply this patch but I get:
> > > >
> > > > drivers/gpu/drm/i915/intel_panel.c: In function 'intel_panel_setup_backlight':
> > > > drivers/gpu/drm/i915/intel_panel.c:319: error: 'struct backlight_properties' has no member named 'type'
> > > > drivers/gpu/drm/i915/intel_panel.c:319: error: 'BACKLIGHT_RAW' undeclared (first use in this function)
> > > > drivers/gpu/drm/i915/intel_panel.c:319: error: (Each undeclared identifier is reported only once
> > > > drivers/gpu/drm/i915/intel_panel.c:319: error: for each function it appears in.)
> > >
> > > After applying patch 1/5, the patch applied cleanly.
> > > Now I can change the brightness using
> > > /sys/class/backlight/intel_backlight/brightness.
> > > So it does fix my issue.
> > >
> >
> > So we have a patch ordering issue and the
> > radeon-expose-backlight-class-device-for-legacy-lvds-encoder.patch
> > build error.
>
> He applied 2/5, it didn't build, he applied 1/5 and it built? I don't
> think that's a patch ordering issue :)
What, you expect reading skills?
> I think Michel's patch should fix the Radeon one. If not, can you drop
> that and keep the rest of the set? I'm travelling at the moment and
> won't have proper build access until the weekend.
OK, I resurrected everything.
I updated the new drivers/video/backlight/adp5520_bl.c, but there's a
decent chance that unconverted drivers will sneak in. I trust they
will still work OK?
next prev parent reply other threads:[~2011-01-21 1:03 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-14 19:24 [PATCH 1/5] Backlight: Add backlight type Matthew Garrett
2011-01-14 19:24 ` [PATCH 2/5] i915: Add native backlight control Matthew Garrett
2011-01-14 19:24 ` Matthew Garrett
2011-01-20 20:30 ` [Intel-gfx] " Ali Gholami Rudi
2011-01-20 21:13 ` Ali Gholami Rudi
2011-01-20 23:13 ` [Intel-gfx] " Andrew Morton
2011-01-20 23:13 ` Andrew Morton
2011-01-21 0:43 ` Matthew Garrett
2011-01-21 1:03 ` Andrew Morton [this message]
2011-01-21 4:57 ` Matthew Garrett
2011-01-21 4:57 ` [Intel-gfx] " Matthew Garrett
2011-01-23 4:45 ` Ali Gholami Rudi
2011-01-23 4:45 ` [Intel-gfx] " Ali Gholami Rudi
2011-01-23 4:56 ` Matthew Garrett
2011-01-14 19:24 ` [PATCH 3/5] radeon: Expose backlight class device for legacy LVDS encoder Matthew Garrett
2011-01-15 17:34 ` Alex Deucher
2011-01-15 17:34 ` Alex Deucher
2011-01-20 2:12 ` Andrew Morton
2011-01-20 2:12 ` Andrew Morton
2011-01-20 9:05 ` [PATCH v2] drm/radeon/kms: " Michel Dänzer
2011-01-20 9:05 ` Michel Dänzer
2011-01-14 19:24 ` [PATCH 4/5] nouveau: Change the backlight parent device to the connector, not the PCI dev Matthew Garrett
2011-01-14 19:30 ` Anca Emanuel
2011-01-14 19:30 ` Anca Emanuel
2011-01-14 20:20 ` Matthew Garrett
2011-01-15 9:49 ` Ben Skeggs
2011-01-14 19:24 ` [PATCH 5/5] ACPI: Tie ACPI backlight devices to PCI devices if possible Matthew Garrett
2011-02-06 20:35 ` Rafael J. Wysocki
2011-02-06 20:56 ` Matthew Garrett
2011-02-06 20:56 ` Matthew Garrett
2011-02-06 22:41 ` Rafael J. Wysocki
2011-02-06 22:53 ` Matthew Garrett
2011-02-06 23:01 ` Rafael J. Wysocki
2011-02-06 23:05 ` Matthew Garrett
2011-02-06 23:05 ` Matthew Garrett
2011-02-06 23:34 ` Rafael J. Wysocki
2011-02-07 21:32 ` Bjorn Helgaas
2011-02-07 21:34 ` Matthew Garrett
2011-02-07 21:34 ` Matthew Garrett
2011-02-07 22:04 ` Rafael J. Wysocki
-- strict thread matches above, loose matches on Subject: below --
2011-01-21 5:36 [Intel-gfx] [PATCH 2/5] i915: Add native backlight control Sedat Dilek
2011-01-21 5:55 ` Andrew Morton
2011-01-21 5:55 ` Andrew Morton
2011-01-21 9:04 ` Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110120170337.94d83333.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aliqrudi@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.