From: Matthew Garrett <mjg59@srcf.ucam.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-acpi@vger.kernel.org,
rpurdie@rpsys.net, akpm@linux-foundation.org
Subject: Re: [PATCH 5/5] ACPI: Tie ACPI backlight devices to PCI devices if possible
Date: Sun, 6 Feb 2011 20:56:19 +0000 [thread overview]
Message-ID: <20110206205619.GA21472@srcf.ucam.org> (raw)
In-Reply-To: <201102062135.08171.rjw@sisk.pl>
On Sun, Feb 06, 2011 at 09:35:07PM +0100, Rafael J. Wysocki wrote:
> > + acpi_get_parent(device->dev->handle, &acpi_parent);
> > +
> > + pdev = acpi_get_pci_dev(acpi_parent);
> > + if (pdev) {
> > + parent = &pdev->dev;
> > + pci_dev_put(pdev);
> > + }
>
> I'm afraid you can't do that or suspend problems will happen.
Ugh. Ok, how can we fix this?
--
Matthew Garrett | mjg59@srcf.ucam.org
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: akpm@linux-foundation.org, intel-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, rpurdie@rpsys.net
Subject: Re: [PATCH 5/5] ACPI: Tie ACPI backlight devices to PCI devices if possible
Date: Sun, 6 Feb 2011 20:56:19 +0000 [thread overview]
Message-ID: <20110206205619.GA21472@srcf.ucam.org> (raw)
In-Reply-To: <201102062135.08171.rjw@sisk.pl>
On Sun, Feb 06, 2011 at 09:35:07PM +0100, Rafael J. Wysocki wrote:
> > + acpi_get_parent(device->dev->handle, &acpi_parent);
> > +
> > + pdev = acpi_get_pci_dev(acpi_parent);
> > + if (pdev) {
> > + parent = &pdev->dev;
> > + pci_dev_put(pdev);
> > + }
>
> I'm afraid you can't do that or suspend problems will happen.
Ugh. Ok, how can we fix this?
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2011-02-06 20:56 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-14 19:24 [PATCH 1/5] Backlight: Add backlight type Matthew Garrett
2011-01-14 19:24 ` [PATCH 2/5] i915: Add native backlight control Matthew Garrett
2011-01-14 19:24 ` Matthew Garrett
2011-01-20 20:30 ` [Intel-gfx] " Ali Gholami Rudi
2011-01-20 21:13 ` Ali Gholami Rudi
2011-01-20 23:13 ` [Intel-gfx] " Andrew Morton
2011-01-20 23:13 ` Andrew Morton
2011-01-21 0:43 ` Matthew Garrett
2011-01-21 1:03 ` Andrew Morton
2011-01-21 4:57 ` Matthew Garrett
2011-01-21 4:57 ` [Intel-gfx] " Matthew Garrett
2011-01-23 4:45 ` Ali Gholami Rudi
2011-01-23 4:45 ` [Intel-gfx] " Ali Gholami Rudi
2011-01-23 4:56 ` Matthew Garrett
2011-01-14 19:24 ` [PATCH 3/5] radeon: Expose backlight class device for legacy LVDS encoder Matthew Garrett
2011-01-15 17:34 ` Alex Deucher
2011-01-15 17:34 ` Alex Deucher
2011-01-20 2:12 ` Andrew Morton
2011-01-20 2:12 ` Andrew Morton
2011-01-20 9:05 ` [PATCH v2] drm/radeon/kms: " Michel Dänzer
2011-01-20 9:05 ` Michel Dänzer
2011-01-14 19:24 ` [PATCH 4/5] nouveau: Change the backlight parent device to the connector, not the PCI dev Matthew Garrett
2011-01-14 19:30 ` Anca Emanuel
2011-01-14 19:30 ` Anca Emanuel
2011-01-14 20:20 ` Matthew Garrett
2011-01-15 9:49 ` Ben Skeggs
2011-01-14 19:24 ` [PATCH 5/5] ACPI: Tie ACPI backlight devices to PCI devices if possible Matthew Garrett
2011-02-06 20:35 ` Rafael J. Wysocki
2011-02-06 20:56 ` Matthew Garrett [this message]
2011-02-06 20:56 ` Matthew Garrett
2011-02-06 22:41 ` Rafael J. Wysocki
2011-02-06 22:53 ` Matthew Garrett
2011-02-06 23:01 ` Rafael J. Wysocki
2011-02-06 23:05 ` Matthew Garrett
2011-02-06 23:05 ` Matthew Garrett
2011-02-06 23:34 ` Rafael J. Wysocki
2011-02-07 21:32 ` Bjorn Helgaas
2011-02-07 21:34 ` Matthew Garrett
2011-02-07 21:34 ` Matthew Garrett
2011-02-07 22:04 ` Rafael J. Wysocki
-- strict thread matches above, loose matches on Subject: below --
2010-11-19 15:53 [PATCH 1/5] Backlight: Add backlight type Matthew Garrett
2010-11-19 15:53 ` [PATCH 5/5] ACPI: Tie ACPI backlight devices to PCI devices if possible Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110206205619.GA21472@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=akpm@linux-foundation.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.