From: Andrea Arcangeli <aarcange@redhat.com>
To: Christoph Lameter <cl@linux.com>
Cc: Minchan Kim <minchan.kim@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>, Mel Gorman <mel@csn.ul.ie>
Subject: Re: [PATCH 1/3] When migrate_pages returns 0, all pages must have been released
Date: Thu, 20 Jan 2011 19:24:44 +0100 [thread overview]
Message-ID: <20110120182444.GA9506@random.random> (raw)
In-Reply-To: <alpine.DEB.2.00.1101201130100.10695@router.home>
Hello,
On Thu, Jan 20, 2011 at 11:30:35AM -0600, Christoph Lameter wrote:
> On Fri, 21 Jan 2011, Minchan Kim wrote:
>
> > diff --git a/mm/migrate.c b/mm/migrate.c
> > index 46fe8cc..7d34237 100644
> > --- a/mm/migrate.c
> > +++ b/mm/migrate.c
> > @@ -772,6 +772,7 @@ uncharge:
> > unlock:
> > unlock_page(page);
> >
> > +move_newpage:
> > if (rc != -EAGAIN) {
> > /*
> > * A page that has been migrated has all references
> > @@ -785,8 +786,6 @@ unlock:
> > putback_lru_page(page);
> > }
> >
> > -move_newpage:
> > -
> > /*
> > * Move the new page to the LRU. If migration was not successful
> > * then this will free the page.
> >
>
> What does this do? Not covered by the description.
It makes a difference for the two goto move_newpage, when rc =
0. Otherwise the function will return 0, despite
putback_lru_page(page) wasn't called (and the caller of migrate_pages
won't call putback_lru_pages if migrate_pages returned 0).
WARNING: multiple messages have this Message-ID (diff)
From: Andrea Arcangeli <aarcange@redhat.com>
To: Christoph Lameter <cl@linux.com>
Cc: Minchan Kim <minchan.kim@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>, Mel Gorman <mel@csn.ul.ie>
Subject: Re: [PATCH 1/3] When migrate_pages returns 0, all pages must have been released
Date: Thu, 20 Jan 2011 19:24:44 +0100 [thread overview]
Message-ID: <20110120182444.GA9506@random.random> (raw)
In-Reply-To: <alpine.DEB.2.00.1101201130100.10695@router.home>
Hello,
On Thu, Jan 20, 2011 at 11:30:35AM -0600, Christoph Lameter wrote:
> On Fri, 21 Jan 2011, Minchan Kim wrote:
>
> > diff --git a/mm/migrate.c b/mm/migrate.c
> > index 46fe8cc..7d34237 100644
> > --- a/mm/migrate.c
> > +++ b/mm/migrate.c
> > @@ -772,6 +772,7 @@ uncharge:
> > unlock:
> > unlock_page(page);
> >
> > +move_newpage:
> > if (rc != -EAGAIN) {
> > /*
> > * A page that has been migrated has all references
> > @@ -785,8 +786,6 @@ unlock:
> > putback_lru_page(page);
> > }
> >
> > -move_newpage:
> > -
> > /*
> > * Move the new page to the LRU. If migration was not successful
> > * then this will free the page.
> >
>
> What does this do? Not covered by the description.
It makes a difference for the two goto move_newpage, when rc =
0. Otherwise the function will return 0, despite
putback_lru_page(page) wasn't called (and the caller of migrate_pages
won't call putback_lru_pages if migrate_pages returned 0).
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-01-20 18:25 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-20 16:17 [PATCH 1/3] When migrate_pages returns 0, all pages must have been released Minchan Kim
2011-01-20 16:17 ` Minchan Kim
2011-01-20 16:17 ` [PATCH 2/3] migration: Fix page corruption during hugepage migration Minchan Kim
2011-01-20 16:17 ` Minchan Kim
2011-01-20 16:17 ` [PATCH 3/3] compaction: Check migrate_pages's return value instead of list_empty Minchan Kim
2011-01-20 16:17 ` Minchan Kim
2011-01-26 8:18 ` Mel Gorman
2011-01-26 8:18 ` Mel Gorman
2011-01-20 17:30 ` [PATCH 1/3] When migrate_pages returns 0, all pages must have been released Christoph Lameter
2011-01-20 17:30 ` Christoph Lameter
2011-01-20 18:24 ` Andrea Arcangeli [this message]
2011-01-20 18:24 ` Andrea Arcangeli
2011-01-20 18:49 ` Christoph Lameter
2011-01-20 18:49 ` Christoph Lameter
2011-01-20 21:28 ` Andrea Arcangeli
2011-01-20 21:28 ` Andrea Arcangeli
2011-01-21 16:11 ` Christoph Lameter
2011-01-21 16:11 ` Christoph Lameter
2011-01-21 17:36 ` Andrea Arcangeli
2011-01-21 17:36 ` Andrea Arcangeli
2011-01-21 23:54 ` Minchan Kim
2011-01-21 23:54 ` Minchan Kim
2011-01-26 8:14 ` Mel Gorman
2011-01-26 8:14 ` Mel Gorman
2011-01-26 23:06 ` Andrew Morton
2011-01-26 23:06 ` Andrew Morton
2011-01-26 23:21 ` Minchan Kim
2011-01-26 23:21 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110120182444.GA9506@random.random \
--to=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=minchan.kim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.