From: Dave Chinner <david@fromorbit.com>
To: Malcolm Scott <lkml@malc.org.uk>
Cc: linux-kernel@vger.kernel.org, xfs@oss.sgi.com
Subject: [PATCH] Re: XFS deadlock in 2.6.37
Date: Fri, 21 Jan 2011 16:28:02 +1100 [thread overview]
Message-ID: <20110121052802.GA16267@dastard> (raw)
In-Reply-To: <alpine.DEB.2.00.1101201702260.29071@callisto.malc.org.uk>
[cc xfs@os.sgi.com]
On Thu, Jan 20, 2011 at 05:08:45PM +0000, Malcolm Scott wrote:
> Hi all,
>
> I've had the following deadlock happen twice on a 2.6.37 system with
> several XFS filesystems (including root) and no swap (may be
> relevant, considering that kswapd is one task involved here). Some
> minor filesystem corruption resulted (but maybe only because the
> root fs couldn't be synced/umounted).
>
> If you need any more info, please let me know.
>
> --- first crash ---
>
> [504603.250208] INFO: task kswapd0:37 blocked for more than 120 seconds.
> [504603.261107] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
> [504603.273465] kswapd0 D 0000000000000003 0 37 2 0x00000000
> [504603.273473] ffff88034428bc10 0000000000000046 ffff88034428bfd8 ffff88034428a000
> [504603.273479] 0000000000013a80 ffff8803442903a0 ffff88034428bfd8 0000000000013a80
> [504603.273483] ffff88034572ad80 ffff880344290000 ffffffffffffff10 ffff880343a51e28
> [504603.273488] Call Trace:
> [504603.273500] [<ffffffff815ce917>] __mutex_lock_slowpath+0xf7/0x180
> [504603.273504] [<ffffffff815ce303>] mutex_lock+0x23/0x50
> [504603.273541] [<ffffffffa00cf709>] xfs_qm_dqreclaim_one+0x29/0x350 [xfs]
> [504603.273554] [<ffffffffa00cfaed>] xfs_qm_shake_freelist+0x1d/0x40 [xfs]
> [504603.273567] [<ffffffffa00cfb69>] xfs_qm_shake+0x59/0x70 [xfs]
> [504603.273573] [<ffffffff8111d619>] shrink_slab+0x89/0x180
> [504603.273577] [<ffffffff81120420>] balance_pgdat+0x2b0/0x530
> [504603.273580] [<ffffffff811207df>] kswapd+0x13f/0x2b0
> [504603.273585] [<ffffffff81087d30>] ? autoremove_wake_function+0x0/0x40
> [504603.273588] [<ffffffff811206a0>] ? kswapd+0x0/0x2b0
> [504603.273591] [<ffffffff81087606>] kthread+0x96/0xa0
> [504603.273596] [<ffffffff8100cea4>] kernel_thread_helper+0x4/0x10
> [504603.273599] [<ffffffff81087570>] ? kthread+0x0/0xa0
> [504603.273603] [<ffffffff8100cea0>] ? kernel_thread_helper+0x0/0x10
[snip]
Looks like everything is hung up on the freelist lock. Can you
test the patch below?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
xfs: fix dquot shaker deadlock
From: Dave Chinner <dchinner@redhat.com>
Commit 368e136 ("xfs: remove duplicate code from dquot reclaim") fails
to unlock the dquot freelist when the number of loop restarts is
exceeded in xfs_qm_dqreclaim_one(). This causes hangs in memory
reclaim. Remove the bogus loop exit check that causes the problem.
Reported-by: Malcolm Scott <lkml@malc.org.uk>
Signed-off-by: Dave Chinner <dchinner@redhat.com>
---
fs/xfs/quota/xfs_qm.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/fs/xfs/quota/xfs_qm.c b/fs/xfs/quota/xfs_qm.c
index f8e854b..9431c56 100644
--- a/fs/xfs/quota/xfs_qm.c
+++ b/fs/xfs/quota/xfs_qm.c
@@ -1992,8 +1992,6 @@ dqfunlock:
xfs_dqunlock(dqp);
if (dqpout)
break;
- if (restarts >= XFS_QM_RECLAIM_MAX_RESTARTS)
- return NULL;
}
mutex_unlock(&xfs_Gqm->qm_dqfrlist_lock);
return dqpout;
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: Malcolm Scott <lkml@malc.org.uk>
Cc: linux-kernel@vger.kernel.org, xfs@oss.sgi.com
Subject: [PATCH] Re: XFS deadlock in 2.6.37
Date: Fri, 21 Jan 2011 16:28:02 +1100 [thread overview]
Message-ID: <20110121052802.GA16267@dastard> (raw)
In-Reply-To: <alpine.DEB.2.00.1101201702260.29071@callisto.malc.org.uk>
[cc xfs@os.sgi.com]
On Thu, Jan 20, 2011 at 05:08:45PM +0000, Malcolm Scott wrote:
> Hi all,
>
> I've had the following deadlock happen twice on a 2.6.37 system with
> several XFS filesystems (including root) and no swap (may be
> relevant, considering that kswapd is one task involved here). Some
> minor filesystem corruption resulted (but maybe only because the
> root fs couldn't be synced/umounted).
>
> If you need any more info, please let me know.
>
> --- first crash ---
>
> [504603.250208] INFO: task kswapd0:37 blocked for more than 120 seconds.
> [504603.261107] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
> [504603.273465] kswapd0 D 0000000000000003 0 37 2 0x00000000
> [504603.273473] ffff88034428bc10 0000000000000046 ffff88034428bfd8 ffff88034428a000
> [504603.273479] 0000000000013a80 ffff8803442903a0 ffff88034428bfd8 0000000000013a80
> [504603.273483] ffff88034572ad80 ffff880344290000 ffffffffffffff10 ffff880343a51e28
> [504603.273488] Call Trace:
> [504603.273500] [<ffffffff815ce917>] __mutex_lock_slowpath+0xf7/0x180
> [504603.273504] [<ffffffff815ce303>] mutex_lock+0x23/0x50
> [504603.273541] [<ffffffffa00cf709>] xfs_qm_dqreclaim_one+0x29/0x350 [xfs]
> [504603.273554] [<ffffffffa00cfaed>] xfs_qm_shake_freelist+0x1d/0x40 [xfs]
> [504603.273567] [<ffffffffa00cfb69>] xfs_qm_shake+0x59/0x70 [xfs]
> [504603.273573] [<ffffffff8111d619>] shrink_slab+0x89/0x180
> [504603.273577] [<ffffffff81120420>] balance_pgdat+0x2b0/0x530
> [504603.273580] [<ffffffff811207df>] kswapd+0x13f/0x2b0
> [504603.273585] [<ffffffff81087d30>] ? autoremove_wake_function+0x0/0x40
> [504603.273588] [<ffffffff811206a0>] ? kswapd+0x0/0x2b0
> [504603.273591] [<ffffffff81087606>] kthread+0x96/0xa0
> [504603.273596] [<ffffffff8100cea4>] kernel_thread_helper+0x4/0x10
> [504603.273599] [<ffffffff81087570>] ? kthread+0x0/0xa0
> [504603.273603] [<ffffffff8100cea0>] ? kernel_thread_helper+0x0/0x10
[snip]
Looks like everything is hung up on the freelist lock. Can you
test the patch below?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
xfs: fix dquot shaker deadlock
From: Dave Chinner <dchinner@redhat.com>
Commit 368e136 ("xfs: remove duplicate code from dquot reclaim") fails
to unlock the dquot freelist when the number of loop restarts is
exceeded in xfs_qm_dqreclaim_one(). This causes hangs in memory
reclaim. Remove the bogus loop exit check that causes the problem.
Reported-by: Malcolm Scott <lkml@malc.org.uk>
Signed-off-by: Dave Chinner <dchinner@redhat.com>
---
fs/xfs/quota/xfs_qm.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/fs/xfs/quota/xfs_qm.c b/fs/xfs/quota/xfs_qm.c
index f8e854b..9431c56 100644
--- a/fs/xfs/quota/xfs_qm.c
+++ b/fs/xfs/quota/xfs_qm.c
@@ -1992,8 +1992,6 @@ dqfunlock:
xfs_dqunlock(dqp);
if (dqpout)
break;
- if (restarts >= XFS_QM_RECLAIM_MAX_RESTARTS)
- return NULL;
}
mutex_unlock(&xfs_Gqm->qm_dqfrlist_lock);
return dqpout;
next prev parent reply other threads:[~2011-01-21 5:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-20 17:08 XFS deadlock in 2.6.37 Malcolm Scott
2011-01-20 17:27 ` William Pitcock
2011-01-21 5:28 ` Dave Chinner [this message]
2011-01-21 5:28 ` [PATCH] " Dave Chinner
2011-01-25 17:13 ` Malcolm Scott
2011-01-25 17:13 ` Malcolm Scott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110121052802.GA16267@dastard \
--to=david@fromorbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml@malc.org.uk \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.