All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Sergei Shtylyov <sshtylyov@mvista.com>
Cc: Sumit Semwal <sumit.semwal@ti.com>,
	khilman@ti.com, paul@pwsan.com,
	Senthilvadivu Guruswamy <svadivu@ti.com>,
	hvaibhav@ti.com, tomi.valkeinen@nokia.com,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v9 18/18] OMAP2,3: DSS2: Get DSS IRQ from platform device
Date: Sun, 23 Jan 2011 12:52:16 +0000	[thread overview]
Message-ID: <20110123125216.GA29926@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <4D3C217B.9020301@ru.mvista.com>

On Sun, Jan 23, 2011 at 03:39:23PM +0300, Sergei Shtylyov wrote:
>> diff --git a/drivers/video/omap2/dss/dss.c b/drivers/video/omap2/dss/dss.c
>> index 4d7a816..22690e9 100644
>> --- a/drivers/video/omap2/dss/dss.c
>> +++ b/drivers/video/omap2/dss/dss.c
> [...]
>> @@ -609,15 +609,18 @@ static int dss_init(bool skip_init)
>>   	REG_FLD_MOD(DSS_CONTROL, 0, 2, 2);	/* venc clock mode = normal */
>>   #endif
>>
>> -	r = request_irq(INT_24XX_DSS_IRQ,
>> +	dss_irq = platform_get_irq(dss.pdev, 0);
>> +	if (dss_irq != -ENXIO) {
>
>    Better just 'dss_irq > 0', IMHO.

If a function returns negative error codes, the correct test is
	ret < 0
not
	ret <= 0

The fact that it happens to be dealing with IRQ numbers where IRQ0
may not be valid is neither here nor there.

WARNING: multiple messages have this Message-ID (diff)
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v9 18/18] OMAP2,3: DSS2: Get DSS IRQ from platform device
Date: Sun, 23 Jan 2011 12:52:16 +0000	[thread overview]
Message-ID: <20110123125216.GA29926@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <4D3C217B.9020301@ru.mvista.com>

On Sun, Jan 23, 2011 at 03:39:23PM +0300, Sergei Shtylyov wrote:
>> diff --git a/drivers/video/omap2/dss/dss.c b/drivers/video/omap2/dss/dss.c
>> index 4d7a816..22690e9 100644
>> --- a/drivers/video/omap2/dss/dss.c
>> +++ b/drivers/video/omap2/dss/dss.c
> [...]
>> @@ -609,15 +609,18 @@ static int dss_init(bool skip_init)
>>   	REG_FLD_MOD(DSS_CONTROL, 0, 2, 2);	/* venc clock mode = normal */
>>   #endif
>>
>> -	r = request_irq(INT_24XX_DSS_IRQ,
>> +	dss_irq = platform_get_irq(dss.pdev, 0);
>> +	if (dss_irq != -ENXIO) {
>
>    Better just 'dss_irq > 0', IMHO.

If a function returns negative error codes, the correct test is
	ret < 0
not
	ret <= 0

The fact that it happens to be dealing with IRQ numbers where IRQ0
may not be valid is neither here nor there.

  reply	other threads:[~2011-01-23 12:52 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-22 10:05 [PATCH v9 00/18] OMAP2,3: hwmod DSS Adaptation Sumit Semwal
2011-01-22 10:05 ` Sumit Semwal
2011-01-22 10:05 ` [PATCH v9 01/18] OMAP2,3: DSS2: remove forced clk-disable from omap_dss_remove Sumit Semwal
2011-01-22 10:05   ` [PATCH v9 01/18] OMAP2, 3: " Sumit Semwal
2011-01-22 10:05 ` [PATCH v9 02/18] OMAP2420: hwmod data: add DSS DISPC RFBI VENC Sumit Semwal
2011-01-22 10:05   ` Sumit Semwal
2011-01-22 10:05 ` [PATCH v9 03/18] OMAP2430: " Sumit Semwal
2011-01-22 10:05   ` Sumit Semwal
2011-01-22 10:05 ` [PATCH v9 04/18] OMAP3: hwmod data: add DSS DISPC RFBI DSI VENC Sumit Semwal
2011-01-22 10:05   ` Sumit Semwal
2011-01-22 10:05 ` [PATCH v9 05/18] OMAP2,3 DSS2 Change driver name to omap_display Sumit Semwal
2011-01-22 10:05   ` Sumit Semwal
2011-01-22 10:05 ` [PATCH v9 06/18] OMAP2,3 DSS2 Use Regulator init with driver name Sumit Semwal
2011-01-22 10:05   ` Sumit Semwal
2011-01-22 10:05 ` [PATCH v9 07/18] OMAP2,3: DSS2: Create new file display.c for central dss driver registration Sumit Semwal
2011-01-22 10:05   ` [PATCH v9 07/18] OMAP2, 3: " Sumit Semwal
2011-01-22 10:05 ` [PATCH v9 08/18] OMAP2,3: DSS2: board files: replace platform_device_register with omap_display_init() Sumit Semwal
2011-01-22 10:05   ` [PATCH v9 08/18] OMAP2, 3: " Sumit Semwal
2011-01-22 10:05 ` [PATCH v9 09/18] OMAP2,3: DSS2: Build omap_device for each DSS HWIP Sumit Semwal
2011-01-22 10:05   ` Sumit Semwal
2011-01-22 10:05 ` [PATCH v9 10/18] OMAP2,3: DSS2: DSS: create platform_driver, move init,exit to driver Sumit Semwal
2011-01-22 10:05   ` [PATCH v9 10/18] OMAP2, 3: DSS2: DSS: create platform_driver, move init, exit " Sumit Semwal
2011-01-22 10:05 ` [PATCH v9 11/18] OMAP2,3: DSS2: Move clocks from core driver to dss driver Sumit Semwal
2011-01-22 10:05   ` [PATCH v9 11/18] OMAP2, 3: " Sumit Semwal
2011-01-22 10:05 ` [PATCH v9 12/18] OMAP2,3: DSS2: RFBI: create platform_driver, move init,exit to driver Sumit Semwal
2011-01-22 10:05   ` [PATCH v9 12/18] OMAP2, 3: DSS2: RFBI: create platform_driver, move init, exit " Sumit Semwal
2011-01-22 10:05 ` [PATCH v9 13/18] OMAP2,3: DSS2: DISPC: create platform_driver, move init,exit " Sumit Semwal
2011-01-22 10:05   ` [PATCH v9 13/18] OMAP2, 3: DSS2: DISPC: create platform_driver, move init, exit " Sumit Semwal
2011-01-22 10:05 ` [PATCH v9 14/18] OMAP2,3: DSS2: VENC: create platform_driver, move init,exit " Sumit Semwal
2011-01-22 10:05   ` [PATCH v9 14/18] OMAP2, 3: DSS2: VENC: create platform_driver, move init, exit " Sumit Semwal
2011-01-22 10:05 ` [PATCH v9 15/18] OMAP2,3: DSS2: DSI: create platform_driver, move init,exit " Sumit Semwal
2011-01-22 10:05   ` [PATCH v9 15/18] OMAP2, 3: DSS2: DSI: create platform_driver, move init, exit " Sumit Semwal
2011-01-22 10:05 ` [PATCH v9 16/18] OMAP2,3: DSS2: replace printk with dev_dbg in init Sumit Semwal
2011-01-22 10:05   ` Sumit Semwal
2011-01-22 10:05 ` [PATCH v9 17/18] OMAP2,3: DSS2: Use platform device to get baseaddr Sumit Semwal
2011-01-22 10:05   ` Sumit Semwal
2011-01-22 10:05 ` [PATCH v9 18/18] OMAP2,3: DSS2: Get DSS IRQ from platform device Sumit Semwal
2011-01-22 10:05   ` Sumit Semwal
2011-01-23 12:39   ` Sergei Shtylyov
2011-01-23 12:39     ` Sergei Shtylyov
2011-01-23 12:52     ` Russell King - ARM Linux [this message]
2011-01-23 12:52       ` Russell King - ARM Linux
2011-01-24  5:50       ` Semwal, Sumit
2011-01-24  5:50         ` Semwal, Sumit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110123125216.GA29926@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=hvaibhav@ti.com \
    --cc=khilman@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=sshtylyov@mvista.com \
    --cc=sumit.semwal@ti.com \
    --cc=svadivu@ti.com \
    --cc=tomi.valkeinen@nokia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.