From: Greg KH <gregkh@suse.de>
To: Bob Liu <lliubbo@gmail.com>
Cc: "Berg, Johannes" <johannes.berg@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"chrisw@sous-sol.org" <chrisw@sous-sol.org>,
"Winkler, Tomas" <tomas.winkler@intel.com>,
"dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>
Subject: Re: [PATCH] firmware_classs: change val uevent's type to bool
Date: Wed, 26 Jan 2011 18:15:56 +0800 [thread overview]
Message-ID: <20110126101556.GA16446@suse.de> (raw)
In-Reply-To: <AANLkTinzHZorkTpDSv5J9_Q5kO5UUFnZb3CAafyOu2Qe@mail.gmail.com>
On Wed, Jan 26, 2011 at 06:03:32PM +0800, Bob Liu wrote:
> On Wed, Jan 26, 2011 at 5:56 PM, Berg, Johannes <johannes.berg@intel.com> wrote:
> > @@ -463,7 +463,8 @@ fw_create_instance(struct firmware *firmware, const char *fw_name,
> > f_dev->parent = device;
> > f_dev->class = &firmware_class;
> >
> > - dev_set_uevent_suppress(f_dev, true);
> > + if (uevent)
> > + dev_set_uevent_suppress(f_dev, true);
> >
> > Everything but this is a no-op basically, but you didn't even describe this change?
> >
>
>
> Hmm.. Sorry for that, but I mentioned that by "fix a place missing
> uevent check".
> I added this check because I think it should be paired with following
> dev_set_uevent_suppress(f_dev, false).
That's fine, but please, split that out into a separate patch.
Remember, a patch should only do one thing.
Please resend this as two patches and I will be glad to queue it up.
thanks,
greg k-h
next prev parent reply other threads:[~2011-01-26 10:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-26 10:00 [PATCH] firmware_classs: change val uevent's type to bool Bob Liu
2011-01-26 9:56 ` Berg, Johannes
2011-01-26 10:03 ` Bob Liu
2011-01-26 10:15 ` Greg KH [this message]
2011-01-26 10:23 ` Berg, Johannes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110126101556.GA16446@suse.de \
--to=gregkh@suse.de \
--cc=chrisw@sous-sol.org \
--cc=dmitry.torokhov@gmail.com \
--cc=johannes.berg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lliubbo@gmail.com \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.