From: "Michael S. Tsirkin" <mst@redhat.com>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH v2 4/5] pci: use PCI_SLOT in pci_get_bus_devfn()
Date: Thu, 27 Jan 2011 09:31:56 +0200 [thread overview]
Message-ID: <20110127073156.GB28784@redhat.com> (raw)
In-Reply-To: <bd7f33e8c88e87971f4eaeacf4432729f53e86c5.1296111201.git.yamahata@valinux.co.jp>
On Thu, Jan 27, 2011 at 03:56:38PM +0900, Isaku Yamahata wrote:
> use PCI_SLOT in pci_get_bus_devfn().
>
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
Tweaked the comment and applied.
> ---
> hw/pci.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/pci.c b/hw/pci.c
> index 471d4d7..e25bf7a 100644
> --- a/hw/pci.c
> +++ b/hw/pci.c
> @@ -558,7 +558,7 @@ PCIBus *pci_get_bus_devfn(int *devfnp, const char *devaddr)
> return NULL;
> }
>
> - *devfnp = slot << 3;
> + *devfnp = PCI_DEVFN(slot, 0);
> return pci_find_bus(pci_find_root_bus(dom), bus);
> }
>
> --
> 1.7.1.1
next prev parent reply other threads:[~2011-01-27 7:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-27 6:56 [Qemu-devel] [PATCH v2 0/5] pci/pcie: implement ARI enable bit correctly Isaku Yamahata
2011-01-27 6:56 ` [Qemu-devel] [PATCH v2 1/5] pci: replace the magic, 256, for the maximum of devfn Isaku Yamahata
2011-01-27 7:09 ` [Qemu-devel] " Michael S. Tsirkin
2011-01-27 6:56 ` [Qemu-devel] [PATCH v2 2/5] pci: use devfn for pci_find_device() instead of (slot, fn) pair Isaku Yamahata
2011-01-27 7:11 ` [Qemu-devel] " Michael S. Tsirkin
2011-01-27 6:56 ` [Qemu-devel] [PATCH v2 3/5] pci/pcie: make pci_find_device() ARI aware Isaku Yamahata
2011-01-27 7:30 ` [Qemu-devel] " Michael S. Tsirkin
2011-01-27 6:56 ` [Qemu-devel] [PATCH v2 4/5] pci: use PCI_SLOT in pci_get_bus_devfn() Isaku Yamahata
2011-01-27 7:31 ` Michael S. Tsirkin [this message]
2011-01-27 6:56 ` [Qemu-devel] [PATCH v2 5/5] pci: use uint8_t for devfn_min Isaku Yamahata
2011-01-27 7:32 ` [Qemu-devel] " Michael S. Tsirkin
2011-01-27 8:42 ` [Qemu-devel] Re: [PATCH v2 0/5] pci/pcie: implement ARI enable bit correctly Michael S. Tsirkin
2011-01-27 10:22 ` Isaku Yamahata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110127073156.GB28784@redhat.com \
--to=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.