From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jarkko Nikula <jhnikula@gmail.com>
Cc: alsa-devel@alsa-project.org,
Peter Ujfalusi <peter.ujfalusi@nokia.com>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 4/4] ASoC: Convert bunch of codecs to use soc-core interconnect registration
Date: Thu, 27 Jan 2011 09:58:18 +0000 [thread overview]
Message-ID: <20110127095817.GC1338@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20110127092116.e29f5cb1.jhnikula@gmail.com>
On Thu, Jan 27, 2011 at 09:21:16AM +0200, Jarkko Nikula wrote:
> Peter Ujfalusi <peter.ujfalusi@nokia.com> wrote:
> > I don't see how these actually simplifies the codec drivers.
> > We had a single snd_soc_dapm_add_routes call before the patches, now we
> > have two fields to fill in snd_soc_codec_driver...
> Yeah, simplification comes only if a driver is checking the return value
> what most are not doing currently.
For me anything that moves things from code to data structures is a
simplification since it reduces the variation between drivers. It's not
going to make a massive difference either way to the driver itself but
it makes life easier if you want to do something to all drivers.
next prev parent reply other threads:[~2011-01-27 10:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-26 11:58 [PATCH 1/4] ASoC: soc-core: Increment codec and platform driver refcounts before probing Jarkko Nikula
2011-01-26 11:58 ` [PATCH 2/4] ASoC: Add optional pointer to machine audio routes to snd_soc_card Jarkko Nikula
2011-01-26 13:35 ` Mark Brown
2011-01-26 11:58 ` [PATCH 3/4] ASoC: Add optional pointer to codec interconnects to snd_soc_codec_driver Jarkko Nikula
2011-01-26 13:41 ` Mark Brown
2011-01-26 11:58 ` [PATCH 4/4] ASoC: Convert bunch of codecs to use soc-core interconnect registration Jarkko Nikula
2011-01-26 13:28 ` Mark Brown
2011-01-26 13:41 ` Jarkko Nikula
2011-01-27 6:57 ` Peter Ujfalusi
2011-01-27 7:21 ` Jarkko Nikula
2011-01-27 9:58 ` Mark Brown [this message]
2011-01-26 14:28 ` [PATCH 1/4] ASoC: soc-core: Increment codec and platform driver refcounts before probing Jarkko Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110127095817.GC1338@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=jhnikula@gmail.com \
--cc=lrg@slimlogic.co.uk \
--cc=peter.ujfalusi@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.