From: Andrew Morton <akpm@linux-foundation.org>
To: Sunil Mushran <sunil.mushran@oracle.com>
Cc: dsterba@suse.cz, mfasheh@suse.com, linux-kernel@vger.kernel.org,
ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] fs/ocfs2/dlm: Use GFP_ATOMIC under spin_lock
Date: Thu, 27 Jan 2011 17:48:01 -0800 [thread overview]
Message-ID: <20110127174801.c22d693b.akpm@linux-foundation.org> (raw)
In-Reply-To: <4D421BD5.30903@oracle.com>
On Thu, 27 Jan 2011 17:28:53 -0800 Sunil Mushran <sunil.mushran@oracle.com> wrote:
> > return status;
> > }
> >
> > @@ -1077,6 +1069,7 @@ static int dlm_query_region_handler(stru
> > struct dlm_ctxt *dlm = NULL;
> > int status = 0;
> > int locked = 0;
> > + static u8 local[sizeof(qr->qr_regions)]; /* locked by dlm_domain_lock */
> >
> > qr = (struct dlm_query_region *) msg->buf;
> >
> > @@ -1112,7 +1105,7 @@ static int dlm_query_region_handler(stru
> > goto bail;
> > }
> >
> > - status = dlm_match_regions(dlm, qr);
> > + status = dlm_match_regions(dlm, qr, local);
> >
> > bail:
> > if (locked)
>
> That sizeof() is 1K. It maybe better if we moved the kmalloc() here.
That would work too. As it's only called at mount time, the
speed/space tradeoff favours kmalloc().
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Sunil Mushran <sunil.mushran@oracle.com>
Cc: dsterba@suse.cz, mfasheh@suse.com, linux-kernel@vger.kernel.org,
ocfs2-devel@oss.oracle.com
Subject: Re: [Ocfs2-devel] fs/ocfs2/dlm: Use GFP_ATOMIC under spin_lock
Date: Thu, 27 Jan 2011 17:48:01 -0800 [thread overview]
Message-ID: <20110127174801.c22d693b.akpm@linux-foundation.org> (raw)
In-Reply-To: <4D421BD5.30903@oracle.com>
On Thu, 27 Jan 2011 17:28:53 -0800 Sunil Mushran <sunil.mushran@oracle.com> wrote:
> > return status;
> > }
> >
> > @@ -1077,6 +1069,7 @@ static int dlm_query_region_handler(stru
> > struct dlm_ctxt *dlm = NULL;
> > int status = 0;
> > int locked = 0;
> > + static u8 local[sizeof(qr->qr_regions)]; /* locked by dlm_domain_lock */
> >
> > qr = (struct dlm_query_region *) msg->buf;
> >
> > @@ -1112,7 +1105,7 @@ static int dlm_query_region_handler(stru
> > goto bail;
> > }
> >
> > - status = dlm_match_regions(dlm, qr);
> > + status = dlm_match_regions(dlm, qr, local);
> >
> > bail:
> > if (locked)
>
> That sizeof() is 1K. It maybe better if we moved the kmalloc() here.
That would work too. As it's only called at mount time, the
speed/space tradeoff favours kmalloc().
next prev parent reply other threads:[~2011-01-28 1:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-02 22:36 fs/ocfs2/dlm: Use GFP_ATOMIC under spin_lock David Sterba
2010-11-02 22:36 ` [Ocfs2-devel] " David Sterba
2010-11-18 23:42 ` Joel Becker
2010-11-18 23:42 ` Joel Becker
2011-01-28 1:09 ` [Ocfs2-devel] " Andrew Morton
2011-01-28 1:09 ` Andrew Morton
2011-01-28 1:28 ` [Ocfs2-devel] " Sunil Mushran
2011-01-28 1:28 ` Sunil Mushran
2011-01-28 1:48 ` Andrew Morton [this message]
2011-01-28 1:48 ` Andrew Morton
2011-01-28 1:35 ` Joel Becker
2011-01-28 1:35 ` Joel Becker
2011-01-28 1:48 ` Andrew Morton
2011-01-28 1:48 ` Andrew Morton
2011-01-28 2:33 ` Joel Becker
2011-01-28 2:33 ` Joel Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110127174801.c22d693b.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dsterba@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mfasheh@suse.com \
--cc=ocfs2-devel@oss.oracle.com \
--cc=sunil.mushran@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.