All of lore.kernel.org
 help / color / mirror / Atom feed
* gcov/lcov
@ 2011-02-01  5:21 Sage Weil
  2011-02-01 17:27 ` gcov/lcov Tommi Virtanen
  0 siblings, 1 reply; 4+ messages in thread
From: Sage Weil @ 2011-02-01  5:21 UTC (permalink / raw)
  To: tv; +Cc: ceph-devel

We should set up gcov/lcov as part of the testing infrastructure so we can 
track what code paths are tested:

        http://ltp.sourceforge.net/coverage/lcov.php

sage




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: gcov/lcov
  2011-02-01  5:21 gcov/lcov Sage Weil
@ 2011-02-01 17:27 ` Tommi Virtanen
  2011-02-01 17:35   ` gcov/lcov Gregory Farnum
  2011-02-02  2:42   ` gcov/lcov Colin McCabe
  0 siblings, 2 replies; 4+ messages in thread
From: Tommi Virtanen @ 2011-02-01 17:27 UTC (permalink / raw)
  To: Sage Weil; +Cc: ceph-devel

On Mon, Jan 31, 2011 at 09:21:14PM -0800, Sage Weil wrote:
> We should set up gcov/lcov as part of the testing infrastructure so we can 
> track what code paths are tested:
> 
>         http://ltp.sourceforge.net/coverage/lcov.php

That has been in the plans from day one. Line & branch coverage are
awesome tools.

Just focusing on system-level testing right now.. Please write unit
tests, because otherwise the first coverage reports are going to be
really disappointing ;)

-- 
:(){ :|:&};:

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: gcov/lcov
  2011-02-01 17:27 ` gcov/lcov Tommi Virtanen
@ 2011-02-01 17:35   ` Gregory Farnum
  2011-02-02  2:42   ` gcov/lcov Colin McCabe
  1 sibling, 0 replies; 4+ messages in thread
From: Gregory Farnum @ 2011-02-01 17:35 UTC (permalink / raw)
  To: Tommi Virtanen; +Cc: Sage Weil, ceph-devel

On Tue, Feb 1, 2011 at 9:27 AM, Tommi Virtanen
<tommi.virtanen@dreamhost.com> wrote:
> That has been in the plans from day one. Line & branch coverage are
> awesome tools.
The first time I used Clover I think my team and I spent 2 hours
picking our jaws up off the floor. They don't really discuss that kind
of thing too much in an academic setting, but damn is it useful. I
didn't realize there are any open-source versions that are any good.

> Just focusing on system-level testing right now.. Please write unit
> tests, because otherwise the first coverage reports are going to be
> really disappointing ;)
I think they're going to be disappointing anyway. :/ I wrote unit
tests for the one "unit" that I changed, but I think part of the
appeal of using a tool like this will be helping us decide where in
our old code we should concentrate our efforts.
-Greg

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: gcov/lcov
  2011-02-01 17:27 ` gcov/lcov Tommi Virtanen
  2011-02-01 17:35   ` gcov/lcov Gregory Farnum
@ 2011-02-02  2:42   ` Colin McCabe
  1 sibling, 0 replies; 4+ messages in thread
From: Colin McCabe @ 2011-02-02  2:42 UTC (permalink / raw)
  To: Tommi Virtanen; +Cc: Sage Weil, ceph-devel

On Tue, Feb 1, 2011 at 9:27 AM, Tommi Virtanen
<tommi.virtanen@dreamhost.com> wrote:
> On Mon, Jan 31, 2011 at 09:21:14PM -0800, Sage Weil wrote:
>> We should set up gcov/lcov as part of the testing infrastructure so we can
>> track what code paths are tested:
>>
>>         http://ltp.sourceforge.net/coverage/lcov.php

That's pretty cool. It seems like this should be usable with both
system tests and unit tests.

On Tue, Feb 1, 2011 at 9:27 AM, Tommi Virtanen
<tommi.virtanen@dreamhost.com> wrote:
> Please write unit
> tests, because otherwise the first coverage reports are going to be
> really disappointing ;)

Oh, by the way, I actually did write PG history merging unit test I
was talking about. It's in the refactor_pg branch now.

Eventually we should start unit testing more complex history merges.
But the current test is a start at least.

cheers,
Colin
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2011-02-02  2:42 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-01  5:21 gcov/lcov Sage Weil
2011-02-01 17:27 ` gcov/lcov Tommi Virtanen
2011-02-01 17:35   ` gcov/lcov Gregory Farnum
2011-02-02  2:42   ` gcov/lcov Colin McCabe

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.