From: Dave Chinner <david@fromorbit.com>
To: Mark Lord <kernel@teksavvy.com>
Cc: akpm@linux-foundation.org, xfs@oss.sgi.com,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
Alex Elder <aelder@sgi.com>
Subject: Re: [GIT PULL] XFS update for 2.6.38-rc3
Date: Thu, 3 Feb 2011 11:07:57 +1100 [thread overview]
Message-ID: <20110203000757.GT11040@dastard> (raw)
In-Reply-To: <4D482E21.5040803@teksavvy.com>
On Tue, Feb 01, 2011 at 11:00:33AM -0500, Mark Lord wrote:
> On 11-01-31 11:42 AM, Alex Elder wrote:
> > Linus, please accept the following updates for XFS, for 2.6.38-rc3
> > (if it's not too late) or 2.6.38-rc4.
> >
> > They are all fixes for bugs that have some pretty undesirable
> > consequences. They address:
> > - One spot in which a hang can occur due to neglecting to drop a
> > lock
> > - A bug which in some cases a bogus block number can be recorded in
> > a block map btree, resulting in a subsequent BUG_ON().
> > - Two memory leaks
> > - Three places in which extent sizes are allowed to exceed various
> > size limits
> > - One place where code depends on behavior that is not well-defined
> > by the C standard
> > - One problem in handling transaction commit errors
>
>
> Are these bugs all new in 2.6.38, or should some of these fixes
> also go out to -stable for earlier revisions?
>
>
> > Dave Chinner (8):
> > xfs: fix log ticket leak on forced shutdown.
> > xfs: fix efi item leak on forced shutdown
Been there for years, extremely hard to hit, so no.
> > xfs: speculative delayed allocation uses rounddown_power_of_2 badly
-38-rc1 regression, so no.
> > xfs: limit extent length for allocation to AG size
> > xfs: prevent extsize alignment from exceeding maximum extent size
> > xfs: limit extsize to size of AGs and/or MAXEXTLEN
Been there for years in little used functionality, so no.
> > xfs: handle CIl transaction commit failures correctly
Introduced with new code in 2.6.35, hard to hit, only results in
small memory leaks, so no.
> > xfs: fix dquot shaker deadlock
That's a regression, so maybe.
> > bpm@sgi.com (1):
> > xfs: xfs_bmap_add_extent_delay_real should init br_startblock
Been there for years, no evidence ATM that this code path can be
exercised with a mainline kernel, so no.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: Mark Lord <kernel@teksavvy.com>
Cc: Alex Elder <aelder@sgi.com>,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
xfs@oss.sgi.com, akpm@linux-foundation.org
Subject: Re: [GIT PULL] XFS update for 2.6.38-rc3
Date: Thu, 3 Feb 2011 11:07:57 +1100 [thread overview]
Message-ID: <20110203000757.GT11040@dastard> (raw)
In-Reply-To: <4D482E21.5040803@teksavvy.com>
On Tue, Feb 01, 2011 at 11:00:33AM -0500, Mark Lord wrote:
> On 11-01-31 11:42 AM, Alex Elder wrote:
> > Linus, please accept the following updates for XFS, for 2.6.38-rc3
> > (if it's not too late) or 2.6.38-rc4.
> >
> > They are all fixes for bugs that have some pretty undesirable
> > consequences. They address:
> > - One spot in which a hang can occur due to neglecting to drop a
> > lock
> > - A bug which in some cases a bogus block number can be recorded in
> > a block map btree, resulting in a subsequent BUG_ON().
> > - Two memory leaks
> > - Three places in which extent sizes are allowed to exceed various
> > size limits
> > - One place where code depends on behavior that is not well-defined
> > by the C standard
> > - One problem in handling transaction commit errors
>
>
> Are these bugs all new in 2.6.38, or should some of these fixes
> also go out to -stable for earlier revisions?
>
>
> > Dave Chinner (8):
> > xfs: fix log ticket leak on forced shutdown.
> > xfs: fix efi item leak on forced shutdown
Been there for years, extremely hard to hit, so no.
> > xfs: speculative delayed allocation uses rounddown_power_of_2 badly
-38-rc1 regression, so no.
> > xfs: limit extent length for allocation to AG size
> > xfs: prevent extsize alignment from exceeding maximum extent size
> > xfs: limit extsize to size of AGs and/or MAXEXTLEN
Been there for years in little used functionality, so no.
> > xfs: handle CIl transaction commit failures correctly
Introduced with new code in 2.6.35, hard to hit, only results in
small memory leaks, so no.
> > xfs: fix dquot shaker deadlock
That's a regression, so maybe.
> > bpm@sgi.com (1):
> > xfs: xfs_bmap_add_extent_delay_real should init br_startblock
Been there for years, no evidence ATM that this code path can be
exercised with a mainline kernel, so no.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2011-02-03 0:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-31 16:42 [GIT PULL] XFS update for 2.6.38-rc3 Alex Elder
2011-01-31 16:42 ` Alex Elder
2011-02-01 16:00 ` Mark Lord
2011-02-01 16:00 ` Mark Lord
2011-02-03 0:07 ` Dave Chinner [this message]
2011-02-03 0:07 ` Dave Chinner
2011-02-03 22:02 ` Arkadiusz Miskiewicz
2011-02-03 22:02 ` Arkadiusz Miskiewicz
2011-02-16 21:50 ` [stable] " Greg KH
2011-02-16 21:50 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110203000757.GT11040@dastard \
--to=david@fromorbit.com \
--cc=aelder@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=kernel@teksavvy.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.