From: Johannes Weiner <hannes@cmpxchg.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: kamezawa.hiroyu@jp.fujitsu.com, nishimura@mxp.nes.nec.co.jp,
balbir@linux.vnet.ibm.com, minchan.kim@gmail.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [patch 0/2] memcg: clean up limit checking
Date: Thu, 3 Feb 2011 13:53:57 +0100 [thread overview]
Message-ID: <20110203125357.GA2286@cmpxchg.org> (raw)
In-Reply-To: <20110131162448.e791f0ae.akpm@linux-foundation.org>
On Mon, Jan 31, 2011 at 04:24:48PM -0800, Andrew Morton wrote:
> On Tue, 1 Feb 2011 01:04:55 +0100
> Johannes Weiner <hannes@cmpxchg.org> wrote:
>
> > Maybe it would be better to use res_counter_margin(cnt) >= wanted
> > throughout the code.
>
> yup.
Okay, I cleaned it all up a bit for .39. While doing so, I also found
that we are reclaiming one page too much when pushing back on behalf
of soft limits.
So 1/2 fixes the soft limit reclaim off-by-one-page, and 2/2 reduces
all the limit checks to two functions.
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: kamezawa.hiroyu@jp.fujitsu.com, nishimura@mxp.nes.nec.co.jp,
balbir@linux.vnet.ibm.com, minchan.kim@gmail.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [patch 0/2] memcg: clean up limit checking
Date: Thu, 3 Feb 2011 13:53:57 +0100 [thread overview]
Message-ID: <20110203125357.GA2286@cmpxchg.org> (raw)
In-Reply-To: <20110131162448.e791f0ae.akpm@linux-foundation.org>
On Mon, Jan 31, 2011 at 04:24:48PM -0800, Andrew Morton wrote:
> On Tue, 1 Feb 2011 01:04:55 +0100
> Johannes Weiner <hannes@cmpxchg.org> wrote:
>
> > Maybe it would be better to use res_counter_margin(cnt) >= wanted
> > throughout the code.
>
> yup.
Okay, I cleaned it all up a bit for .39. While doing so, I also found
that we are reclaiming one page too much when pushing back on behalf
of soft limits.
So 1/2 fixes the soft limit reclaim off-by-one-page, and 2/2 reduces
all the limit checks to two functions.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-02-03 12:54 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-31 14:03 Johannes Weiner
2011-01-31 14:03 ` Johannes Weiner
2011-01-31 14:03 ` [patch 1/3] memcg: prevent endless loop when charging huge pages Johannes Weiner
2011-01-31 14:03 ` Johannes Weiner
2011-01-31 22:27 ` Minchan Kim
2011-01-31 22:27 ` Minchan Kim
2011-01-31 23:48 ` KAMEZAWA Hiroyuki
2011-01-31 23:48 ` KAMEZAWA Hiroyuki
2011-01-31 14:03 ` [patch 2/3] memcg: prevent endless loop when charging huge pages to near-limit group Johannes Weiner
2011-01-31 14:03 ` Johannes Weiner
2011-01-31 22:41 ` Andrew Morton
2011-01-31 22:41 ` Andrew Morton
2011-01-31 23:50 ` KAMEZAWA Hiroyuki
2011-01-31 23:50 ` KAMEZAWA Hiroyuki
2011-02-01 0:04 ` Johannes Weiner
2011-02-01 0:04 ` Johannes Weiner
2011-02-01 0:24 ` Andrew Morton
2011-02-01 0:24 ` Andrew Morton
2011-02-01 0:34 ` Johannes Weiner
2011-02-01 0:34 ` Johannes Weiner
2011-02-03 12:53 ` Johannes Weiner [this message]
2011-02-03 12:53 ` [patch 0/2] memcg: clean up limit checking Johannes Weiner
2011-02-03 12:54 ` [patch 1/2] memcg: soft limit reclaim should end at limit not below Johannes Weiner
2011-02-03 12:54 ` Johannes Weiner
2011-02-03 23:41 ` KAMEZAWA Hiroyuki
2011-02-03 23:41 ` KAMEZAWA Hiroyuki
2011-02-04 4:10 ` Balbir Singh
2011-02-04 4:10 ` Balbir Singh
2011-02-03 12:56 ` [patch 2/2] memcg: simplify the way memory limits are checked Johannes Weiner
2011-02-03 12:56 ` Johannes Weiner
2011-02-03 23:44 ` KAMEZAWA Hiroyuki
2011-02-03 23:44 ` KAMEZAWA Hiroyuki
2011-02-04 4:12 ` Balbir Singh
2011-02-04 4:12 ` Balbir Singh
2011-01-31 22:42 ` [patch 2/3] memcg: prevent endless loop when charging huge pages to near-limit group Minchan Kim
2011-01-31 22:42 ` Minchan Kim
2011-01-31 14:03 ` [patch 3/3] memcg: never OOM when charging huge pages Johannes Weiner
2011-01-31 14:03 ` Johannes Weiner
2011-01-31 22:52 ` Minchan Kim
2011-01-31 22:52 ` Minchan Kim
2011-01-31 23:51 ` KAMEZAWA Hiroyuki
2011-01-31 23:51 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110203125357.GA2286@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
--cc=nishimura@mxp.nes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.